Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Tue, 3 Oct 2023 15:17:47 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in
 8250_pci.c
Message-ID: <ZRvAG5336KxuugVd@moxa-ThinkCentre-M90t>
References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com>
 <20231002015702.30509-2-crescentcy.hsieh@moxa.com>
 <68d533d5-dbc8-4be3-a1fc-b3dd28b8f9df@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <68d533d5-dbc8-4be3-a1fc-b3dd28b8f9df@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9zMdY0lVf+M9g2De+2ckoDKEY8mqFX5gaB3zyXqItPJEy8oi0Duykx/eoHVj?=
 =?us-ascii?Q?4JjKKrfn+l7AoHcimNTSrB/139vRMSG57p/EMcwsUBz68yQETEWYtCRLMJgF?=
 =?us-ascii?Q?6ZnXJdpxTfh1d4xtK649gxffZBFHWYh7K8uREr2SRd6huFMYH0WyVLgluY5M?=
 =?us-ascii?Q?5Fn9gbYJ0zFoUg3NdB5Cgy0MU22FXbj0A2K4hUTjcBf8CWpkEC85Ahs7LkXl?=
 =?us-ascii?Q?nI1hHC4pxZoXmsX5arKVPjUa4yMP9ar1H+FEss/jqumfrGWNZ/rZeUW/XtM9?=
 =?us-ascii?Q?SXXqRB6X5fEMWzNhNu93N0xUPIuz8g5OxbC3jz1ArBtotdiAVJfdClHAud1C?=
 =?us-ascii?Q?Bbi9+fFFsew8VdtqAuMVzL74XaAgykMLnFBEw4HIBmlcaWKCFQshF8HYl0RX?=
 =?us-ascii?Q?zThrUEQs80H/jCqDFtVxnWoUga16W67auTIRkoxR++eAffHAwpB6ZEndWb6L?=
 =?us-ascii?Q?EqNkryNpEA8RIF6w6ANKoBaxykOFuPUnUGamIYVKP1FGmM5Rg3SZ7+Lc+kRV?=
 =?us-ascii?Q?zKT2vcCu0YoCzCQyVJGNfCWMV4pzk3/OLzpIvQ7tN5fJw/iYTcLvzFzcGBU+?=
 =?us-ascii?Q?zexTs8SQYnKN92OURML1LWv1ZCoh/PzPN72DrTVK1+uDFtpT/qNMhHpeGSZQ?=
 =?us-ascii?Q?2TvuQ3mmIzxUHVVwYA6rkALKjflOvf8M9/KT4UronHhal7MS3eLHsIgoAQJM?=
 =?us-ascii?Q?7i33k4Vb2uAZWrubt/1cAqi/3w8mb9C5PNC3gLqzaZrjrQNs4ll6t5w7yqry?=
 =?us-ascii?Q?8nkjJevm3zD+9FDVInjbJHdMqc9Q6eDSTJ0q5X9RRMOWJ0ugHakzGDDnxTAt?=
 =?us-ascii?Q?PdGnVyHoMrfoh8693f1MCE6rt9EBc1RrfUPn7vkGPqWsdVsq+Z0wbOzDevVL?=
 =?us-ascii?Q?OhHuapl9wI3iZtU4G6wEmLdqyiEFrewO5tRYWqpL1JV5znP6SMJFIKmwq+d7?=
 =?us-ascii?Q?RmRJ/83GTBUU24fDstykNXSnBjy2pQ2PW+3+Lm8PeRW2sAAmhkhiCQm+hB5E?=
 =?us-ascii?Q?jkEcy7cCDREtui/oaGbaJKMfyPZDlB/wbBxCJg1OGdwnkjEkki88VjHotwcZ?=
 =?us-ascii?Q?ASn2NOioP/IQraG2TAqktJG7JOjiiHvM3vtLurv21qro4QqXnDYIru1jdLuL?=
 =?us-ascii?Q?8mrz3lSgR2LYLni1VezUYtJTZpQuphbf/sP1Vk25JFjrd6WE8bcvlfwuIbhs?=
 =?us-ascii?Q?qHp1mp1D5q1RwU9rQ/5oXS9UCWDI88sE/A+fmr70pOic4Q5QqpoKBDr8Ajpl?=
 =?us-ascii?Q?QAMiv1ryprc4SwXnyzytqzodeSgrTwtgrNNq7P77VCK0ouSS9RQYOkVhsCdw?=
 =?us-ascii?Q?uE2Dlb6F/ViklDSY9QFNhm2ELmzL6WsO++4PKNw6PIwDyTZKEB+4337VVNfx?=
 =?us-ascii?Q?Z/nttgtxyK1T+mt4fuhAqTgMzdd3eUzZEF/1tV+zmQTL/krTaeuRRDvlwGdy?=
 =?us-ascii?Q?KSZC7V4w3KnF5/dPZfNN4dK+ut4x4M/uI3S96xNf0jvgvxmT3jyE/A262d/3?=
 =?us-ascii?Q?/MvDB6WedyWw9CJCCrWc5Js+sam3mZvvoNsoRgrY3p9oPYRf/acDG3U1lshW?=
 =?us-ascii?Q?gXUofZ0Cd9XXeSDI9dkdvDPdYM/NA1Mz0dKQQ2N0qdpXkQcti9q6SzsS1Crv?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18faab63-9cbd-4aca-564d-08dbc3e0da42
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 07:17:50.6904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8geCx7C0kceCJdTcXk0syyhE3F5eZfy2ioC+w2dKCKEc3X67ExiQ0BPqgA0r+FQ/GFcNPs6qeBckQWBwSNATaJaUTQRy7aPO4BuppFFi8w8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR01MB5906
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 00:18:05 -0700 (PDT)

On Mon, Oct 02, 2023 at 08:51:03AM +0200, Jiri Slaby wrote:
> On 02. 10. 23, 3:56, Crescent CY Hsieh wrote:
> > @@ -1958,6 +1958,9 @@ pci_moxa_setup(struct serial_private *priv,
> >   #define PCIE_DEVICE_ID_WCH_CH384_8S	0x3853
> >   #define PCIE_DEVICE_ID_WCH_CH382_2S	0x3253
> > +/* MOXA */
> > +#define PCI_VENDOR_ID_MOXA	0x1393
> 
> Isn't this a redefinition of the pci-ids.h one?

At first, I attempt to place DEVICE_ID macros into pci_ids.h to enable
their usage throughout 8250_pci.c and to establish centralized
management. However, I notice the comment in pci_ids.h which is:

'Do not add new entries to this file unless the definitions are shared
between multiple drivers'

So I add this VENDOR_ID just for the clarity, even though it results in
duplication.

Should I put these macros into pci_ids.h? If so, I am willing to help
relocate all other macros.

---
Sincerely,
Crescent CY Hsieh