Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1796383rdb; Tue, 3 Oct 2023 00:45:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4tID4isj1Yfz2c0BrFP96+SiQ100LoDbf5k8khU4fGKQZwv+Avyu5YP9qWTABb0Pvw/n0 X-Received: by 2002:a05:6808:f07:b0:3ae:132a:e7ae with SMTP id m7-20020a0568080f0700b003ae132ae7aemr16925808oiw.27.1696319140436; Tue, 03 Oct 2023 00:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696319140; cv=none; d=google.com; s=arc-20160816; b=sTH/uAta1p4btJvkEKhRZ7nk34vX1BAVq5Q42jNzXY+zn018C74KCbJlRJnP2e98KB HQYAoh3tj54HI0EWNl06VdqK2EyJVYv1qHNmjcECkalqlBbEPXfhO3q4f1moY9iY4rR7 kNwqXae8XlszvE4k3KEx4BQx+jw481S1hUd7TmVfKqBXwv0dh8Od//T4fHzCpyAZs4qi 1dMGEHFlARBNnBgBlr7fnqQyBEUZ2nNdDuJ3XHuPqm1BtkxfOsSFaEqoRKkVgEadbxMw Jt/Ru50xMX3IfSq+HAa+gmohJJFnrbOmGUG07l1VtNciv32+n4lWvTPxqQK3wb2SaijH bZmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=dxSBLRS2D24LuH1uwdEmbmZKZlhSPy1I4xS0UUCvOXE=; fh=4H4XkqLhMyXk9bMiWcNJeMOFM7UH753yhkFXoY6BKuI=; b=wVAXUQ5yheuQRSusF5Q8nsM6GAa5dql9OxNOQvO9xKzn/jnNfAc4Y3LUIexsQ/HNiA 19ltg65Cc05kWbDv6maX2wtXldAIgJhmXmKicu/aRhFg/ZmpCQod0SIzc9a3Sg7BGRhl sJhbdepbkGlcHj9tMBSjnd/Y3dWcRVzlQecI40wL2c1zeFI1zPdIFVEI2L4etPOsST8q z2+nghH4i6AfyQAsoSh2XW0Vgkxa8MUDxSuXGRwqGMYtpWz+Q6n3Uob5Lp5sQ1ZBLUaO vdaMgkiE69716AxGJHiWNdHrNPhBTsA+z3MXdAI04jpk84+QpHhyI55CmIvrIKMJL/ow i/sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=TzkZHU4H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id q143-20020a632a95000000b005780a1eff9dsi883640pgq.54.2023.10.03.00.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 00:45:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=TzkZHU4H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1DA92807EACA; Tue, 3 Oct 2023 00:45:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjJCHpa (ORCPT + 99 others); Tue, 3 Oct 2023 03:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbjJCHp3 (ORCPT ); Tue, 3 Oct 2023 03:45:29 -0400 Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16ED90; Tue, 3 Oct 2023 00:45:23 -0700 (PDT) Received: by mail-vs1-xe2a.google.com with SMTP id ada2fe7eead31-45281e0b1cbso330320137.0; Tue, 03 Oct 2023 00:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696319123; x=1696923923; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dxSBLRS2D24LuH1uwdEmbmZKZlhSPy1I4xS0UUCvOXE=; b=TzkZHU4HSt+KPo2vIEPTbhjlK1fHiIkKHXNQpJ7BqmcKknwXwvSn5zdeSAmzvjonGL zf1+KP0rPixMlyyCDmnb2S1FzGyTLS7o1URReE/n65LThOXCRSfIKL7cSXRncB7v83lL bPsjKMKvs6DzjSpHqXjWXqVqhrTJOhXb/0Zk+AKiG43j7dHhTsWp48fPmvLrKs3gUbOs gu02wowaUbGJG7xUJmpaVaPE9EydxHX+UDvG+4B5nkODoSFT/dBEM7v4XMaLCzRQ2Z4z TC1NxxGFQPBOhKBY+2w5++CtejRK/iN9QgWVxiIOinEH0vGcOdpfHuJAtx1AJJ/WKYpy zvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696319123; x=1696923923; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dxSBLRS2D24LuH1uwdEmbmZKZlhSPy1I4xS0UUCvOXE=; b=ZHuvr1SjsAq9hgldeZZxSEuDObV5mAMaClFEvNKxfw+vR4lvS/vJNi/GbHGMJDxGF9 IwkHXGhz3d2IUH2IE/wsgtNqkjS255IyqavD/rQGvuyNlP+rTfcl0qZbyfwtVmth16Ox fAaUxjkAiSpFd2nPl7aEMt1vVI3O0mOvn0T8LTbvVBTq9WXBNmTU4Lz47PsHMBUGVoDc IM5a8r+z119xOGBnRrUJmLEK/MX6S29XXLXMLJ7F+QeoVG+Y8ysl2QCPivVeebLOTcYw ZMzu3/ygVcOnx4d+5U+ZybaZ4M1cZXz+bxTuFipawYOmobF7v34DF7ZOhmRFwe5n15oE omVw== X-Gm-Message-State: AOJu0YzC318svPscCcbhRCVZJyHRpYzZSv7RO3HsOTEyDjAJYRaTreU2 Yl23RpVRyL0FEre9ObYhkmLNlMTBmnaqNn59P0A= X-Received: by 2002:a67:ebd3:0:b0:452:6465:4a35 with SMTP id y19-20020a67ebd3000000b0045264654a35mr12361496vso.11.1696319122624; Tue, 03 Oct 2023 00:45:22 -0700 (PDT) MIME-Version: 1.0 References: <00000000000056dad80606c447e0@google.com> <000000000000fb84850606c8b688@google.com> In-Reply-To: <000000000000fb84850606c8b688@google.com> From: Amir Goldstein Date: Tue, 3 Oct 2023 10:45:11 +0300 Message-ID: Subject: Re: [syzbot] [overlayfs?] general protection fault in ovl_encode_real_fh To: syzbot Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 00:45:38 -0700 (PDT) On Tue, Oct 3, 2023 at 7:56=E2=80=AFAM syzbot wrote: > > syzbot has bisected this issue to: > > commit 16aac5ad1fa94894b798dd522c5c3a6a0628d7f0 > Author: Amir Goldstein > Date: Sun Apr 23 16:02:04 2023 +0000 > > ovl: support encoding non-decodable file handles > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=3D1197206268= 0000 > start commit: 8a749fd1a872 Linux 6.6-rc4 > git tree: upstream > final oops: https://syzkaller.appspot.com/x/report.txt?x=3D1397206268= 0000 > console output: https://syzkaller.appspot.com/x/log.txt?x=3D1597206268000= 0 > kernel config: https://syzkaller.appspot.com/x/.config?x=3D57da1ac039c4c= 78a > dashboard link: https://syzkaller.appspot.com/bug?extid=3D2208f82282740c1= c8915 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D14877eb2680= 000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D13b701f668000= 0 > > Reported-by: syzbot+2208f82282740c1c8915@syzkaller.appspotmail.com > Fixes: 16aac5ad1fa9 ("ovl: support encoding non-decodable file handles") > > For information about bisection process see: https://goo.gl/tpsmEJ#bisect= ion That was a stupid braino. Reproducer is simple I added test coverage to LTP: https://github.com/amir73il/ltp/commits/ovl_encode_fid and pushed a fix to #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/overlayfs/vfs.git ovl-fixes