Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 3 Oct 2023 13:32:26 +0530
From:   Jai Luthra <j-luthra@ti.com>
To:     Aradhya Bhatia <a-bhatia1@ti.com>
CC:     Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devarsht@ti.com>
Subject: Re: [PATCH v2 3/6] arm64: dts: ti: k3-am62a7-sk: Drop i2c-1 to 100Khz
Message-ID: <tstb2fxrio26yhu4cbeblq6rpo7hsqfa3ydrz54lmk2gbbegnl@qsvfevchllkd>
References: <20230928-mcasp_am62a-v2-0-ce9f0e1ba22b@ti.com>
 <20230928-mcasp_am62a-v2-3-ce9f0e1ba22b@ti.com>
 <1ad3087c-c9aa-9a67-46c7-4969c97041d8@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uvdysceesknkyl3p"
Content-Disposition: inline
In-Reply-To: <1ad3087c-c9aa-9a67-46c7-4969c97041d8@ti.com>
Precedence: bulk

--uvdysceesknkyl3p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Aradhya,

On Oct 03, 2023 at 10:54:12 +0530, Aradhya Bhatia wrote:
>=20
>=20
> On 28-Sep-23 14:54, Jai Luthra wrote:
> > The TLV320AIC3106 audio codec is interfaced on the i2c-1 bus. With the
> > default rate of 400Khz the i2c register writes fail to sync:
> >=20
> > [   36.026387] tlv320aic3x 1-001b: Unable to sync registers 0x16-0x16. =
-110
> > [   38.101130] omap_i2c 20010000.i2c: controller timed out
> >=20
> > Dropping the rate to 100Khz fixes the issue.
> >=20
> > Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
> > Signed-off-by: Jai Luthra <j-luthra@ti.com>
>=20
> Since the codec wouldn't have worked with the 400KHz, the initial DT
> configuration is wrong, which makes this patch a fix, and should be
> indicated as such.

I am slightly confused, as the codec node was not enumerated before this=20
series, and i2c-1 configuration @ 400Khz works for the GPIO expanders=20
present.

My understanding is that a Fixes: tag would mean we backport this patch=20
to older releases, but that would not really be necessary here as=20
nothing was per se "broken" before this series.

Will discuss this offline with you and Vignesh and send a v3.

>=20
> With the Fixes tag added,
>=20
> Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
>=20
> Regards
> Aradhya
>=20
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/=
dts/ti/k3-am62a7-sk.dts
> > index c689d3da2def..866b2725f775 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> > @@ -261,7 +261,7 @@ &main_i2c1 {
> >  	status =3D "okay";
> >  	pinctrl-names =3D "default";
> >  	pinctrl-0 =3D <&main_i2c1_pins_default>;
> > -	clock-frequency =3D <400000>;
> > +	clock-frequency =3D <100000>;
> > =20
> >  	exp1: gpio@22 {
> >  		compatible =3D "ti,tca6424";
> >=20
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--uvdysceesknkyl3p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmUbyo8ACgkQQ96R+SSa
cUUMmA/+N/E2rMFbxy2zfGYWL2ach8I1kkxOnoZBgLbw9TeSp9uyVrLA4JvM4ZYM
FSpxYw82Hze4O4X7xa7dV0b42y9HZF8brW7SwRSrdgAIPQFRpqjna+/gcxLz3UL6
mHiGLD44kpJYbFcV0nyQLgvy7x3x6g843LurprkRrgUgA/jOfiYKIsIB8HRH3oNY
tzpAVwlwn9qKDc5D2TcdTbstZgJdOcH2XtHoAEi91qxbpciUTObmPqYCyEHw2DBD
QV78vzIS/hdimwxFh7PXiCINRVKWpRvIV5ccCaeJ9rjiq/9A+JPhXFHFkYqB6SHk
Bt6z+W4bkuRJlhNXquEX1mPtWSbvHYd1MTBJrASoxZ36FRJn1xo7XXnp7PMyCWHG
mhNJByZ3CMiatYWL0aQWJgNneDL3haXZFYrJHoM1cheBob7dosnctC+u4vhSLY9N
kJcubku6F6KmVFP9U5EABh5LKsN/eIgb28K0HHi9Dq6WYdASfE0lQ6wJX2a9c9yF
iUH1M52+eArXdBiqbuqUzzq3S4lWe1qHufQc54Dd02STxyQbwojGy7pQ012PqpJ6
QdrU4ONAyHF1XpM1Z8rlTyyJ2nkpJN+XMKkiJeNCb+VYXvP/mFVuISxrOUb1Yx+1
wre0nsxlWIZmfRJJfQeOG4/fV98rZ1ZQ7Tl6YG+S0lpvrE+VT3w=
=MzXC
-----END PGP SIGNATURE-----

--uvdysceesknkyl3p--