Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1804833rdb; Tue, 3 Oct 2023 01:06:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHITLKUx9y4SHgnbsZLmU/lwBOwJ2MuwE4pmBMlpmDqNK8vt8EL7qAKif0sWW/ZeVMixBXs X-Received: by 2002:a67:e3d1:0:b0:451:40b:2210 with SMTP id k17-20020a67e3d1000000b00451040b2210mr10420898vsm.3.1696320385847; Tue, 03 Oct 2023 01:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696320385; cv=none; d=google.com; s=arc-20160816; b=VwDYYjYy8m9QNozCyS/iTal4XZ93qN3aOVwSg31rFZAzn+nyBnsZaIBkf/3V1IKIAh BTjvD9mCPTZlo/mSzOxugvgLEWy896rZteSifNbR/yMIj7oNn5r2p0APHdeIbsdTAWnc EXGmUN+wfjR6EbXSqtpC1du6dEjesKLdgUceP/DTebG8fDmKayDeJXQ7hcyIamnnDnAr vfVGZ1e+ASIG/wXTpUC/qq4MJH7YJ8jUYeKyALmm7N2hFRkz9iqVmQHMR0NO5SAg95rU tr2EghiYNOdL7lWNxOraH2NAgCtWgqULOhcFIQe7DXRlE0R6aejtAuTmsXWi0w5TYOAs Xe5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=VOAybgL+ovxt4p2lzUG+RNqS26gXoid3T6lNokCk+GI=; fh=YmW56Jjlaak1EaOYEIddWG8QfZwpR67Ad7p8iQIhC54=; b=SWP7TptOXvamf7gQ2uW38+2eik8eVWZcPxjW+vfB9H4nNpYMId98fQKvzH8m8fiW5V UY9e2osEo99MDXRuxov4/01KqUC0LsN2cV5LVQm29wCImbcTQqE/SqlUSyZ0vzpK9ARe 4Gjqaa6ycQeKGSyJdQAlki8SPs6HLPZU7LAsxng9fo8h4j+HeeH/aVEDH2fpOKyWlIAZ wt7F0kxMCN4VguQ26PD8bJ6fA8y0EmWdJUpNhoaxUpkgsunOVVuaStSyaeJ2ZOUoeif0 nRyaIVXmdXFlK1OeHj84Ot6TSQCw0IKB3E8Vz85vHgDW/0LdQB970q5+E7iqwRJ1IiSm CD5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id i127-20020a639d85000000b00580e32f7793si905440pgd.151.2023.10.03.01.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 01:06:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2FE2C80ECAFC; Tue, 3 Oct 2023 01:06:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239265AbjJCIGJ (ORCPT + 99 others); Tue, 3 Oct 2023 04:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231159AbjJCIGF (ORCPT ); Tue, 3 Oct 2023 04:06:05 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CE524A3; Tue, 3 Oct 2023 01:06:01 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF203C15; Tue, 3 Oct 2023 01:06:39 -0700 (PDT) Received: from [10.57.93.198] (unknown [10.57.93.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CC043F5A1; Tue, 3 Oct 2023 01:05:59 -0700 (PDT) Message-ID: <4cf233b1-57e0-f1f0-4def-1cbb7bf46e9f@arm.com> Date: Tue, 3 Oct 2023 09:06:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 00/18] Introduce runtime modifiable Energy Model Content-Language: en-US To: Qais Yousef Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org, dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, wvw@google.com References: <20230925081139.1305766-1-lukasz.luba@arm.com> <20230928215628.u53wmwlr6lm5qzpe@airbuntu> From: Lukasz Luba In-Reply-To: <20230928215628.u53wmwlr6lm5qzpe@airbuntu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 01:06:23 -0700 (PDT) Hi Qais, On 9/28/23 22:56, Qais Yousef wrote: > Hi Lukasz > > On 09/25/23 09:11, Lukasz Luba wrote: >> Hi all, >> >> This patch set adds a new feature which allows to modify Energy Model (EM) >> power values at runtime. It will allow to better reflect power model of >> a recent SoCs and silicon. Different characteristics of the power usage >> can be leveraged and thus better decisions made during task placement in EAS. >> >> It's part of feature set know as Dynamic Energy Model. It has been presented >> and discussed recently at OSPM2023 [3]. This patch set implements the 1st >> improvement for the EM. > > Thanks for the series! I'm on CC this time :-) Unfortunately I have a planned > holiday starting tomorrow, so won't get a chance to do proper review till I'm > back which would be few weeks from now. > > I just want to iterate that this is a real problem being seen in practice where > it's hard to provide a single average EM for all workloads now. So we certainly > need something like this. > > Hopefully I'll get a chance to help with review when I'm back from holidays. > > Thanks and no worries, there will be v5. I am going to address comments from Rafael. So probably when you're back the v5 would be there then. Regards, Lukasz