Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 3 Oct 2023 16:17:57 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/4] tty: serial: 8250: Add support for MOXA Mini PCIe
 boards
Message-ID: <ZRvONVIbgytC+ysT@moxa-ThinkCentre-M90t>
References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com>
 <20231002015702.30509-3-crescentcy.hsieh@moxa.com>
 <1e99f3c4-e0b8-4951-80c3-f3c5a1eb5277@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1e99f3c4-e0b8-4951-80c3-f3c5a1eb5277@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O4U1EmZf0cKXuz/LF0mgb0V2lQMP6axWVyRWWVh9hILq9ud6Q9rLdFTJXEU0?=
 =?us-ascii?Q?RBsM/dgrTUz+rboqdKlcEJxSqeF9eNPM9iQ0UPubLQ+DLPU1zRzCM19gsbLM?=
 =?us-ascii?Q?GarvZH2fHfRKTWBi5jJyuUTu/aiKeqKRYBfJhKgr56leDDpuqqP2unmma/zM?=
 =?us-ascii?Q?tmcvVRN8U1Wix+tKySYhUocP2d0ITRDGrIHnFWSgPOkmzU/Y/jm/DJY7Vm24?=
 =?us-ascii?Q?wI53jK/6JRZOsj9h/1aYAk7D6X+Kua9Fw7S9tXxlbq9dbWxvZ0TSdvgHadvM?=
 =?us-ascii?Q?83hQhgosiZ8RSyVcNxOq4Kz/WrYR4jDHvFNNcTXgWpBSXXgyjSS2OPDIzYM1?=
 =?us-ascii?Q?13FmooRAZr+yF1boI13f8NYwB2mEROZiUwc/f6J16g5ETK+pmoWO/4+Hq33E?=
 =?us-ascii?Q?U/tEuMhmKeSddobdL+7nJnGThtggrLDW7dlIRm1POO9Z51cRsQSzD0Djxh9D?=
 =?us-ascii?Q?J5BqJ8njq2leSHBazKeDmOryYIryk4tyLWeM6jW+p0X8jTmFrbD7lsODDYHZ?=
 =?us-ascii?Q?qys7MrDO0dBGIASJVNW814iuwZvO/VTTOvSJgK55TYdInKx28aQ7jg0YBZMD?=
 =?us-ascii?Q?xERp/pVuK+RDVpoo5pNpXSSQ/8J4mhwIumlv+I4qBJ79c4xVahF6E95XjL4O?=
 =?us-ascii?Q?zy6BOEGrEY5cBzHUxVClMNr4MvsJUeu87mzHz9NJJSa+ioHXz+H2g05dDWXx?=
 =?us-ascii?Q?+Itzf4MH6XqRwPFqXCazbXWH7h2tlXSP0//EO0+FIB3gxNOiUF8SE1vDzwMu?=
 =?us-ascii?Q?c4f/kjZef5o5p2J9dgNSIe2N7tuiSD83XEUBJ6G4miL0clrtKuRGPRjmNzj4?=
 =?us-ascii?Q?Kg+dASPq3plGcKDuCic0/yeyMNUd3o7hl+XZcWNCBmKgGro7HGRVwDtY/vU8?=
 =?us-ascii?Q?kbEJJBqRV84/rkhn+whH772D8QyEZehapQleksBr1WDvaeCmdRtNjjk7RkcJ?=
 =?us-ascii?Q?PeyL2emEmJwnDGp+NhYNJGj0HWVf8eTycgid/Pu6YY9wT+oZFepGX9ayLmqS?=
 =?us-ascii?Q?4FOOYJkTI5YCE0fwA7QdRGizN9xCiW27IOa8H9gypjqJVvsAif1cfiy7LUAu?=
 =?us-ascii?Q?Oqa7jPJa6Ly6tfFN5oBqFIKS3xOoi2+kuiWv5nMr6SqqiaAUuYN/t7V0TCxB?=
 =?us-ascii?Q?jp+o6RT4CTM8/Sp1GZntoBG9jnx9tiDJawIy1Ocy/Rmy+KxREsJ1FTh9rzkK?=
 =?us-ascii?Q?ib3xWBTvrGpp6ZG+9qa/9WNfq1XVaeegA/Xtn4kQLdzxC2zTD6jjXh/pxk8j?=
 =?us-ascii?Q?kew5VQ8RImW4qCWg05cOGu+T5KMvWlO1ANnqs28Eue5TlYmwGIhwa9tqx+d5?=
 =?us-ascii?Q?uyTgeOgSkh5Tbo9DIjsC62ChQt5Hcd+87mVk6AMUWEqy55zBtM6Ml+GU0/w2?=
 =?us-ascii?Q?+NVR0VOvOVi5fUabWxRk+NJ+d7/Fz3vuNbB4oQkmxzdR+NuhM3TvkKFBtx/w?=
 =?us-ascii?Q?XTTERPWhgb94AarimtAG/2bdLJoQrnPpaTechiDkHZJ+/I6OmU5/nzSVDh7J?=
 =?us-ascii?Q?Vx3gLu0Ljrrz8A4Uw4FvwQzOoVC85oRsW4CmQevjZmydFBHBOnekKUgIbw3Q?=
 =?us-ascii?Q?cKZVsCveYzsTyPuscGrBa3EJz1y1eOCifPoEaeb3TygNz+7aam9Guhtks8JP?=
 =?us-ascii?Q?Ng=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc77956-4dd2-473b-b43c-08dbc3e942a9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 08:18:01.7931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pSxbROgQ6XOR8hnkGL4d0y22mFuYdkT/twsaKvgoiPiEs4afp4j8leL24ZwcgtBlGHqCHYrmoF+kIjb4mpBGey7tsdK0rJfs3ZlBBFn/+JM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4276
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 01:18:28 -0700 (PDT)

On Mon, Oct 02, 2023 at 09:05:31AM +0200, Jiri Slaby wrote:
> On 02. 10. 23, 3:57, Crescent CY Hsieh wrote:
> > +	 * This hardware buffer is only supported on Mini PCIe series.
> > +	 */
> > +	if (device == 0x1027 ||	/* MOXA_CP102N */
> > +	    device == 0x1046 ||	/* MOXA_CP104N */
> > +	    device == 0x1121 ||	/* MOXA_CP112N */
> > +	    device == 0x1145 ||	/* MOXA_CP114N */
> > +	    device == 0x1323 ||	/* MOXA_CP132N */
> > +	    device == 0x1343) {	/* MOXA_CP134N */
> 
> Why not use the definitions below? You should define a function for this
> anyway.

I cannot use macros here, unless I put the definitions before this
function or into pci_ids.h.

> > @@ -1973,6 +2009,13 @@ static int pci_moxa_setup(struct serial_private *priv,
> >   #define	PCI_DEVICE_ID_MOXA_CP134EL_A	0x1342
> >   #define	PCI_DEVICE_ID_MOXA_CP138E_A	0x1381
> >   #define	PCI_DEVICE_ID_MOXA_CP168EL_A	0x1683
> > +/* MOXA Mini PCIe */
> > +#define PCI_DEVICE_ID_MOXA_CP102N	0x1027
> > +#define PCI_DEVICE_ID_MOXA_CP104N	0x1046
> > +#define PCI_DEVICE_ID_MOXA_CP112N	0x1121
> > +#define PCI_DEVICE_ID_MOXA_CP114N	0x1145
> > +#define PCI_DEVICE_ID_MOXA_CP132N	0x1323
> > +#define PCI_DEVICE_ID_MOXA_CP134N	0x1343
> 
> I am not sure it matters they are mini PCIe. I would sort them into the
> above preexisting list instead.

For these lines, classify the type of boards is just for clarity, but
sort them into preexisting list is also feasible.

---
Sincerely,
Crescent CY Hsieh