Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Secumail-id: <15006.651bccbf.bde9d.0>
Message-ID: <9e737b85-95bb-66cd-301c-3a2d1d41f4c8@kalrayinc.com>
Date:   Tue, 3 Oct 2023 10:11:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v1] i2c: designware: Disable TX_EMPTY irq while waiting
 for block length byte
Content-Language: en-us
To:     Tam Nguyen <tamnguyenchi@os.amperecomputing.com>,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Cc:     patches@amperecomputing.com, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        jsd@semihalf.com, chuong@os.amperecomputing.com,
        darren@os.amperecomputing.com, stable@vger.kernel.org
References: <20230929035356.6435-1-tamnguyenchi@os.amperecomputing.com>
From:   Yann Sionneau <ysionneau@kalrayinc.com>
In-Reply-To: <20230929035356.6435-1-tamnguyenchi@os.amperecomputing.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: ZgVmLvbJbq+TC3zopfsOrQoQaGXn5xJvi28IWHD0/pcH9Ych0IhTsnpHvVfcP539ebYVIolK0PGGiBJdRjl/BDwgM1F16F6GuUmTM3hbWoJHFnA1DclwKYOLqJvdSo31AJM0wMrca43Odk7vuZEALF/YtHSa5dvSIB7hBFnR/jtAA/5+czNlUjOZcofDEFKLzOSDpW6JxIdmMKtd47bSclNs2mNfVShOHwzj/QYoewV2YIFtgPlfITT97x2TXCl7/h44YcoJxMMh7msa+r/FdnAXui4El3u8T/yYoqqMR0V+PGIf5y7tGPRCyRBXC8mL8XgfoxOA+DSUCX0q6cP0raYJ4EnVgKU1bPJ7SX+bbPNZuOox3VBD3sR4sVuslEiyuqP0Do4OKAGUsPL5pBmSQ7k2lRbKWTPH5mFo7eBDBYiOMzxMp/Secm/x5dAnnzgwk6VqHVcSX9SVSFCvPM4QFSj8piKJVsUAX4y930UofPELHf8t0+oEWCg+vJl4Gsnzsx010cLRgnkFuuekIJN4sSeAE8gDOWgco03ivUiOuZA6fB9ILDzLhwwgCINbfRz0ghRc9Zsp+87clXtDGPIKKhuCtwHRnQT+FOBTAB62Ue5ANVNeYFIfGrQs8Nh/BsfPeoph9u1s94+QQ7coBUBtWIB6DzXIE/L4JjKWc7vQSH1UGf9kDBAQoFgvZhGBhpDmUZzj6AKMRA99p6wDu3PMcPao4cp+jVEdHs2bpnpNzuqgmbcM2Xp4opxKQ0n/oKFNkWOBxWnmuxkpHtTtIv/z4nkf62ffEmCh50x48s1BIQWlPDOL06nY8yfQXWJ3/7/OiqhBVTdlM+wVP1SgN1DSk546acGedPkJTmjbD4ZLZMeVbOb5hYdVdrYtHmCIJGkTYSRd7t0tlN/w5K5Q8zS2u2m2z1PPGVlHLj2G+VjlnsJhJEYxgdGR82nxGIXxlW2g
 Zl7q8LjHUE7ukYZ0vIPZ2mP+tXjp7Oo1O7uAsQ0QM6joCGzJmHpnVsxXB1qO1c3X1hCx4GSM2RvuvvMPS4wZtigOwh13uLEiWWQdIoskpTo7eOeDNXyoohIxMgs4xsMyEGFJL73F4//jefsvdgKqdWES9wFyEaIqlKWFK5yxa3WyGyVZKENcuJVH1k5Zg2wHCcBw6zDemu4bFcx2ZQ18VPm2Ph6GzCx6SnqekR0gKZflUkRkmlGsN0CIhBQ+RRywAZ1AkyXSvYuOX9fdSAsso9cvW9gHYAMbQArzjE0SPbaISXXIGRrYEElR4LvcQGoh732430ZnGuQvlx9JEM9xq8mqobzcSM+oZZ4AqJWG0exFrdbn4tH5mVK/CyJ8VlgQrUDNS6CFF+O9Rt3aOFeXoHdpx09BcH8iDdRUsMrQj9w60ne/5yI4pwxFA3zRtOVNIqyeHT9H+JwEzsgno72wquWVXxV3BBOiKukupQr6Exyr+b/4IKXfO9igt2h4P3JyhMffbcz4HmnC4/fUq6hte5Isuh55tb4TkqDAZAlfdBG++a+0pL5Z+HzbNkZvCgKml6Y7edYzqZYgCcj653j5mrpor8EK0AvOEZoA4AntTsaKgCFE+APRDaKHR3i6UsfT2T2v2PMH5fsFZ4SFyAVh7A==
X-OriginatorOrg: kalrayinc.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc887e50-7a23-4885-5514-08dbc3e85e51
X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB1890.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 08:11:39.8995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8931925d-7620-4a64-b7fe-20afd86363d3
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBiDeMd9NuuePeZ5LZD2xzWL9PHYCFFxuL1p2VhDLumEAli9BP4X/qG66r9pkCVqt84vcVNtn2EJgJSDg0DNoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRZP264MB1944
X-ALTERMIMEV2_out: done
X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 01:18:42 -0700 (PDT)

Hi Tam,

On 9/29/23 05:53, Tam Nguyen wrote:
> During SMBus block data read process, we have seen high interrupt rate
> because of TX_EMPTY irq status while waiting for block length byte (the
> first data byte after the address phase). The interrupt handler does not
> do anything because the internal state is kept as STATUS_WRITE_IN_PROGRESS.
> Hence, we should disable TX_EMPTY irq until I2C DW receives first data
> byte from I2C device, then re-enable it.
>
> It takes 0.789 ms for host to receive data length from slave.
> Without the patch, i2c_dw_isr is called 99 times by TX_EMPTY interrupt.
> And it is none after applying the patch.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Chuong Tran <chuong@os.amperecomputing.com>
> Signed-off-by: Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
> ---
>   drivers/i2c/busses/i2c-designware-master.c | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 55ea91a63382..2152b1f9b27c 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -462,6 +462,13 @@ i2c_dw_xfer_msg(struct dw_i2c_dev *dev)
>   		if (buf_len > 0 || flags & I2C_M_RECV_LEN) {
>   			/* more bytes to be written */
>   			dev->status |= STATUS_WRITE_IN_PROGRESS;
> +			/*
> +			 * In I2C_FUNC_SMBUS_BLOCK_DATA case, there is no data
> +			 * to send before receiving data length from slave.
> +			 * Disable TX_EMPTY while waiting for data length byte
> +			 */
> +			if (flags & I2C_M_RECV_LEN)
> +				intr_mask &= ~DW_IC_INTR_TX_EMPTY;
>   			break;
>   		} else
>   			dev->status &= ~STATUS_WRITE_IN_PROGRESS;
> @@ -485,6 +492,7 @@ i2c_dw_recv_len(struct dw_i2c_dev *dev, u8 len)
>   {
>   	struct i2c_msg *msgs = dev->msgs;
>   	u32 flags = msgs[dev->msg_read_idx].flags;
> +	u32 intr_mask;
>   
>   	/*
>   	 * Adjust the buffer length and mask the flag
> @@ -495,6 +503,11 @@ i2c_dw_recv_len(struct dw_i2c_dev *dev, u8 len)
>   	msgs[dev->msg_read_idx].len = len;
>   	msgs[dev->msg_read_idx].flags &= ~I2C_M_RECV_LEN;
>   
> +	/* Re-enable TX_EMPTY interrupt. */
> +	regmap_read(dev->map, DW_IC_INTR_MASK, &intr_mask);
> +	intr_mask |= DW_IC_INTR_TX_EMPTY;
> +	regmap_write(dev->map, DW_IC_INTR_MASK, intr_mask);
> +
>   	return len;
>   }

I tested this patch on Kalray k200 and k200lp boards (Coolidge SoC, kvx 
arch). With this patch all our CI pipelines are green.

Tested-by: Yann Sionneau <ysionneau@kalrayinc.com>

-- 

Yann