Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Tue, 3 Oct 2023 16:22:37 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/4] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards
 not work by default
Message-ID: <ZRvPTa5L35ui9/q1@moxa-ThinkCentre-M90t>
References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com>
 <20231002015702.30509-4-crescentcy.hsieh@moxa.com>
 <73a6b0ae-d94e-4a9e-9964-0484c95c8226@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <73a6b0ae-d94e-4a9e-9964-0484c95c8226@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KhFMKpDaO3iGMdDbRs6KVWflWHZDZkcuKSQu2Wfnqf8hsG1Ca/7vNZ4khqy7?=
 =?us-ascii?Q?FFRwpiIg9o4M9I/dimtlT9nOJWL76Po0ITHZjSOCXsah+tSTUJ9ZmqGG4wVV?=
 =?us-ascii?Q?rFcmOWypWCQdFUM5BpPZTSDUXxlF2PFC3fBXHfwmQfWRwx9diwzp+geEkQdg?=
 =?us-ascii?Q?JAnwrznkVHK8kDfu1fXtrLLTmXyXNg7RPF8FFJdIvxz102VtJ9RoRBBLVLCm?=
 =?us-ascii?Q?Hl5sSVwXik8lD4s96wWtEnIc8ceEQvhLqEdKAfgM7H9mAxzYRfe8npochjsI?=
 =?us-ascii?Q?A1+DWtiVrSoch1/4fMEXfNP8yP1repdyn+gvpxUcHHNBD2Li3Db4v+hqxVd+?=
 =?us-ascii?Q?CTKpOxDdnBwOSkP07ofx4Ur0KUi5R81wt62zSxfUMaNPiVErBaZhRkZ+oCvl?=
 =?us-ascii?Q?RarBUMDiOa0u1zqyt2HmVwrZfM/i2+35WCRiKLtrfD5uuE601aPGVb/32J/y?=
 =?us-ascii?Q?qYciAhcFHaT8nK5E7xiSbeGb6m9r/XLhmlovKl8TvsG9i6nYUics5OQW5pcB?=
 =?us-ascii?Q?AIOzQAMcefcnSDG6ADY7e65zSE7VncPhTpRxZiwcdvVOEa1vt9InNds/wrpY?=
 =?us-ascii?Q?UPRFNr21GEE9ATk9nmBPqXU2O22EtFvmAJywBahkJJEsB27QMN+HYGYFBTkT?=
 =?us-ascii?Q?wYW5X2S3a/krSUx5AcYYqD7evCaKv9Enu5KgXKR7kwwkx+K/vReUGlt8e6dC?=
 =?us-ascii?Q?WtaaxnihKrfK/srheC77HMn8hKl8Q53zaQzxOjgmm51WcyMkFv6fMy88IAqf?=
 =?us-ascii?Q?zHeLgF4vJu5imT83NEKOqNMAZyj0pJ1PD9fqwRtVE1d5dFNzFr2hHohX5JCW?=
 =?us-ascii?Q?/aca+h5CP0JCI2XECpTOHLeEOxvv+n9vp/2rWxVurxqfkgQ4qtIu1s1HT3T/?=
 =?us-ascii?Q?qSN65NxtezrJzKERHRm7Rc5FSq+MlY39r5Le6A/x5OdhEHgEWzjaQomj352Y?=
 =?us-ascii?Q?WWAJ0xbl7QiHKORvAHyFLihBYuz+5GPl0iDzRVCrO/niERFHxL+3BLZcLXrY?=
 =?us-ascii?Q?xyHu08G9HzSNra7Y52xSEBKGHRhdMTeyv8N5hCPh9Bhbj0CdRlsEFPDic0dj?=
 =?us-ascii?Q?JjTI0VHXU85WXZtjGJeKSO2F0zlPbwYmoLwVcZn3u8JQ9ru2Aky97UUDniKR?=
 =?us-ascii?Q?9u6uGkP11WeAyOMJ5Jjj71T1eAonuhlvj8SxtBjaRK26HE5omTDzRS4SWQl7?=
 =?us-ascii?Q?1EXbVo341dzuB+ioihij0ENTB9ccnMml+UocOS2gRFtzv0CRDzSohdI7mgVj?=
 =?us-ascii?Q?CHC2KY6RMxg79BBAZYwh4M+q4RqmImvt+fsyV7BJvzJmIJcS6TjdxYp8+nc/?=
 =?us-ascii?Q?gFmjnUgxAUCRRyUk2JDXDwAT1wqkPoOI53+N1JQhPYB4ikq/rqxTAKOSF+g1?=
 =?us-ascii?Q?N8dNVKKfC1TItUmxvpn7Uxj19BvEx4LipO/OjeYBTqdBZAMH9Kj9KsHUYaKG?=
 =?us-ascii?Q?yk59cpx/mA228xXkhzmxJlXTX5hVQxvoGXpX6GScTLPlB1mh1RAcM1KiH+wC?=
 =?us-ascii?Q?SA2sKB7YR7tBMgtNeBLjJCgBDH4blQ41lQkwYWZK9CB5gmHfr4LQ7LiI64b9?=
 =?us-ascii?Q?v0I/gAScHFczZjDyNFlVtL0Qtud1b2g50s3gf9uL1JfVrzubM4V34zbeWvXw?=
 =?us-ascii?Q?lw=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb6340c7-16db-4b83-8787-08dbc3e9e982
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 08:22:41.6801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: akBpujpakxNBrXTfW4/qV88i0yT/VAqEbpsQnCRNTQTsmDk0IngiJ07sukTBCgW/Fs6tGyzzoxNnSMNR7nHaW3OtbQ0A3Izdh28wcF2ngtE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR01MB4863
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 01:22:57 -0700 (PDT)

On Mon, Oct 02, 2023 at 09:14:32AM +0200, Jiri Slaby wrote:
> On 02. 10. 23, 3:57, Crescent CY Hsieh wrote:
> >   static int pci_moxa_init(struct pci_dev *dev)
> >   {
> >   	unsigned short device = dev->device;
> >   	unsigned long iobar_addr = pci_resource_start(dev, 2);
> > +	int i;
> 
> unsigned
> 
> >   	int num_ports = (device & 0x00F0) >> 4;
> 
> And this one too (in the previous patch).

Sorry, I am not sure I get your meaning, could you explain to me?

---
Sincerely,
Crescent CY Hsieh