Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <4fe44a5f-9a6f-5259-f14a-d464a7cb8556@kernel.org>
Date:   Tue, 3 Oct 2023 17:25:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 2/3] mfd: max77686: Convert to use maple tree register
 cache
To:     Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-kernel@vger.kernel.org
References: <20231001-mfd-maxim-maple-v1-0-cdfeb48a4d15@kernel.org>
 <20231001-mfd-maxim-maple-v1-2-cdfeb48a4d15@kernel.org>
From:   Chanwoo Choi <chanwoo@kernel.org>
Content-Language: en-US
In-Reply-To: <20231001-mfd-maxim-maple-v1-2-cdfeb48a4d15@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 23. 10. 1. 08:47, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/mfd/max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 91c286c4571c..0118a444a68b 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -108,7 +108,7 @@ static const struct regmap_config max77802_regmap_config = {
>  	.precious_reg = max77802_is_precious_reg,
>  	.volatile_reg = max77802_is_volatile_reg,
>  	.name = "max77802-pmic",
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  };
>  
>  static const struct regmap_irq max77686_irqs[] = {
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi