Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1833462rdb; Tue, 3 Oct 2023 02:20:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJfCT7MOpjLUGa5hTHf2g9h62MbzWOjKNc+lzGFpK/ynIc4ea8J2zYhrLM6b/XvWj3yBkE X-Received: by 2002:a05:6a20:9750:b0:153:353e:5e39 with SMTP id hs16-20020a056a20975000b00153353e5e39mr11219037pzc.51.1696324858177; Tue, 03 Oct 2023 02:20:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696324858; cv=none; d=google.com; s=arc-20160816; b=BdvGaWaSsesdtl0pHaZxqduRYWH+11n6gGG6bw5gwHCkvemHSbZ5isMnrzMqzhK/N5 HubcRRG1HMzchzvbDE0mYl9sBqieiSzCKg+NxlWcAN6QjbI1Dyo/HOa/GunRaUSabefz dtqtpabn0U7xRl6lLY+MU7Rbs8FyA1JeEalLetexeNhvS1I9gxl3JW4nlvv8iDldGkVm PEf8H4R/dE0bejTQsATAl7YaFohNcteeuBCiSsveOPR8GeWbcI5AdpZVW/DIHMFHWTdm enXysKiPmgZKqsuBkytWqujP71/Mb/TCVjGU7AbOLZevW3zzz0iGIZ1nhhyvmnPR5Kih juPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0KOudNYzgOp4t8weNWkL0Cx4A1hdiW0hgJ5CPHqqMZo=; fh=jeME4TOKHAdd4Akd1J9Qs3B/TZOxZS0XvKjw0T2aT7w=; b=uFqTiYe5++xkxUArp+BhkAO/GNEdukJzdBsO+lyiu1ZhQ6K0DJN9WCyLDVKlAWNC5A ZUw9osXzKQVHwLMO3v+WmVR3L14qdnSk9KKN7vNGY/pBhvOm9F6WcFa7GeEnoPaw2R8n fjx8UV+8BOtDI/PG0PluDjmLuRrXkT6vxytAxhAHk0iEZ8Z3fFKt8NF8qpIfnTe1Gk/g 7PpcLd0tfP1xgbUtU/BSsOqV6xez9x8UlNjvXzhzwRESjpT9gKdzwFcFLcXK1wj7sTDF zDYEKoUJc41fwYk+NlnHD/aLWxJ/Ct9FOLGnDsU2wsmXmb8/yt942LaiLHQViCbmCmFG Evmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ArTUptzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id be3-20020a656e43000000b00573f9a427d6si1012262pgb.450.2023.10.03.02.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:20:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ArTUptzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 216B88028A76; Tue, 3 Oct 2023 02:20:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239583AbjJCJUn (ORCPT + 99 others); Tue, 3 Oct 2023 05:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbjJCJUl (ORCPT ); Tue, 3 Oct 2023 05:20:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0BEBAC; Tue, 3 Oct 2023 02:20:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ABD2C433C7; Tue, 3 Oct 2023 09:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696324837; bh=kEex/DR+e1njfBDkl+EL3adoifBZXSVht3DKH7tUYRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ArTUptzCqhOST0Uaoi72u5yMW0ydgIc86ROgVjTLFDFWxPTcOPQTUgzsMI141XE4q rIaY6q16ph24Ufu7uVZbwnLNCCDVSPll7IS0axSwfE7h2XK1BzeN+wf5v5R7O04t5D 9pVYACvLp2GYijTFvCguAi12ExIc6Lc2aQRNCUXMvvJAvSo/cx9GuFPE+ZGntMMqe+ mf4fZqq1o3XzdKLAZsVH4ZgUCttIEBs0Po4wNXHlLe6FDUUD9UCwthviFgnTd5/myj 7FHzg+gFe14HmKhB2rqR0+JTr3/PlS0uGCrMaJ9QykqZV4ucJcY3txIGXCS4JqX1D9 1YvjRcc/EcOeg== Date: Tue, 3 Oct 2023 11:20:29 +0200 From: Simon Horman To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, decui@microsoft.com, stephen@networkplumber.org, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, leon@kernel.org, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com, hawk@kernel.org, tglx@linutronix.de, shradhagupta@linux.microsoft.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets Message-ID: References: <1696020147-14989-1-git-send-email-haiyangz@microsoft.com> <1696020147-14989-4-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1696020147-14989-4-git-send-email-haiyangz@microsoft.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 02:20:54 -0700 (PDT) On Fri, Sep 29, 2023 at 01:42:27PM -0700, Haiyang Zhang wrote: > Handle the case when GSO SKB linear length is too large. > > MANA NIC requires GSO packets to put only the header part to SGE0, > otherwise the TX queue may stop at the HW level. > > So, use 2 SGEs for the skb linear part which contains more than the > packet header. > > Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") > Signed-off-by: Haiyang Zhang > --- > v2: coding style updates suggested by Simon Horman Reviewed-by: Simon Horman