Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Flavio Suligoi <f.suligoi@asem.it>
To:     Daniel Thompson <daniel.thompson@linaro.org>
CC:     Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
        Helge Deller <deller@gmx.de>, Pavel Machek <pavel@ucw.cz>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rob Herring <robh@kernel.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C
Thread-Topic: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C
Thread-Index: AQHZ76uO1Fb/EPNT/k67j1TrFzld37AtE7aAgAmVcBA=
Date:   Tue, 3 Oct 2023 09:43:15 +0000
Message-ID: <DU2PR01MB8034F448F6E66BAC3823CDB1F9C4A@DU2PR01MB8034.eurprd01.prod.exchangelabs.com>
References: <20230925122609.78849-1-f.suligoi@asem.it>
 <20230926130113.GB4356@aspen.lan>
In-Reply-To: <20230926130113.GB4356@aspen.lan>
Accept-Language: it-IT, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S5iMIa0ehqMGwt7WQI7/W7OMXSqlgqp4IKJ7sWGPiCWUTvH9PVn9mCWE6eZ8?=
 =?us-ascii?Q?OjmOHIEQnCSAU4ZFTKEIhf41AQwfZpm/pM8AuO5waUNjxUzupMc3zkhLcTDR?=
 =?us-ascii?Q?tZuQixDjUP2sndcrLqZmMlHRhAgWlhnoEhp6bW3tZfroBlqIXJ9Q/uKn47g3?=
 =?us-ascii?Q?rkdZuB3dtxtoEob7aNzUA5nNAkAFKjk3vSmNfJVRW8Uzqo4R4pNyqtqUTMCH?=
 =?us-ascii?Q?Vx3rLvUB1OEz9yQXsWtVdwfq8b3T1RWqbwpgwL5W7eR/wErmdD0PuyebAIjR?=
 =?us-ascii?Q?phUmgCNSbTriKPeX3KZ4p67D8ZeHc/QJdaWwvSYBMxDvERP3kdDg6Ns4w+bB?=
 =?us-ascii?Q?i+IUj4KnaVikFGDTvV8jE7LR2HE99J0NTem4g7nhrYOykqwEzEaMh501KtVy?=
 =?us-ascii?Q?n+BXrzQNl4SaNbR4cMcYAA92MqGCkvppxQrR5loTn8gK61hGqjkE8D04j5sN?=
 =?us-ascii?Q?vC04gEKMI0vb67Y/mMIDmfjT0CC8P0wjUYc4kWXGkBNforh1q9nfBvmVsga6?=
 =?us-ascii?Q?jaGTYsv7Q2Q0MOCjgpJXxzg41Avn6WS7FIOAI0co5O4kd5mvevizv6aPoJZG?=
 =?us-ascii?Q?JnU7nyLE3ZJC5t1sNgz0f/czRqfZAdbaqFgC09ASGJqJrTVJyZATQwygGOrD?=
 =?us-ascii?Q?FZvIlvabsah7ftpMFKOpNiQahJIu46IaLQX61WuQzORuBM4uWqVRt3X6Rc3P?=
 =?us-ascii?Q?8ME2/mZx8m02/tWzeqwgrrS2IcpcGVaOpV+qP8mJE2L9gcTcYW5oLIfFCd4x?=
 =?us-ascii?Q?+CB4fgNkJQ2OU+ORHqkBPG+GdxUd2JYRa5EfNTMP/FJI8/BFUCNNmsyUpAXC?=
 =?us-ascii?Q?X+F4MyPlmOh6cGa7LhCbx4EOdi4s+y9CQgtQMLFirsmQuvobreria+gvJ5Oe?=
 =?us-ascii?Q?XudA+tJhNyEFPXs9ZIIusH7fmW+4FinzxzfT+kfZZrZHMkmSd22vekPUVpFD?=
 =?us-ascii?Q?CLBj/bL5Kw+JRUgMePq+7pTMlvxvM89w4kFtZrH44yWUFVXocQT9aRaA037V?=
 =?us-ascii?Q?dSPu0rAVJBA5p/wTRfgzCV2srkNWOYbp94SaZ5iVtFOvVAbFnNaqG+vH3iv/?=
 =?us-ascii?Q?Kf9YLWpxmoHhk3iEtxDLbJWQKV4m65w66C2E80Mz5Ei/jt2y1S4YWoiWZTPn?=
 =?us-ascii?Q?KsuHfjCNAgXcw/G+qecqdo9j0++lYxYaonySrZiIlY/QMkBoblj7giJYzLXd?=
 =?us-ascii?Q?WMZ2uEgQxoneYN/zv0C4jJfeXbXJwMAPiLzHlsFDppmLDqITljWUNthOSUkx?=
 =?us-ascii?Q?9EpFWGJAKI2HFtus3PaKeYv0wl5yo6G/hJBHjBUNRSj7/EobYVX7BFVQ4hw9?=
 =?us-ascii?Q?tgyDpvYjTMtfmSAslbgYdXtUKIywwuRIk522khUuVCgicLQrNwfjU2NqLtW9?=
 =?us-ascii?Q?RKDYlroMnfttvBdFZmSreyTHRVYGr+UINrdkmG5S17LFTRh5q/HuIi1LO5nL?=
 =?us-ascii?Q?Z+jKCTZ2iow4IHEN1WGEdgSEOY8TtHgWggVS2km/kn8L6wBGqcziSrw2iz5S?=
 =?us-ascii?Q?XNIFdQIRDi6A2eOfGnYhXmi7+E8CePJvPR4ZNxbj8FPipP7ohCWF9Rl7j64S?=
 =?us-ascii?Q?+0Li5IRzztLMqJ5b6RM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: asem.it
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR01MB8034.eurprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae921ce4-b6f5-43b5-6b8e-08dbc3f52a8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 09:43:15.0853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d0a766c6-7992-4344-a4a2-a467a7bb1ed2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lu/H6EQ/JAnLCA5FjtNy3BBsqIKJQsxYCnu3rxArvzCSuxnD2MXDN/2n+oqFfcfAakp2AI1G7WZLlRxgL0eLIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB6301
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 02:43:33 -0700 (PDT)

Hi Daniel,

...

> > +required:
> > +  - compatible
> > +  - reg
> > +  - max-brightness
>=20
> Why is this mandatory?
>=20
> There's no point in setting max-brightness when running in I2C mode (max-
> brightness should default to 31 in that case).
>=20
>=20
> > +  - default-brightness
>=20
> Again. I'm not clear why this needs to be mandatory.
>=20
>=20

Ok, you are right, I'll remove max-brightness and default-brightness from r=
equired properties list.
I think to change these properties, for the pwm dimming, into a clearer:

- brightness-levels (uint32)=20
- default-brightness-levels (uint32).

For example:

  brightness-levels:
    description:
      Number of brightness levels. The actual brightness
      level (PWM duty cycle) will be interpolated from 0 to this value.
      0 means a  0% duty cycle (darkest/off), while the brightness-levels r=
epresents
      a 100% duty cycle (brightest).
    $ref: /schemas/types.yaml#/definitions/uint32

  default-brightness-level:
    description:
      The default brightness level (from 0 to brightness-levels)
    $ref: /schemas/types.yaml#/definitions/uint32

Example:
brightness-levels =3D <10>;
default-brightness-level =3D <6>;

What do you think about this solution?

> Daniel.

Thanks for your help,
Flavio