Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1842146rdb; Tue, 3 Oct 2023 02:44:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEcC98yQbcm8QTP5B34bmmIcewWla9oda4SOkGH2D9Qwto54HVtexjh+z6QAJX3aMuf5cZ X-Received: by 2002:a05:6358:7e0f:b0:143:7a89:a8d1 with SMTP id o15-20020a0563587e0f00b001437a89a8d1mr13652042rwm.0.1696326264718; Tue, 03 Oct 2023 02:44:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696326264; cv=none; d=google.com; s=arc-20160816; b=IjXpQ4kMJsNhlCQHjMMfzqH5CnSWYixUMFXyH0ST48EQwamibO2N+HeExTYkMPNTWi uPLyUt+bBw0Gj+wWfqr8g62Uli+kqrFD8fEUp1Igl77LapgHe1YbwwTBPWTqZD3CfbpL Tj+n4P4Ixxj01M3e+TiqyqGGJHbioZ3837aNAkQiSjkCYQT7zmeZzIdMqRCSW+0h04Wl bl5MdCn11REUxGxgRivT8VcLVY1z1kTIDMF7qI+4n+4Hweh3ChuaBga2HHv3ts5C8ily 1P3xkR6YPo2hqtVTKqlozdLAgl+tO/WjRjPh2bWi+iVR6Jj9jdvBPSe1Vyqv4ZKn9l3M h8VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=25GhU8pmb3+MBDJU35yF1QaDQHbs++kTbFz3mKGDv/g=; fh=t9zTXlCCOOMuWy890Z80TpdvjqtPqsHgbj9M1mGKB2E=; b=KRt6ptjTfd4IBzdt7uwjBG5ETTb9ewWa864Qf4F+/aM19u80e7eNNz5nxc/GtuoDiI kGCgLeIu+s/z0Z1j4Ht/LjvRtRUHzo2O/q/LBrH2iSyNdMUuKMunSl6n9gNRkeRaabkY osJvUdsTk/S9cEN7Pico9DzZ+Iej1jb+gvgFU6quqjKAi/HMOaxq/4jbNR7isov+rCqZ csd1s/xz13ipeKkFQCPRHp6S88WjZ3wfMoqKba/Ja/B+Ni6gDdFO8uxvbFrxs4HJAWBO Vh4hu9a0acWY/SCtah7vPyona0Ld/eFxn0dodtHPChPBtq9McbAjtWKKxp6UYYms/YnH Q1+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jE2Kd3jH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id t4-20020a63f344000000b005789f552066si1107675pgj.335.2023.10.03.02.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:44:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jE2Kd3jH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0274A802F8E2; Tue, 3 Oct 2023 02:44:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239681AbjJCJoO (ORCPT + 99 others); Tue, 3 Oct 2023 05:44:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231750AbjJCJoN (ORCPT ); Tue, 3 Oct 2023 05:44:13 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE754A6; Tue, 3 Oct 2023 02:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696326251; x=1727862251; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=X+SYu9zrGvFmbRhUEqLTgMR+wzzPFb8MNKSU4bv+UTw=; b=jE2Kd3jHVKwrFr/N2B4xdJGurzcfywMVKY/P4bfnFKcvj49pt8Tqo1L/ 7MXWCSQOKPjZcHjaiEMZmxWloZ1iT6A1cSJrAcLQanlxdtWzdPnGgX55K 35LQLENnr6/a3Y78boPu8rOOd0/OAHHtGP4WLWF+jqeE3ByvUFxH8me70 Mx1ZKC8IDXrJvvNKv5z3P4P+tWVk+PWsyMmL0uVUjO/29+UJcD30TWbgn 2SSWUp5Du23oO7zU02ltgh2YiChukz4JnedeA4alfocmArsnT44PPf6X9 05PJSO6bCBTL20jtkQODyHm98LvLxpH8R/WmNmdsq/VgttOnORRHXxutY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="4398085" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="4398085" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 02:44:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="754352145" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="754352145" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 03 Oct 2023 02:44:08 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 8A74218A0; Tue, 3 Oct 2023 12:44:07 +0300 (EEST) Date: Tue, 3 Oct 2023 12:44:07 +0300 From: Mika Westerberg To: Mario Limonciello Cc: bhelgaas@google.com, lukas@wunner.de, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] PCI: Make d3cold_allowed sysfs attribute read only Message-ID: <20231003094407.GG3208943@black.fi.intel.com> References: <20231002181025.82746-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231002181025.82746-1-mario.limonciello@amd.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 02:44:22 -0700 (PDT) On Mon, Oct 02, 2023 at 01:10:25PM -0500, Mario Limonciello wrote: > Before d3cold was stable userspace was allowed to influence the kernel's > decision of whether to enable d3cold for a device by a sysfs file > `d3cold_allowed`. This potentially allows userspace to break the suspend > for the system. > > For debugging purposes `pci_port_pm=` can be used to control whether > a PCI port will go into D3cold and runtime PM can be turned off by > sysfs on PCI end points. > > Change the sysfs attribute to read-only and simplify the internal kernel > logic to avoid needing to store the userspace request. I wonder if this ends up breaking some userspace apps? Not objecting though, just wanted to mention ;-) One thing we could do is to taint the kernel or log a warning if userspace touches this but allow it to do so.