Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1844017rdb; Tue, 3 Oct 2023 02:49:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKOuVy/E3vA2x3rUw3S08o4kbtsmCh1xjUU61B3pU3rWy+9CCZeuGX+e/INsoE214YIsSR X-Received: by 2002:a05:6808:f01:b0:3a9:cfb5:4637 with SMTP id m1-20020a0568080f0100b003a9cfb54637mr17133276oiw.38.1696326572637; Tue, 03 Oct 2023 02:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696326572; cv=none; d=google.com; s=arc-20160816; b=U8efFDrzFtXYxPLASTIO8pCV6D3TadboYpiBaT0GFODE/ADCtqTEbOtqs6vGV/BljM NQIPaVIO2yyEtjGzb+fRMIdPs7iFNu9q+MuV5+TFUGKPr3Cy+f0bMPz+IWTeWjkrpL1C iJNlzQF0WDuwHOabWhOb4CVqbdRrFQApgcTZwveDA0bwAlU4HvV0IrZNf/fUueJE71jB xaIivrRP+JPDUXNgjAhbfOjdy2of3QVx3rOiZL5Cj1zh+kqAI04yrbvYZJZxT5PDMvVG P2FqbL/BcrI4WZZnu7HDusN0Nt13Z1G0Sf8ZGFLql5whF6lIxVPCNOLUvySgq1dMqHmy mqxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id; bh=xGENg/HCTY6zC5C8Ke64JQ+N2BWUfpXxgKBq91OGwLg=; fh=UDEP02IMRESZyMRYqL+5fFK+AQCtcbPmIw/A+ToL3xc=; b=b7PCcIVoHi0JGcI1UWZWOUYXny8B4QlBT1O8WNwzJBSz8/WyUFz+xALXzS3G8i85KP RPrVDyMgdTKpwywtGW2hdIm2igBOjtxgtsCQadr8PMVpzWR2JZ7nDinctAfIMMngS8uz 9KgcAOh3u69iw+YYaicr0eYHS7u5JML2milTfi+OdDA/c+U04oXkeVc3qblLXAU7nSnk PrHGkQ1y9REyZrl3JHfcFFE/kX+ErzCosTE3g4KbhP9YD8NjiY5g6SN53A/118B614xa pA7dw0XXjjT/6AaOPEQASYEfxJXMk256uLHxxe8jrssxEjS8wEmsKgKcMgB+Y11ULM2v Ba/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id g25-20020a633759000000b005859de837c9si1105964pgn.105.2023.10.03.02.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 80003801B666; Tue, 3 Oct 2023 02:49:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbjJCJt3 (ORCPT + 99 others); Tue, 3 Oct 2023 05:49:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbjJCJt2 (ORCPT ); Tue, 3 Oct 2023 05:49:28 -0400 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A3FDBB; Tue, 3 Oct 2023 02:49:25 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-405524e6769so3904835e9.1; Tue, 03 Oct 2023 02:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696326564; x=1696931364; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xGENg/HCTY6zC5C8Ke64JQ+N2BWUfpXxgKBq91OGwLg=; b=hxMtmUVNMCd+T4KGxvwRFYdhr2Porv6zkY1xzlTbjScNiQyUR+hVKVMl2KXJnUG07V aRNYhMAf2i5Ao/8M4Dfl+lQtbH7MyEclE8wsW8YrZ5+dmXGqdowcVgTlRRdvEQl2wGik wEOO6PKedrrKWLRH6DUYkxQwrKuknZyH/iNI74c5T7uhjT7gbDbaWr2PT5+RtKH+2Wg2 U3RMbfq6916RG/N0R9cjqqpgKcKv/B4rZfOPNrcla90vMqRBuVutkh1PqcLF6/1nWyHC 92uv1bXkIuN4hsT/ioedbHC4U0r7U50GVbyFStwHdjURisHEQx4fLxquRlU1BWVnnLFS dfKA== X-Gm-Message-State: AOJu0YyWa8m7ne89wTYwYQMoVJLLZ2xj7st9a1oQKisp29TYQTJiVon8 F7EP4PyezkuxMjDYZcGSyhcarQhH+Mhxbg== X-Received: by 2002:a05:600c:3ba9:b0:402:f91e:df80 with SMTP id n41-20020a05600c3ba900b00402f91edf80mr1544996wms.3.1696326563530; Tue, 03 Oct 2023 02:49:23 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id t23-20020a1c7717000000b00405959469afsm879722wmi.3.2023.10.03.02.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 02:49:23 -0700 (PDT) Message-ID: <9c00918f-4bc1-4096-8e79-2a08d835210b@kernel.org> Date: Tue, 3 Oct 2023 11:49:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] tty: serial: 8250: Cleanup MOXA configurations in 8250_pci.c Content-Language: en-US To: Greg KH , Crescent CY Hsieh Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com> <20231002015702.30509-2-crescentcy.hsieh@moxa.com> <68d533d5-dbc8-4be3-a1fc-b3dd28b8f9df@kernel.org> <2023100305-gentleman-surging-a65c@gregkh> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <2023100305-gentleman-surging-a65c@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 02:49:31 -0700 (PDT) On 03. 10. 23, 9:30, Greg KH wrote: >> Should I put these macros into pci_ids.h? If so, I am willing to help >> relocate all other macros. > > Please do not add new defines to pci_ids.h unless they are needed in > multiple files. (Which VENDOR_MOXA is, but DEVICE ids are not.) -- js suse labs