Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Tue, 3 Oct 2023 11:51:47 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org,
        kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it
 child
Message-ID: <ZRvkM1lxsTrHb2Ox@gmail.com>
References: <20230803050317.2240948-1-yajun.deng@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230803050317.2240948-1-yajun.deng@linux.dev>
Precedence: bulk


* Yajun Deng <yajun.deng@linux.dev> wrote:

> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
> it should not place out of RT_GROUP_SCHED, move back to RT_GROUP_SCHED
> and rename it child.
> 
> Init child when parent isn't NULL in init_tg_rt_entry().
> 
> Introduce for_each_sched_rt_entity_reverse() to iterate rt_se from
> top to down.
> 
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202308031034.4369b15b-oliver.sang@intel.com

Yeah, so I agree with these changes, but could you please split up this 
patch into 3 separate patches:

   sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
   sched/rt: Rename sched_rt_entity::back to sched_rt_entity::child
   sched/rt: Introduce for_each_sched_rt_entity_reverse() & use it

Thanks,

	Ingo