Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 3 Oct 2023 17:57:41 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org
Subject: Re: [PATCH 4/4] tty: serial: 8250: Add support for MOXA PCIe boards
 to switch interface between RS422/RS485
Message-ID: <ZRvllYZS3ks+dOYc@moxa-ThinkCentre-M90t>
References: <20231002015702.30509-1-crescentcy.hsieh@moxa.com>
 <20231002015702.30509-5-crescentcy.hsieh@moxa.com>
 <92aed0d9-791f-4708-8a73-4c78457a710e@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <92aed0d9-791f-4708-8a73-4c78457a710e@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NxuYp3/G8kPHdtoDE/IlXUMWAXYNPUAlnKGzM5FqlXFoFY5l81Ct9/j8rcn5?=
 =?us-ascii?Q?xgifl6V+NC87kL0mCjSMpwXWw0oUzGlMnUR7FShyc31OrS1LXvEQqC49mKT1?=
 =?us-ascii?Q?WTrlyiT20hCiR5sR2O85Sy++3X+2Fnt/A+YdKNIS0bfxYeQhAh4o0lfJaj/P?=
 =?us-ascii?Q?zL2pm2amnGNH5x52ekjzXmrwE4ljW4n2b4upMZJLN8+7+u/elTglWnd9DKm/?=
 =?us-ascii?Q?JR9W3XtXGuE8C7dr5zSL70EfuR/psFcecvqVILbX+koSZTAYs/iRyLusp0Yu?=
 =?us-ascii?Q?RFweRF1NrpCpxVV+gL9bqkwndj8ioLg830YYWANODHOGkm4/Kf7A73dWcFt7?=
 =?us-ascii?Q?5OwpuwCjA96WhWM3pA1ncvaz/7KLrJEOaA91n5EjvL6FNF2sjgZcIE18pmI/?=
 =?us-ascii?Q?rPsbAMxLhxX6eROjQv2vDDDUL3f9rJPupqZrvH4IU6Bz8NWzbmzyFxD+hUzR?=
 =?us-ascii?Q?Ds3J7yyrBWevS36MDBNq4Ze+0CUa2+CLyU5sW+VvRG+FdV4+8taRtd2vAIBL?=
 =?us-ascii?Q?WNugi8Je54hMlyEmHP3cuV45RABK2nFBwcQ0CJRvoJG1aZBQg2gid2s3uQk4?=
 =?us-ascii?Q?TqpmCIDFgUlm3aRg7MUithbwDsfXt2Lm7w1E5orAm3TG/FKMTDp/GB5ZkObe?=
 =?us-ascii?Q?Xx3v7N7JXqkWHA48X8DUf2bq0Pl4X3MLgpJcrCYT+tnDyzt4DI9ATYOCM9BF?=
 =?us-ascii?Q?BTeNKVJo59S9npHmMzXWtuaXgKdwTkGnJmSy065T123CteXHu/rTTw8to51G?=
 =?us-ascii?Q?No5m9rPXKKmhL38vv0YnD9hfk0CmnMkD5kcLhKz3gENZvreukx5hHX4NsJID?=
 =?us-ascii?Q?l2VHKH0GcG/LkKOKDOEL92aj1q/3zbC4fTukMnwQtHBtdbS2xRU0fnt54kAg?=
 =?us-ascii?Q?UE7L+By8HMsuDcz5aVLXRk5XW/q0MOwzvqTMoJrgMPYD5KZKV7uiOrWhOJAY?=
 =?us-ascii?Q?eHpbqBYYPlUUp0BvmI5VSq70VGLQoaRa5fVRbZvep7uL4fWNc041rv2q4Y4R?=
 =?us-ascii?Q?UncGXss3RsI2WHP13fsf946USJvjzD0HYBXsoYlBlqlUo4zkmVM+3ycxBLHQ?=
 =?us-ascii?Q?lS/hakbu/yaLNqs/nSkf0jfGnv6HgnkBacnNje525mH1pBrh45FXmCldQkpB?=
 =?us-ascii?Q?Bs5GhgiTIzeQfLElQx6MISrBfbjdjPBEO/zN1yefch8sL2hp2gm8tL/6QisY?=
 =?us-ascii?Q?hmK4z1rWu5YAaRAQO3JeJ0Ijng32dc+f2DGHbiWfbcJT1/qznW9aBxZjvysy?=
 =?us-ascii?Q?GQILwLE7Q4WAibfqlzWv3Mf2xYYoSHZrZlQOxSRPcLMfk8dWt7gshz9gvj1V?=
 =?us-ascii?Q?VibycsmfxItIFMGm/msdTlc17BAE15JjJyDo+1ofhFelCGVM7vA+Vzaue+sh?=
 =?us-ascii?Q?K4yEJbPeqsudNEWegVf7hVUtU1LEx3GCDjl4XJa8unHxAVk4iqiH3mJX/uCr?=
 =?us-ascii?Q?a5eQ9DSDSLJixgfVJukmw+HzHKIK+iKuqkhBRBMyS/yJlhjxplh0NTXmRR7U?=
 =?us-ascii?Q?lFo12rBvroQEA1C8WufOlu1MMJU1wUsq1RNxreTzTUiFYOxNX1SAQvSd+Olb?=
 =?us-ascii?Q?l3WE3tMdwBMFNs7AVmLWhlDRBw9Csf7UsmaZ0w8pE6iwl1xCa2uVY96gSRp4?=
 =?us-ascii?Q?9g=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 662543b1-7342-4a31-1d51-08dbc3f7308f
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 09:57:44.3603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t5rpATJnBX8uYzbYkuzPVAf8KQeA83u2ztJVS46C5XmGQ4RTJdCywG/s3twt38KqR4qjxl5xnaaVwq9Fa4PXgvSJiBVWNQHebhKfYhTUncQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR01MB3810
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 02:57:57 -0700 (PDT)

On Mon, Oct 02, 2023 at 09:19:26AM +0200, Jiri Slaby wrote:
> On 02. 10. 23, 3:57, Crescent CY Hsieh wrote:
> > MOXA PCIe boards have 4 serial interfaces and don't require additional
> > stuff to switch between interfaces:
> > 
> > - RS232
> > - RS422
> > - RS485_2W (half-duplex)
> > - RS485_4W (full-duplex)
> > 
> > By using ioctl command "TIOCRS485", it can switch between default
> > interface and RS485 if supported.
> > 
> > That means, for RS422/RS485 board, it can switch between RS422 and
> > RS485 by setting the flags within struct serial_rs485.
> > 
> > However, for the RS232/RS422/RS485 board, it can only switch between
> > RS232 and RS485, there's no flag for switching interface into RS422.
> > 
> > This patch adds a flag call "SER_RS422_ENALBED" in serial.h and modifies
> 
> Hopefully not SER_RS422_ENALBED.

What if I use an existing flag within struct serial_rs485 to represent
RS422 as a workaround solution?

> > @@ -1299,7 +1299,7 @@ static int uart_get_icount(struct tty_struct *tty,
> >   #define SER_RS485_LEGACY_FLAGS	(SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | \
> >   				 SER_RS485_RTS_AFTER_SEND | SER_RS485_RX_DURING_TX | \
> > -				 SER_RS485_TERMINATE_BUS)
> > +				 SER_RS485_TERMINATE_BUS | SER_RS422_ENALBED)
> 
> So have you tested this at all?

I have tested it by switching the serial interface using TIOCSRS485
ioctl command, but it seems that I send the wrong patch which mistyping
SER_RS422_ENABLED.

---
Sincerely,
Crescent CY Hsieh