Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <efc33949-9950-d51a-a7d0-d8214a092a2c@oracle.com>
Date:   Tue, 3 Oct 2023 11:22:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 11/21] fs: xfs: Don't use low-space allocator for
 alignment > 1
Content-Language: en-US
To:     "Darrick J. Wong" <djwong@kernel.org>,
        Dave Chinner <david@fromorbit.com>
Cc:     axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        viro@zeniv.linux.org.uk, brauner@kernel.org,
        chandan.babu@oracle.com, dchinner@redhat.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-api@vger.kernel.org
References: <20230929102726.2985188-1-john.g.garry@oracle.com>
 <20230929102726.2985188-12-john.g.garry@oracle.com>
 <ZRtrap9v9xJrf6nq@dread.disaster.area>
 <20231003030010.GE21298@frogsfrogsfrogs>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231003030010.GE21298@frogsfrogsfrogs>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzFtSndJQ1BwK29PMjdBUzJoTmJKYUUrUTlUQmNSb2xmVGV1T2xMZTQzYTBv?=
 =?utf-8?B?VHQwOFZpd1ZYYU9Na2FRLzZocVlvUloyNVBrKzlYUzFpYjI5OXBlbEIvdDZn?=
 =?utf-8?B?NklhdzlOaU9teE1yY3l3WCtXbys0OXJSSzlmeUxVUllqeWprSGl0MVFYRUVY?=
 =?utf-8?B?eGJFaVhtWXpwVm1ZeFhrVDFxUHFuT2N1MUVMRWNQVE5qNzA0QW0rZmhPeXQw?=
 =?utf-8?B?WkZ6K2VESTBMY2FXak9aKzliR3lZbVZSWG05dTZYSHRiL09haXFRVExMTHRG?=
 =?utf-8?B?MnlFUTFEcmhPdzV4ZVcydlcwbGMvK0RoT1pibDF4R0plaThsS1lMV3luVTNj?=
 =?utf-8?B?bmw2TE9Da2pyeTFsQWpFMXdwOEVDNkJzY1VpczE0Y0pKd09Kc0s1WmZMbHVE?=
 =?utf-8?B?VGpJbkpNYTVvNEF3K2V5V2tIQTVMMTA5a2ZVNWxQOVZ3c0VkRTFoSTd2cTM4?=
 =?utf-8?B?REFJOVBkdXBBOUlYMk9TUWpEeG9KbmdUWXFOV2R2SFozV0E1WmU4cXVuOXYv?=
 =?utf-8?B?eCtJSmdLcXF3QmVnSmxORy81THY0QzJGUjZQWXRUa2tTbUtpOWFQNjZSUzJt?=
 =?utf-8?B?R2lmL3o5dElpdXNNdU1PaFpWVFZBWGNQREpyaDg0Qzc1dUM5SjJqYU81Z2N3?=
 =?utf-8?B?QnlybUF6YmpWZ0M0Rk04UVMyVmRuQ2dzdzNOVkRKZUR1dGNUK3N4L1h3UmRq?=
 =?utf-8?B?SURrWlFxNE40dXNFMHlkOUdVa3JUSUYzOGVBMVp5ZER1K2pycW02SzZaeTU1?=
 =?utf-8?B?Vy9NazVhV25XL2VsaEtwVnZ5T2Y5bytscXpINUYwY3lvSXFjVDFna0x1SHRP?=
 =?utf-8?B?dm8wVHFoYzMyNmFlRGVHdjQ5T1pySE1abVlkanJvUStKVCsrRGFXdmVVbzc0?=
 =?utf-8?B?TnVneHR2Tm9Gc0hUM210ckJTNUVmWDZmbUZSdDlxTks3dmRmQkV3VDN1ZE1y?=
 =?utf-8?B?Z2JaNG1EVE5TR014NmZMOEUza3JqVnkvT2x0cWluOVZtS1hRbVBlb29aTy80?=
 =?utf-8?B?U2tzSTdyVjFsL3hiQkNqelNPQ09DMFgxQytMYW41dFdJWXFZOG5XdlBWSFEr?=
 =?utf-8?B?MDJsUkpHazZFWUtYTTJZYzYwVUpHSWxlZE1FSWpHejN6N2ZvRGIwc0lrQjkv?=
 =?utf-8?B?RU9HOUNZQW5ZNG9SeHNWcU9OMmJBaUl1b09pcHliUmRyMitkeVExeDk1cld1?=
 =?utf-8?B?b1FQNkxPTU5pb3gwSHB1VWxrWUhKM2txaXNpbTJhYnNIQTl6aGRhdkpyTzZ3?=
 =?utf-8?B?Rk5WWFFXOVJ2SUpqU1l4RStlTFNRZFdKeEltY2tUQnNLS2pEM0dpVkJuM1Q4?=
 =?utf-8?B?YW1zdXlmNHMvNUNVY2hmODVCQnBiY1RHQVRHc3hFdmRmTGdLWk1kbll6czhP?=
 =?utf-8?B?NjdHNGxxN2RpQjFKeDBSTFZzSGFXMjF6WjE3YjVoTUNmWmxXZDVZQU5LYS8w?=
 =?utf-8?B?TDVtMTdZS0tGQXR3ZjZsRS8va0FwQmlORkJJeURHcU52T2hDVjQ2WXZ5MTcv?=
 =?utf-8?B?SnVhajkvMlE5ZlNncHk1VERqcy9ZVWRvZncycFRZL2Z5cVdBMmpnMVFKZ215?=
 =?utf-8?B?b1JPamtoRG0xTXNYRVZZaDhzMWp2NU00Y0JWQ2RpM0NBeGZQUWh0dEpxNlcz?=
 =?utf-8?B?dm5Kb1ZJbmRzSEtYdFlLRmxBRUdQRytaTzZOMDYzTlZWTytYZlorSmppeXRI?=
 =?utf-8?B?QnJrbTBqZ1pRbWdUaU1CK0JGeGZZNjNWRGFvdDNYeE5jYmdmOUl5ZWIyV25o?=
 =?utf-8?B?S084aC9LdXRmSVFmV1paNVBUeGFwbGF2RXpRVkkrTC9LQUhSQlhaczFKc0M1?=
 =?utf-8?B?aGVkcXc0L0JoODV6bmt4aXp5Mmx5NTRaa08yU2p4c2lmcy9hcUFRQUZOWDh0?=
 =?utf-8?B?U28xKzZnTXltUnBNeVlUNkRNMy9uYko0ZlRtbDNlbm9hMmpCVlJaek93QXUz?=
 =?utf-8?B?THdGa2xOWmJON2JSN2d1c29jSmMwaTVIeUxJTDFSeHBPQVRua0svL0ZZTWNi?=
 =?utf-8?B?ZjdadUZIbTFoS2RuS0RHQkdNVFRtanZMcnVpby9BMnJpU0ZiSG5tTE9KMEJk?=
 =?utf-8?B?QXhBM3dKRnlwZ1gvQVh6cFNqeFowL3FaRzNCbVU5WUxRS2JyQ0UwWExDUTBr?=
 =?utf-8?Q?TSl4MJhNzVWwwSqOw+apB7MG5?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aENlczdnRllOWldURFBMc2c4YjZHYkYvcDU3aXkvZFpRSUtFQXhPRDhEUHVW?=
 =?utf-8?B?eDhCOEl1bGg5N1ZrbWFWYUtPVHZKZTV0SnhzK1VvRS9XRW84MGgwVUJHc1F4?=
 =?utf-8?B?RGN0MHZRZXovODRVVGtBRE5ZL1ZXb2VORnZrSTFMY3MrMXBzbWR6Ujg2UGxy?=
 =?utf-8?B?bVhGWnB1SjFqbVh4bHhFcHdHZUV1REJPaUZUVWhEYzQzOFcxb1BUMDJqMzJ2?=
 =?utf-8?B?VXh6QmowRE85WXM3ajBSaHk0R2RoWkgvbmFJYXFjdFM5V2JqcTk0QlVZMFcw?=
 =?utf-8?B?WWRsWlIxbFlwTWFTQXF4NE51Q3N4eDlJTlN1QUpVRTRJRURRbzRwOXpJSXdJ?=
 =?utf-8?B?R0c2MlVublFsZFBJQWdrZkJhamNBTFY4MUVUSVlrc21MUTdWenNlc0hTbHRP?=
 =?utf-8?B?QmlXMWNjK25RTmhBWC9UWnVxUWlBR3VacXgxNmc0ZElHckhWaVBrZmFzWE5D?=
 =?utf-8?B?T0lhTitCRDhKZ0JkTk90ZFhxUjllMjZMWGFFaC9STDdlS3VFWld5Q2loQVA2?=
 =?utf-8?B?ZGRST3A2R1I0aHEzWUJGa01sYlROYnJLR0RxRFh0Qnl0WHNXR3JMWVUwRHd1?=
 =?utf-8?B?bkROcUhYNTRacFF5SkkvTmk1L3NxWEEvQWUzV0VLNFRBTUJjMUdnUWpMbDVN?=
 =?utf-8?B?Y3lja2FHLzZmRVc5UFpNVlBJNW9GSUt5YXdtQnF2RnpVRVFQWCszWFpXajZY?=
 =?utf-8?B?dXBIYjI2WWVoV1dqRzIxNUVKanlMSTRBQks5L3UrV1BDTzVSZ2lyQWg4UFZ4?=
 =?utf-8?B?QldBRGhDMEdtSTlRY0dYczFybUNkVEtiWWhDZlhyeDBVU0R2elQ3cTRDUkpo?=
 =?utf-8?B?eWJSNWR1RVFHNGQwNWJ2UWxHSCt1VWM2MEo5dGpYVGdwZmx1QXhpY09lVldL?=
 =?utf-8?B?bGpOTDZYZjdHQlUwZ3EzbGZDNmZrYjdTRnA1aWE5ZHplSW1LMHdvbzlPdzUz?=
 =?utf-8?B?SlV0N3RvVGJjOVR3T2NUM2pVQWFpTVF6QXp4WUxzUEpWbklyelVMdXVqOFFm?=
 =?utf-8?B?U21kbVJVTEJUMkgvb3k5SHhOZG5NL0lTUlF3bjljdlNHWEFNMENpNUh6MjJp?=
 =?utf-8?B?QXlSL1duZDBNUkNpemx5NmV3SW5PNllQYnRQTWRsVUxnd3AxRVJ6eDZGMWVJ?=
 =?utf-8?B?OFp0RmMzRGFZUDJjNFFVZllZRnFvc0daR21HYkJ1cE1ZR2ttV1ZYYW95cFdJ?=
 =?utf-8?B?MnIxRm5mSlNXMG1ULy9SZU9tczFTdjRJMTFnMDI3ZnMwTGZubUkyRHhiVDcw?=
 =?utf-8?B?N1VzdE5POWwxSVhtcG9QL2xyVWxNYlp6YnAxZFBqeHkxMVZNK1h4RWgwSzBh?=
 =?utf-8?B?cWhuaWlvK0pqeTNNdW9RTE0wYktlTnpacnZtUHlCZnVtaER2TzgrRE9hZVhY?=
 =?utf-8?B?K3hGMEdORjBUY1dmMjBsdWp2L3JyM1lHdkxQcHlwbWhiR1NNS0Q1STBSa0xT?=
 =?utf-8?B?N0ltcDBwSjlneExYdDJudzJoZXVpVThMMEliVjFQOUdIOEl0T2tqY2xYcGZP?=
 =?utf-8?Q?LhssPfAu4rnzwSVE/UG+pDbdw+G?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a18d5080-e054-4f77-bb79-08dbc3fab424
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 10:22:53.5825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MvnWXyVKnmHSNHTwWZoxveJwsnyq503PLp/vaaXsgo2IaqDKvSgUnaTVncPQl0G5yYWRcTe8SytX3AsZNUK59A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6875
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_07,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 spamscore=0
 mlxscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030073
X-Proofpoint-GUID: qxxlS9ospwzccw_4F_N7eURpoKJcujf-
X-Proofpoint-ORIG-GUID: qxxlS9ospwzccw_4F_N7eURpoKJcujf-
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 03:24:12 -0700 (PDT)

On 03/10/2023 04:00, Darrick J. Wong wrote:
>> How does this happen?
>>
>> The earlier failing aligned allocations will clear alignment before
>> we get here....
> I was thinking the predicate should be xfs_inode_force_align(ip) to save
> me/us from thinking about all the other weird ways args->alignment could
> end up 1.
> 
> 	/* forced-alignment means we don't use low mode */
> 	if (xfs_inode_force_align(ip))

My idea was that if we add another feature which requires 
args->alignment > 1 be honoured, then we would need to change this code 
to cover both features, so better just check args->alignment > 1.

> 		return -ENOSPC;
Thanks,
John