Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1861535rdb; Tue, 3 Oct 2023 03:29:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHV1U5AONDi4zGnTeYVJ0WhZ9JG2Peb8+EtT+oixJHx7x0FAbRzWF9ThBlQvV2onOPGqNx1 X-Received: by 2002:a17:903:2445:b0:1c6:2161:b191 with SMTP id l5-20020a170903244500b001c62161b191mr17240838pls.8.1696328981368; Tue, 03 Oct 2023 03:29:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696328981; cv=none; d=google.com; s=arc-20160816; b=qtVJV6g5DO6KOtzCSGznMz1RNaBTv/S/WZNOGdxg6t0oTNag2hm4eGkrSOvBma7ZVg JoshD7ra0kA2QsCgKETFIRpgIhqnVPTDHBPEWShsXUzwjXUnseVLQkPuF65TsUW4qb7s P3JZUCKmZ9uay7e7Swgr1WVQd9UKmk8KgFa5FAY2weU37nFBV8+NYWh4aZ1F8v1nM6i0 j5kl5E4vsEDyRiGlx76h1MsaWNjAsWFTWl6qpsSWIL8mbYSmfymm1Jo1nKo6uecbhjNx wih3RptJswTaP4xGl64ZTK+exfXzKpGbr4FWQwJysXZwJeeA25NBfeEeUsRd7JsU2gHo UN+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PrudHiZR6GfzIYI8RxKDH9OYsQk0yfft4ngzmg3xldE=; fh=5poR/WQaWnAX1m0QR6s1YWM5SNiSWfvf+yTtGCMXoJ4=; b=tlZSEQfZgl6w4Aj3vdAb+LfiO27okYvdgAapgVJfqbwoC/pfTz1hxmHNEh+23/kjqW nUisJNFrwtFKga55TyOtk78Vw5unxT9USK3fxX9WPOg2cHDtveRbFMO4eLUOijt6iOVQ WNTOJtW7ws5b7zHE3rixT8mZtDKsm7nbm1NdCssAf4Ove5ViO1U+g4qAxODnYsLzuwZF 8OxuvOvfgs2oLCINFQvWK96c5kUJapS7QxqPO/w9caohtb80e4J0Qlb3vbPOdXh/o5Io l1vzyUmKl4FJgQxCalnREODulNUX7PbtXJ0zLMLfLmJnKtFJQG/pEbkG/m7Wfaj/Wua4 DysQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqcITCWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id q20-20020a170902f35400b001b9c1821f6bsi1087919ple.98.2023.10.03.03.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 03:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kqcITCWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2AF16802373B; Tue, 3 Oct 2023 03:29:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231623AbjJCK3b (ORCPT + 99 others); Tue, 3 Oct 2023 06:29:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbjJCK3a (ORCPT ); Tue, 3 Oct 2023 06:29:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4343A3 for ; Tue, 3 Oct 2023 03:29:27 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E11BC433C8; Tue, 3 Oct 2023 10:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696328967; bh=jXuGOUwI1yvSy2BEPDdzmf9cHXPyEcMQXrsWAPM3Lpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kqcITCWlLywDa065bvePch/EM+Fhc9kRn1Pf1zpPvsI7zEZCyqPb/tzWRbuJF52/S GpnKjE+wRVeGLEE3+29+yE10Hp0MGoCH3PQjW+l4ZWJUJyxeKHCzfitf4LXHOLRkVb GAmvZunFsFc/Z6UoAyJJOiyKX7DfZOk2/q1k5bzhXUPw3j2l4WHusRyEH1VgM9lRXp zvDdzD1Cy+4UBtGbrNvXC8SupHfACPgAOlhjljMEnQXHWTCVLVmHc0E7y304VTCgMl leZc6zYGsJhmVUJUErh5QAziKVNzws+LryHGeTbuSoaUNhocFYW9X2vGZbfah6Fsqs YZRRngcUmIkTQ== Date: Tue, 3 Oct 2023 12:29:22 +0200 From: Simon Horman To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Haiyang Zhang , "K . Y . Srinivasan" , Wei Liu , Dexuan Cui , linux-hyperv@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH] hyperv: rndis_filter needs to select NLS Message-ID: References: <20230930023234.1903-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230930023234.1903-1-rdunlap@infradead.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 03:29:39 -0700 (PDT) On Fri, Sep 29, 2023 at 07:32:34PM -0700, Randy Dunlap wrote: > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! > > Fixes: 1ce09e899d28 ("hyperv: Add support for setting MAC from within guests") > Signed-off-by: Randy Dunlap Reviewed-by: Simon Horman Tested-by: Simon Horman # build-tested