Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1893305rdb; Tue, 3 Oct 2023 04:36:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnJUdBAI4g/pKLsRUMu8lKV8KLmWQrSp7/5rmKL1HOqTztBCwjFgFCc69EqytEtVYKb/k2 X-Received: by 2002:a05:6870:8585:b0:1b0:db2:189e with SMTP id f5-20020a056870858500b001b00db2189emr16799723oal.17.1696333012054; Tue, 03 Oct 2023 04:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696333012; cv=none; d=google.com; s=arc-20160816; b=Y73yJFgi/aEHznYPO2BJtRexDqC6JeS0/okfyFIAdGw6I1Jhw4wZvYTscox5Bme6nR IR2B6ZLbWtKv2fw+5XOHLMaE1+oKz+4JD9zNDMxqNEEHr/+fegDlkYccLhhmkrbzaRe4 +iC8dXgw7obqagbvrar2WZ2ydrWhKHsrhfQoY+fgP6IRNQ205Qn3uZN0SUs/ucg2D0fx dhBXWCP2jazB6cWjzfLuoMWXB/SiBm4+QKXbo6oi8sYiNzUMRHijDDHWQnYrC43NPWeC 0K3pACI82eklYJlk91dZfMMm6741zGNp912L340HVOIGOj7IbRei7qCNYuzbleVyyhSZ 0N9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z/oatvzoDEN/YOpPfqvlwG1Or3N3FIwCIdnbHO9TtIc=; fh=q2cvqy6lZeAU/ngufBOHrGmfbFkFOPaYbel3ijzgbfM=; b=QHdF/vJxDNg3UGlIO0IJXZgMeQaCUHQGCuYrkwb1Ihl0zXK9V263SvvTewbr4OpXR+ N8td3IAa2P0t2/b9OPhQUdYRlchEPw/MHYIzlk+6k+jyZ8u0vP9fJI2EbEBp23FgpYmo XpGSnaZ343ioFF2gUnC6USSMB6G/hse/Pe+iCq92F/Hb2EVxr+Pm5/c7bHPTNC3GVN6L jLgoGiQyPwDaJDyLZ7k0gIRgRQ/mf0pNYNWoIetkjhQoQCro6E1b7Z5cB207pHWXmppZ cGP1OEl0oAmvWE//te+Gh9FW2XXm2oNKoQHaq8SSNVPEta0uQHI8+JPvut/epfERhdrd x5Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="hTR/wtxg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id by17-20020a056a02059100b005859b1c086fsi1346552pgb.532.2023.10.03.04.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:36:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="hTR/wtxg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A7DA3803D029; Tue, 3 Oct 2023 04:36:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240496AbjJCLgm (ORCPT + 99 others); Tue, 3 Oct 2023 07:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240493AbjJCLgl (ORCPT ); Tue, 3 Oct 2023 07:36:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E48B1A7 for ; Tue, 3 Oct 2023 04:36:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55C18C433C8; Tue, 3 Oct 2023 11:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696332997; bh=EOAx/Sls7moMrznZ9XdCubZYS0GeC4469Z6iTVQkG5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hTR/wtxgPnnv4AkPLphIGAtsECUWlhwWMSdwuyYIMpOqWTZIl53yxziqz7gmjoH9Y own6UBMKcIUYzONnRgwHodskvkx0qYnK62qwSKHVYpv8jlin0Ew1+7rw3BCo96XUCG FSzq2/6osEjrlnpIVpViibYxo5xuvVVYNh2lxFwoci9BF2fGUVux9Qvo/VpiBbZDO7 m3q/jyXLWVNpeEklgVl7SRmQXY8bwhvh+YFOi7Lm637RaMFsca2Cj0iP3mCGcJuPzw n8jnh14xm4KdKPjr+qAwboSEFshe5jou/z/gj8H8PntmOU4UbiKm8amAdTIvAg/+W0 Cva8UlIRXxbrw== Date: Tue, 3 Oct 2023 13:36:33 +0200 From: Simon Horman To: Moshe Shemesh Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Jiri Pirko , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] devlink: Hold devlink lock on health reporter dump get Message-ID: References: <1696173580-222744-1-git-send-email-moshe@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1696173580-222744-1-git-send-email-moshe@nvidia.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 04:36:49 -0700 (PDT) On Sun, Oct 01, 2023 at 06:19:40PM +0300, Moshe Shemesh wrote: > Devlink health dump get callback should take devlink lock as any other > devlink callback. Add devlink lock to the callback and to any call for > devlink_health_do_dump(). > > As devlink lock is added to any callback of dump, the reporter dump_lock > is now redundant and can be removed. > > Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex") > Signed-off-by: Moshe Shemesh > Reviewed-by: Jiri Pirko Reviewed-by: Simon Horman