Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1894931rdb; Tue, 3 Oct 2023 04:40:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJ2jmfjZR9JUieVGjAhMhw3ngmx6s9QzlGt3E9LtYgKHyukqlsD78kqYusirDGmjCCS6w+ X-Received: by 2002:a05:6a00:1952:b0:693:3cbc:3d8e with SMTP id s18-20020a056a00195200b006933cbc3d8emr16218351pfk.0.1696333220765; Tue, 03 Oct 2023 04:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696333220; cv=none; d=google.com; s=arc-20160816; b=JFgY1ykJzZ6RdwfVKkUsV4hkscgkQG8RnJgAaB5MWgDINM5rXo0Duv3LS5fXcn3t6/ SvxqZnJXtuxdPwuWRIHt1YCHypzD+rVKJJ0rO3M0Ha9YFmr/uY36C2HhyPwnG2s8brfY 3jcJdGybdkdtNMerNenjyRoDzM+i9rQViC/5xDxdXo5pxpn1bjQ+gCKjjzkMATkW5wWh oGOA0kg044PoGlKDPpoe2I6vBz6/JFjuJ6NwRzYO1fO9rSoUtca4J9wH+P4085FWpZpd XjtuyxbWRJL81wvNi0W8nthrQ+rnnbiRUOXTwwIAZ98advyMbpM4BLNwhlpe4f14B8JX YAjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0hVrByY9OZMwSDVH4NovQCWUi18feulbnZSSWENahGo=; fh=Xt0aBfyVh9axe9QHpexiOxFd9j6V+hmNR5jUP51DdZE=; b=nRkeJA11iaW8IdcQoIHsxGU68zQYLGGh8vH5gatNSr6gf5BoRidtgcU+TLO5iWu0rI e1IMVT0o1stfJy8XXPYR1p6eGtWwAgk3FOP0D1m7YH3JiSNm+NeKhaE/n8huUM0LtKmX DQLUeMXxeBdIlcwEqXzXupXB2V6FT+sB/UEnVijFtU+BcxpgrknWU9BPCUY7Qd4FgHQf qmRgNG4g/Ez2bJLBH6fjC2QGwKH4r8zRyls+A1+OE5Q7wrMCym/PzhgSqOGhMIg+QbS9 qstY8aMTds8IAWPRngzpSMDTa2H3pPONxeSPemUy1rLhBC61ZWlwgLLmMrkR9jogbe9B PHPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hSVvXxhn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id j2-20020a056a00174200b0068fe0125a33si1312763pfc.37.2023.10.03.04.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hSVvXxhn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C66378031131; Tue, 3 Oct 2023 04:40:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240604AbjJCLkM (ORCPT + 99 others); Tue, 3 Oct 2023 07:40:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240621AbjJCLkK (ORCPT ); Tue, 3 Oct 2023 07:40:10 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ADA2DD for ; Tue, 3 Oct 2023 04:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0hVrByY9OZMwSDVH4NovQCWUi18feulbnZSSWENahGo=; b=hSVvXxhnluuBkQzvcowECzcZFw tYY0dT4IQ7hyJCFF4qhBYq3cYI2yhXvGfhlBkxAdxO6RWGgStz33lCrIT5N/eWO1+gANcwuxROBhs OuBiGuhXxWcToFjgeCs/oUNPU/FCAcnQl2I0lIaiD1L10SqCS7ZjwxZkLMM5E36hGOgSwWJmrkKxF 39IxjbYKBloEF9hcCDCQuCS7ESqNcx453xtfd1mbehjMkLwXeiNSDgUsd6Oogc0Qej6k7Regmjy9d YzHs0ftfUxyqY4Axkr94WYVfciIe4QtfZXRDeA4oRGwapuKy2jVBW+wMZeNgJ6KcJsf4D6v83yFBX PmNROhpw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qndkv-00EmKj-A6; Tue, 03 Oct 2023 11:40:01 +0000 Date: Tue, 3 Oct 2023 12:40:01 +0100 From: Matthew Wilcox To: Juntong Deng Cc: akpm@linux-foundation.org, vbabka@suse.cz, lstoakes@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzbot+e295147e14b474e4ad70@syzkaller.appspotmail.com Subject: Re: [PATCH] pagevec: Add remaining space check before adding folio to batch. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 04:40:17 -0700 (PDT) On Tue, Oct 03, 2023 at 05:18:52PM +0800, Juntong Deng wrote: > Currently there is no check for remaining space before adding folio to > batch, which means that folios can still be added via folio_batch_add() > when the batch is full and cause errors. No. This is an ntfs3 error. It corrupted the stack. You can't fix this in pagevec. Ignore all syzbot treports that involve ntfs3.