Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 3 Oct 2023 18:14:35 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     quic_narepall@quicinc.com, bmasney@redhat.com,
        krzysztof.kozlowski+dt@linaro.org, quic_nitirawa@quicinc.com,
        vireshk@kernel.org, quic_asutoshd@quicinc.com,
        quic_bhaskarv@quicinc.com, avri.altman@wdc.com,
        krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
        robh+dt@kernel.org, quic_cang@quicinc.com,
        quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
        jejb@linux.ibm.com, cw00.choi@samsung.com, andersson@kernel.org,
        bvanassche@acm.org, conor+dt@kernel.org, kyungmin.park@samsung.com,
        martin.petersen@oracle.com, nm@ti.com,
        linux-kernel@vger.kernel.org, quic_richardp@quicinc.com,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-scsi@vger.kernel.org, myungjoo.ham@samsung.com,
        konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
        sboyd@kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: ufs: common: add OPP table
Message-ID: <20231003124435.GA44736@thinkpad>
References: <20231003111232.42663-1-manivannan.sadhasivam@linaro.org>
 <20231003111232.42663-2-manivannan.sadhasivam@linaro.org>
 <169633539510.282606.1450427416869008072.robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <169633539510.282606.1450427416869008072.robh@kernel.org>
Precedence: bulk

On Tue, Oct 03, 2023 at 07:16:35AM -0500, Rob Herring wrote:
> 
> On Tue, 03 Oct 2023 16:42:27 +0530, Manivannan Sadhasivam wrote:
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > 
> > Except scaling UFS and bus clocks, it's necessary to scale also the
> > voltages of regulators or power domain performance state levels.  Adding
> > Operating Performance Points table allows to adjust power domain
> > performance state, depending on the UFS clock speed.
> > 
> > OPPv2 deprecates previous property limited to clock scaling:
> > freq-table-hz.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> >  .../devicetree/bindings/ufs/ufs-common.yaml   | 36 ++++++++++++++++---
> >  1 file changed, 32 insertions(+), 4 deletions(-)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/ufs/ufs-common.yaml:90:20: [error] string value is redundantly quoted with any quotes (quoted-strings)
> ./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:26: [error] string value is redundantly quoted with any quotes (quoted-strings)
> ./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:36: [error] string value is redundantly quoted with any quotes (quoted-strings)
> 

Oops! I ran the check on wrong binding file :/ Will fix it in next version.

- Mani

> dtschema/dtc warnings/errors:
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003111232.42663-2-manivannan.sadhasivam@linaro.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

-- 
மணிவண்ணன் சதாசிவம்