Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <1e5bb09f-be36-4fc6-88f3-8f6565b6147f@xs4all.nl>
Date:   Tue, 3 Oct 2023 15:23:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] media: nuvoton: npcm-video: Fix sleeping in atomic
 context
Content-Language: en-US
To:     Marvin Lin <milkfafa@gmail.com>, mchehab@kernel.org
Cc:     dan.carpenter@linaro.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
        avifishman70@gmail.com, tmaimon77@gmail.com, kwliu@nuvoton.com,
        kflin@nuvoton.com
References: <20231003075512.2081141-1-milkfafa@gmail.com>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
In-Reply-To: <20231003075512.2081141-1-milkfafa@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/3/23 09:55, Marvin Lin wrote:
> Fix sleeping in atomic context warnings reported by the Smatch static
> analysis tool. Use GFP_ATOMIC instead of GFP_KERNEL in atomic context.
> 
> Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Marvin Lin <milkfafa@gmail.com>
> ---
>  drivers/media/platform/nuvoton/npcm-video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c
> index ac8d73b794d3..5d160978f7b3 100644
> --- a/drivers/media/platform/nuvoton/npcm-video.c
> +++ b/drivers/media/platform/nuvoton/npcm-video.c
> @@ -412,7 +412,7 @@ static unsigned int npcm_video_add_rect(struct npcm_video *video,
>  	struct rect_list *list = NULL;
>  	struct v4l2_rect *r;
>  
> -	list = kzalloc(sizeof(*list), GFP_KERNEL);
> +	list = kzalloc(sizeof(*list), GFP_ATOMIC);
>  	if (!list)
>  		return 0;
>  
> @@ -467,7 +467,7 @@ static struct rect_list *npcm_video_new_rect(struct npcm_video *video,
>  	struct rect_list *list = NULL;
>  	struct v4l2_rect *r;
>  
> -	list = kzalloc(sizeof(*list), GFP_KERNEL);
> +	list = kzalloc(sizeof(*list), GFP_ATOMIC);
>  	if (!list)
>  		return NULL;
>  

I'm not really sure this is the right approach.

Looking closer at the code I notice that npcm_video_irq is a threaded
interrupt handler, so wouldn't it be easier to change the video->lock
spinlock to a mutex?

Regards,

	Hans