Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1959599rdb; Tue, 3 Oct 2023 06:29:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEce3Asg1NbNAWKUq+z3HbVy5ZABj9IQ6FOJO/OK9BNp07mWLC9z9t2ORFM23IyrZJzaxfe X-Received: by 2002:a17:902:d482:b0:1c5:6f4d:d6dd with SMTP id c2-20020a170902d48200b001c56f4dd6ddmr4362796plg.24.1696339751435; Tue, 03 Oct 2023 06:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696339751; cv=none; d=google.com; s=arc-20160816; b=tobc5Wi8razcKjN/T6qULd4z6Ue5VnCP0Bxz2ELyfJs/fZxSQ6oCllsjthKkK9t+H+ rS6oerLBHz1956SlVzikjnrZz9pCA6YxYVEy+1Ae76faCybYD+rQTtTvJh+h0Pd0TnBr wDF0JS51twaH3EalI9uTsiaezvKAy3OKDn1MMvybqEXHEtZh8wEunivUUrsHjnlgZmlf UovWwsbp0otFT5xcQ4npt8TbryP+u20PFEdXACWCih8K9wsMzwfA2zhOmXJGXngCQ5wV hEZSwM3SzE5+OVRewbebkhUUQI98NSFyn0HawXnVcbAjzqIRHTekuOvuFmWmCTTFp8Vp hywA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/uiAPxzivbvklVvEMsr/PZLKFkIm3OL+L594z8zbVQQ=; fh=Mj4AFyAL8Ow38SSpSSlES9nUn/dcoacaIWGonGDphNI=; b=Q+D32QuzYAc56DtnkXKPtDxs3b9s3rcZWM0Y2JEhlo4x/lNC7myTs+L7g2CgVKrVb5 T1XRVTnhZpPZwfsoGterWmOSr//HeeXUisysltWICksAZb6JTGHAtDCw8n8QZGelOayc 8YYE+WUYMw9UsuLcek8/vxF6xCgcp1v/bBQs15TGNfTwEh7wSRQZgI5IGnZRlfw/8sSk jt6/rSwGoDf8J5tgIgPzs2uCLJJ6KAf4Ss8V9rcDR/G/4dzvyOeyqTsXx08rSjwtGdG2 9HguFEn6PbCCzoLQhRog2nFzEdP8BIYuAmx/dPLqL/eo5/Jvz00A+YyTGLKZMb3ZwraU AJMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r4Zk1cff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id x7-20020a170902a38700b001c611f285aasi1378179pla.541.2023.10.03.06.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 06:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r4Zk1cff; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CB542813561C; Tue, 3 Oct 2023 06:29:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbjJCN24 (ORCPT + 99 others); Tue, 3 Oct 2023 09:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236706AbjJCN2x (ORCPT ); Tue, 3 Oct 2023 09:28:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71003B8; Tue, 3 Oct 2023 06:28:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0DF8C433C9; Tue, 3 Oct 2023 13:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696339730; bh=sehLgD2TutIYB7MxXdgHW4HKeN6+TJNSC72ZiOsgVHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r4Zk1cff/6ophzGy0aSfolPXKFijZgIqqv11DAnnz9yibMx+C7wqxLLsAKHFTqpYA MOw1AdubPL6KCRqLlHmqS3nJp4joCxL1/PTuKooki0iD2thdwD5NZdDzOGiZ6nb+JJ 3WxPCZrOSL4OwZ/XIfjngqmuUi9m8VTlc7l+QifRyJVcrXpbmjT+jwQxEdrh9GnwUs T4DWTbb0hueVUCqbNVvrbKt0PeHJIoic0bLeHmaBgrYpyX+SUzWhvmTiAzLdl8yZjO KF/3TEnqRedIPcYZE/IBOyx6MogYfefMuhGmimv9cEqEbJuc7rMmaAcWbIjse7JDQ8 f9BTOil6eOdBw== Date: Tue, 3 Oct 2023 15:28:45 +0200 From: Christian Brauner To: Wedson Almeida Filho Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Wedson Almeida Filho Subject: Re: [PATCH 00/29] const xattr tables Message-ID: <20231003-eiszapfen-bruder-d6fba9031133@brauner> References: <20230930050033.41174-1-wedsonaf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230930050033.41174-1-wedsonaf@gmail.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 06:29:08 -0700 (PDT) On Sat, Sep 30, 2023 at 02:00:04AM -0300, Wedson Almeida Filho wrote: > From: Wedson Almeida Filho > > The 's_xattr' field of 'struct super_block' currently requires a mutable > table of 'struct xattr_handler' entries (although each handler itself is > const). However, no code in vfs actually modifies the tables. > > So this series changes the type of 's_xattr' to allow const tables, and > modifies existing file system to move their tables to .rodata. This is > desirable because these tables contain entries with function pointers in > them; moving them to .rodata makes it considerably less likely to be > modified accidentally or maliciously at runtime. Fine by me and good idea. On vacation this week but I'll wait for individual fs maintainers to ack their portions anyway and then pick up next week.