Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1967723rdb; Tue, 3 Oct 2023 06:42:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmeicLCAzGyFvxcB205BKOr7v6zTNcCWU9M+ULkbeFnSOAf75Ky31AVu/GG3+o6KC1HgiL X-Received: by 2002:a05:6808:1484:b0:3a7:b011:8960 with SMTP id e4-20020a056808148400b003a7b0118960mr18809000oiw.40.1696340552721; Tue, 03 Oct 2023 06:42:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696340552; cv=none; d=google.com; s=arc-20160816; b=BXDBPfPU0MFiSVo4+5quLeqbTaeXz9lOUkctkayJBTlGXeW4swuOqjzjAy+deHVUfn +arlodubWl1YRtr7GYOmGBJ73N6UOGMhqveadT0TdT7kNaxgcb6SNIhAMlydvVdapZc0 n8A8Xah3bgD8HUxil8IwR7dFZ0FCVF4gJ4g2mEk/Jl3ejQUHHdIn3iTxGj7aAl0IfjAj QSmrL87RHU8iIe0xzD1FuMRujH2qJN8pJfB/qHxD0ncNQa6+ei/W/EmUYEjFZ41UcofO U6FBjFdCLEsDXsob073hgjjeAiI7r3LvbMFcBWEQzi2clf2xEGra+vSoXN6JriARBHqJ RYLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vjxV79AAwu6JUF/iD4MsylbZJ9GDyIN6CQjVVDFhUvk=; fh=SnlEc+Ohu6sixkHiE0/zBgvzGepCZ0x2INHGR68H2EY=; b=aCGZdEAZsoOPqJ7v1jBdezUZ0JpRt+xkNCUIalbbjA4bn59BHBwVA9kNDNAhVz3hGp NkdzMUX1TbM84+6tqXFpfM8L6faQUrHqlcc2DnwFh4kHx7NTYpCEEH87lZttIKgZHSxv ZAV2CaDY+f78KiAf2sCp/+gXp719MymgsynzbfJk+SUhHnDFdm6kwiBIVlrEjtfnOR0O fouuwvV5BcEbHkHYJPabcRBCNmuYpaKXQAG099Fb8HGD/Yv1GxPSrWIDPBoB8L7QwUlp FxYQDiYC2BMVm9Nceb8sR87CqIAxBbmYIhKLwOkhDSX40qpSLeYNkILA7/oZA+VYQIjh 1nTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=grYxISXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id g2-20020a636b02000000b005777b0c8f59si1420389pgc.478.2023.10.03.06.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 06:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=grYxISXl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 85879812E352; Tue, 3 Oct 2023 06:42:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236301AbjJCNmX (ORCPT + 99 others); Tue, 3 Oct 2023 09:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbjJCNmW (ORCPT ); Tue, 3 Oct 2023 09:42:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F92EA9 for ; Tue, 3 Oct 2023 06:42:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68F7AC433C7; Tue, 3 Oct 2023 13:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696340539; bh=HvH1Q1z92W9hdqkCNnVvSV1dvkn66o/wVbN4IpbbyWo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=grYxISXlNYov8M8r0twN1gillga5LQqMIC24ujlJP/o8k/u0/3PpkWscYWy4n4AEK PsK3V+Cd46gw2XaSa9kOWFdHRop1w9xqBpaSBSQ5V1aZ8BGeX//N48ROpmy4mm7ic5 0qM0lbJoGLqG5je2PqIQRNaXeuUOd36yALjX5obugnCRK+U3xU9DwZA1StdtEtC3US SegqiqX/LaBsRtxX68KlsDlKrRkSRKFhBwOvTI5oqDCYLe/ISNZrzrmMJxbp9k+94F jVwurMYMNfLAzBAjr6bD8nGpsYiUj9RAkSs/LuDIF7mZAHwwqMfwAENFh0D3lEESpj lQ5IY7xOndrOA== Date: Tue, 3 Oct 2023 06:42:13 -0700 From: Jakub Kicinski To: Lukasz Majewski Cc: Vladimir Oltean , Andrew Lunn , Woojung Huh , Tristram.Ha@microchip.com, Eric Dumazet , davem@davemloft.net, Oleksij Rempel , Florian Fainelli , Paolo Abeni , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading for KSZ9477 Message-ID: <20231003064213.4886626f@kernel.org> In-Reply-To: <20231003145106.3cd5a19f@wsk> References: <20230922133108.2090612-1-lukma@denx.de> <20230926225401.bganxwmtrgkiz2di@skbuf> <20230928124127.379115e6@wsk> <20231003095832.4bec4c72@wsk> <20231003104410.dhngn3vvdfdcurga@skbuf> <20231003145106.3cd5a19f@wsk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 06:42:30 -0700 (PDT) On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote: > I've just noticed that there is a WARNING: > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.2090612-6-lukma@denx.de/ > > but then on the newest kernel checkpatch.pl is silent: > ./scripts/checkpatch.pl > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch total: 0 > errors, 0 warnings, 0 checks, 277 lines checked > > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has no > obvious style problems and is ready for submission. > > Does the checkpatch for patchwork differs in any way from mainline? We run: checkpatch with --strict --max-line-length=80 https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/checkpatch.sh The "multiple new lines" warning on patch 2 looks legit, no?