Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20230930050033.41174-1-wedsonaf@gmail.com> <20230930050033.41174-6-wedsonaf@gmail.com>
 <20231002112858.GK13697@twin.jikos.cz> <20231002113752.GL13697@twin.jikos.cz>
In-Reply-To: <20231002113752.GL13697@twin.jikos.cz>
From:   Wedson Almeida Filho <wedsonaf@gmail.com>
Date:   Tue, 3 Oct 2023 10:48:14 -0300
Message-ID: <CANeycqpE1R=6f_9GZKTx+D4LBdkc496wcXrHOTHAKcdkssMi9Q@mail.gmail.com>
Subject: Re: [PATCH 05/29] btrfs: move btrfs_xattr_handlers to .rodata
To:     dsterba@suse.cz
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 2 Oct 2023 at 08:44, David Sterba <dsterba@suse.cz> wrote:
>
> On Mon, Oct 02, 2023 at 01:28:58PM +0200, David Sterba wrote:
> > On Sat, Sep 30, 2023 at 02:00:09AM -0300, Wedson Almeida Filho wrote:
> > > From: Wedson Almeida Filho <walmeida@microsoft.com>
> > >
> > > This makes it harder for accidental or malicious changes to
> > > btrfs_xattr_handlers at runtime.
> > >
> > > Cc: Chris Mason <clm@fb.com>
> > > Cc: Josef Bacik <josef@toxicpanda.com>
> > > Cc: David Sterba <dsterba@suse.com>
> > > Cc: linux-btrfs@vger.kernel.org
> > > Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> >
> > With slightly updated changelog added to misc-next, thanks.
>
> Removed again. I did not notice first that this is part of a larger
> series, please also CC the [PATCH 0/N] patch.

Sorry for the confusion, I will CC you there too.

> There's a warning:
>
> fs/btrfs/super.c: In function =E2=80=98btrfs_fill_super=E2=80=99:
> fs/btrfs/super.c:1107:21: warning: assignment discards =E2=80=98const=E2=
=80=99 qualifier from pointer target type [-Wdiscarded-qualifiers]
>  1107 |         sb->s_xattr =3D btrfs_xattr_handlers;
>       |                     ^
>
> but the patch changing the type is present in the series.
>
> Please update the changelog of btrfs patch with:
>
>     Add const specifier also to the pointed array members of
>     btrfs_xattr_handlers.  This moves the whole structure to the .rodata
>     section which makes it harder for accidental or malicious changes to
>     btrfs_xattr_handlers at runtime.

Will do. Thanks!

> or use it for others patches too.