Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Tue, 3 Oct 2023 21:56:31 +0800
From:   Yi Sun <yi.sun@intel.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
CC:     <kirill.shutemov@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <heng.su@intel.com>, <yi.sun@linux.intel.com>,
        Dongcheng Yan <dongcheng.yan@intel.com>
Subject: Re: [PATCH v3] x86/tdx: Dump TDX version During the TD Bootup
Message-ID: <ZRwdj9mZz+Qt5FPP@ysun46-mobl.ccr.corp.intel.com>
References: <20230930161110.3251107-1-yi.sun@intel.com>
 <483ee0eb-cc14-44a4-9c3b-77a6d0860359@linux.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
In-Reply-To: <483ee0eb-cc14-44a4-9c3b-77a6d0860359@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTlPeVZuUWZkWU51YXAyYUdpTTQxMnRVVUFjb3JKNURHakg1UlNKTVhncmVh?=
 =?utf-8?B?dGRleXFlVUNDc3owa0hLRnk5LzFhMlo1TitkSVM0Z3RNakxveWE2dFdPeUhZ?=
 =?utf-8?B?SlB2MGZRUHRySkRkNXFpMm9JZUVCdmNnV1VXQ3QxaTdWbnV3ZTdFT2dtcWRI?=
 =?utf-8?B?WXNHVi9od0tVS3RzTWprWW96VkphUUJTNzJOa05QUnpXeTZyOWNZcGRjSUlI?=
 =?utf-8?B?a29LL004dVRKdFg3bE9DV3lFZ0RVUnFPWVlweVlYaENrbjEwY1V1dkpkTGVL?=
 =?utf-8?B?SGRialBsMXJtVTBWNlFrN1g4NXA5UVFqYVEvUE4xbVV4MkgzeXlCb3R1VXl1?=
 =?utf-8?B?OFJ4cGZWNEhVNFRIUXk0amo1V01QRHpHam93SHVKcVpUb3hkbHFUTmtLUnda?=
 =?utf-8?B?TDVKbHR3N0c4ZUk5V010Z29WZ09sc0FzTVNRWEFYTmhqZnZ1SFFQVTVXTUVF?=
 =?utf-8?B?RDhCdGgwQVhyT3lXbWpYeTRKcDFVNCtuSGpaWFdBY25ndmZQVTlwOE5EWEdQ?=
 =?utf-8?B?Z1JMSVZPY3Z3US9oMmVqLzZDeGRMTFFrMnhUZWdkM0JrQWlwNmdxUkdraVV6?=
 =?utf-8?B?OWVFZG91M0VGVGNPdXh3MGtQdFN5U0NHWkNCbWYyWkRDa0FYejhaZFlPeUJq?=
 =?utf-8?B?c3B0SGcrMDdVSEc0WFlnVWJJSE95SEdGckdpdlNzb3JYaFpwYm1ibDc2RFNZ?=
 =?utf-8?B?ZnoxKzlqODd4Rk1ONmFZRmRaVDJZV2VLVG51V2F2UHBtRTh1MktkN2ZSMlgv?=
 =?utf-8?B?MDBsY0pNUDFKdHR3d2I5dTR2ckt3NFAydlBlYzVEUUEyYTBSSFZYOVNhekVx?=
 =?utf-8?B?ZlpBS09LVjlQYm4rSmNmcDRaREZ1MWRIaFBENlZuNU5kK3BtcnZSRmo3WDRx?=
 =?utf-8?B?Y3NXOE5hZmJPTDhsWmowZTM5UHVtN040TEYyOWxrcXNNTThyUnNjUXFNNUZ2?=
 =?utf-8?B?K1BrelZsMk9TU3kzNWZSYkgzalViWHdpa0lWcDVvVGhBdmZKM1h3Y3pUakZX?=
 =?utf-8?B?bjlZejBUMVpGRUdJTG5Ndzh0OU1ONzBIeVlOU3dGRGNJeUxMMU5rbFB3enJn?=
 =?utf-8?B?cC9SVlg5WExkeXZ6S3VPZ3FoMHFlQU5Gb09hWWxuV1lGalZLZG5sT2NwakRh?=
 =?utf-8?B?NGpQSkFhTGhpd0JSeUJxblFsOFBLeFlGRVJveDdwN1ZjTk1nRVN0Ym1pc3BQ?=
 =?utf-8?B?d3NpQ3V2eG5vNHc0S3RHcnBMUFE2RXAveG5hY1A1UUVvVlRSY0ZRNEhvYTVN?=
 =?utf-8?B?SFRMaXFBTnQxUTRKVUdrNVpxdGt2bkU2NmhmQUh4bmE3b1RGN3hIRXlIVTVx?=
 =?utf-8?B?Rjk3NmIybFBCc0hCTUhkckFUbkM2K01vU2huMkFScE5oN09PSXhFbE0yUHRS?=
 =?utf-8?B?NGlFdld2NW0zTWE2b2N1YWlmeXdOZkNrNmMvYmRDKzNWdmxnQWJBSXpjb0wv?=
 =?utf-8?B?a21rSUYwaWYvWHArUnNJTTZjRnpGd1UzU3g3WnVCU1Mza2w0RmNzQXB5Vkdu?=
 =?utf-8?B?YkNGU09sVFhVTXBNTzZYa0lMNldpV0trU2Q4bWF3bktyaFp4K25uM0dXRXJE?=
 =?utf-8?B?UW00MTNKZFhEZE5LSmhxa1ZtdHY1RGZPampPRHZ1TG45QzdFVmxuTjJDQnhF?=
 =?utf-8?B?L3VvR2I4TkFid2IwbUluZzVoNkMwbjduamorV1FveFVkam9WQWF5YXdoUDEw?=
 =?utf-8?B?a0QyUFZadGJTT29kaFFQWjlFeEV2WnhSSUptdWo3WWoyYWJuYmRuTGgxYUQ3?=
 =?utf-8?B?M3ZqdWVJa2pjVmJEOFA5ZWoyOCt6MFBYWVA2OUdTaC9sSUM0MUF0QW1Lb204?=
 =?utf-8?B?OWhsKysrNVhJOHY1ZFBNYnBlb0ZzR0llMDd0Nm91eUp2eWlzYUFPWEFFa1dK?=
 =?utf-8?B?OWE3V0tJN0hLQTJKQkdsMEg1WUEzWHp0QndoUVU4QmFqbVp4alBwU3owcjJy?=
 =?utf-8?B?T3F0cXYxL3JvZDhjRlNRanNueTNsQXdEN0p6UjJkWERkTUw5UUtCQkt2d0xS?=
 =?utf-8?B?bk9oQUYvVU1JMFcyRUJsai9JNG44dkRFd2l5WEJ4eEozcHRMb0hkRUVnL0ps?=
 =?utf-8?B?TGlyYmZ5b1N0d1dlcVI2ZmZydjVoUmdrWVBySXVkYzNoNUlmdU9uU3pyKzA0?=
 =?utf-8?Q?IlCAtTNPOCg/sdayZfNlymi5Z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8c510a1-3785-40a6-812c-08dbc4189389
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3094.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 13:56:43.9631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XT4BFbkjWw+8ZOlHb3uIL5uFuau3lguLVyIpVha9FNdTS3u62bftIsjclawmgNgvyMvNQXeLFPLgjXZUny1eYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7058
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 06:57:06 -0700 (PDT)

On 03.10.2023 06:26, Kuppuswamy Sathyanarayanan wrote:
>
>
>On 9/30/2023 9:11 AM, Yi Sun wrote:
>> +static int tdg_get_sysinfo(struct tdg_sys_info *td_sys)
>> +{
>> +	struct tdx_module_output out;
>> +	u64 ret;
>> +
>> +	if (!td_sys)
>> +		return -EINVAL;
>> +
>> +	ret = __tdx_module_call(TDX_SYS_RD, 0, TDX_SYS_VENDOR_ID_FID, 0, 0,
>> +				&out);
>> +	if (TDCALL_RETURN_CODE(ret) == TDCALL_INVALID_OPERAND)
>> +		goto version_1_0;
>> +	else if (ret)
>> +		return ret;
>
>For this failure case, do you want to reset tdg_sys_info to some value like zero
>or some constants to specify unknown?
Yes, that would be better for this case.

>> +
>> +	td_sys->vendor_id = (u32)out.r8;
>> +
>> +	ret = __tdx_module_call(TDX_SYS_RD, 0, TDX_SYS_MAJOR_FID, 0, 0, &out);
>> +	if (ret)
>> +		return ret;
>> +
>> +	td_sys->major_version = (u16)out.r8;
>> +
>> +	ret = __tdx_module_call(TDX_SYS_RD, 0, TDX_SYS_MINOR_FID, 0, 0, &out);
>> +	if (ret)
>> +		return ret;
>> +
>> +	td_sys->minor_version = (u16)out.r8;
>> +
>> +	return 0;
>> +
>> +	/* TDX 1.0 does not have the TDCALL TDG.SYS.RD */
>> +version_1_0:
>> +	td_sys->vendor_id = TDX_VENDOR_INTEL;
>> +	td_sys->major_version = 1;
>> +	td_sys->minor_version = 0;
>> +
>> +	return 0;
>> +}
>> +
>>  void __init tdx_early_init(void)
>>  {
>>  	u64 cc_mask;
>>  	u32 eax, sig[3];
>> +	struct tdg_sys_info td_sys_info;
>>
>>  	cpuid_count(TDX_CPUID_LEAF_ID, 0, &eax, &sig[0], &sig[2],  &sig[1]);
>>
>> @@ -820,5 +882,9 @@ void __init tdx_early_init(void)
>>  	 */
>>  	x86_cpuinit.parallel_bringup = false;
>>
>> -	pr_info("Guest detected\n");
>> +	tdg_get_sysinfo(&td_sys_info);
>
>Why not check the return value before dumping the info?
>
I overlooked that. I will add it in the next version.
Thanks Sathya for your comments.

Thanks
      --Yi Sun