Date: Tue, 13 Nov 2007 20:39:23 -0800
From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Greg KH <greg@kroah.com>
Cc: Gabriel C <nix.or.die@googlemail.com>,
       Alan Stern <stern@rowland.harvard.edu>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       bk@suse.de, khali@linux-fr.org
Subject: Re: 2.6.24-rc2-mm1
Message-ID: <20071114043923.GK6089@one-eyed-alien.net>
Mail-Followup-To: Greg KH <greg@kroah.com>,
	Gabriel C <nix.or.die@googlemail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, bk@suse.de, khali@linux-fr.org
References: <473A678C.2020507@googlemail.com> <20071114034924.GA26048@kroah.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="wIc/V6YLA2QdyfT4"
Content-Disposition: inline
In-Reply-To: <20071114034924.GA26048@kroah.com>
User-Agent: Mutt/1.4.2.3i
Organization: One Eyed Alien Networks
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2058
Lines: 63


--wIc/V6YLA2QdyfT4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 13, 2007 at 07:49:24PM -0800, Greg KH wrote:
>=20
> Matt, are these the errors you were worried about with the patch we were
> just talking about tha tis in my tree?

I can't tell from these logs.

The key question (in relation to the allow_restart patch) is this:  Was
everything working fine until a START_STOP was sent to the device?

The SCSI layers used to send devices START_STOP to almost every device as
part of initialization.  I think we switched all of that to use
TEST_UNIT_READY instead.

The patch you've got should re-enable START_STOP to be sent.  The SCSI
layers (I'm told, but haven't verified myself) only send START_STOP if the
device reports that it needs a startup command.

CONFIG_USB_STORAGE_DEBUG will generate a *lot* of debug output.  But, it
should be pretty easy to see if START_STOP was sent at all, and if it
caused the problems.

Matt

P.S. Worst case, the issue we're talking about here would only cause the
device firmware to crash, which would eventually lead to a disconnect.
That shouldn't have caused the much more severe problems shown in the log
you sent.

--=20
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
net=20
Maintainer, Linux USB Mass Storage Driver

DP: And judging from the scores, Stef has the sma... =20
T:  LET'S NOT GO THERE!
					-- Dust Puppy and Tanya
User Friendly, 12/11/1997

--wIc/V6YLA2QdyfT4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFHOnv7HL9iwnUZqnkRAtobAKCei6IOdRUhI+raOAxlH0J0+uCwkgCfS70a
x0BIH8kdm6sMKVVCoec8V/s=
=ZvFb
-----END PGP SIGNATURE-----

--wIc/V6YLA2QdyfT4--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/