Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 3 Oct 2023 16:15:30 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Woojung Huh <woojung.huh@microchip.com>,
        Tristram.Ha@microchip.com, Eric Dumazet <edumazet@google.com>,
        davem@davemloft.net, Oleksij Rempel <o.rempel@pengutronix.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 net-next 0/5] net: dsa: hsr: Enable HSR HW offloading
 for KSZ9477
Message-ID: <20231003161530.462dcc48@wsk>
In-Reply-To: <20231003064213.4886626f@kernel.org>
References: <20230922133108.2090612-1-lukma@denx.de>
        <20230926225401.bganxwmtrgkiz2di@skbuf>
        <20230928124127.379115e6@wsk>
        <20231003095832.4bec4c72@wsk>
        <20231003104410.dhngn3vvdfdcurga@skbuf>
        <20231003145106.3cd5a19f@wsk>
        <20231003064213.4886626f@kernel.org>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/IeG0tTzUv6tXyyNoPLD0IVo";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/IeG0tTzUv6tXyyNoPLD0IVo
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Tue, 3 Oct 2023 06:42:13 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Tue, 3 Oct 2023 14:51:06 +0200 Lukasz Majewski wrote:
> > I've just noticed that there is a WARNING:
> > https://patchwork.kernel.org/project/netdevbpf/patch/20230922133108.209=
0612-6-lukma@denx.de/
> >=20
> > but then on the newest kernel checkpatch.pl is silent:
> > ./scripts/checkpatch.pl
> > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch
> > total: 0 errors, 0 warnings, 0 checks, 277 lines checked
> >=20
> > 0005-net-dsa-microchip-Enable-HSR-offloading-for-KSZ9477.patch has
> > no obvious style problems and is ready for submission.
> >=20
> > Does the checkpatch for patchwork differs in any way from mainline?
> > =20
>=20
> We run:
>=20
> checkpatch with --strict --max-line-length=3D80
>=20
> https://github.com/kuba-moo/nipa/blob/master/tests/patch/checkpatch/check=
patch.sh
>=20
> The "multiple new lines" warning on patch 2 looks legit, no?

Indeed - the:

'--strict --max-line-length=3D80'

makes the difference...

If I may ask - why it is added? Or to ask in other way - why the
"vanila" checkpatch is not enough for net-dev ?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/IeG0tTzUv6tXyyNoPLD0IVo
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmUcIgIACgkQAR8vZIA0
zr1GBQf+PWCSC3QPDpwiT/dpPM+kFxaZl8GAWNdgvEejq+wdA93HBZEqbo31Wvc8
rFrUWCmBnC4WcReobj+knb+4kNAPxfMMwGkRq71skHnma2dDIwJuWVDLQt2LOpKd
BL967/ail9sVJDKqB3bbrWiXn4UWgnn/vYdJKTE4D1zQlVnQS6+1S6cZrEMuGE+q
FRab5bN4/SSGEIOGcrgo7jD6XcV75sGRi1ZaQw/kDF7/Ioc4hhxxDxo3aLQV7t3Q
6Wu2FjiUjzlM2wqhx73bbyMjBUoq3CQ6szDTZHMiUzJ/weUOpdRgZkawy46xX/9n
B7cRSahymM/X3jK80qwZOI+fbpncnQ==
=UMin
-----END PGP SIGNATURE-----

--Sig_/IeG0tTzUv6tXyyNoPLD0IVo--