Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2010754rdb; Tue, 3 Oct 2023 07:49:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJ5KQiGGJw4cTO/KTmWXieKTgI71VlkblpmvPfTwyKe89SQDsTcaMz3L7f9tAmQ6YcmLtU X-Received: by 2002:a05:6358:e49f:b0:139:d6cf:c430 with SMTP id by31-20020a056358e49f00b00139d6cfc430mr16952949rwb.6.1696344556005; Tue, 03 Oct 2023 07:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696344555; cv=none; d=google.com; s=arc-20160816; b=po//l1e80RvgXYH095rc+GfTwVi8itdtatJf41yrgR6Ac9TNfoxYd9+lqYO8Lfcq+r hB9c14gwk0KAN/ZUUcM1qRG3P3+j+3VSHrTtOj//tkh91+FXTqBzlBunpplSEIVuwBh3 mhVakgXeQf/hl0H51qg4CLIJgITnxOiznyJV8bzr75MkIoxy1bK+A54vqbmU1s/R3zSf mRmAo/WygApBclQDO61upLA3kXCDgN3dk1oG/UM8J7dE16/yua3PjKysHoKZUk083YOR f9FkSRxLUrNJhZbrvMJHBfhViUCQ5JWa4uEsLSfO2rHCEIjapr5vVsiz1zWDpqPfpeHV 0VYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F9ih/CryIbsiNzwCLHkZ+R2zLTlMJF+FK/fzOav6Alw=; fh=f28uYkRLrehdZ6YpiMgg+heBtIodVu+XAkag0xD1mzw=; b=VYKWOiKH+Qe5MoUUU5XC1BaJbpgKFpoM9+vVO/a5ntAJijMR+nIbeAHa6G9Sdkqxyr +Sut/Pf3wtRYUuBLUp9stnfFuc6GIUsdXnt1bOuwHtCpefRkCDXpcvbApAMT4eoxjCa4 ItqO/cnVGvBtFJpfwcgzYLuLHCNP6SlbCbZj1hpv8Gnnr18ipI8SN1DZ06N+OodCweyX v027UFkItCRN2oQBi95BGxcQaz+4aGKbBlpY8PKqdPT+umHFKRY+O/D1sdmpwW+pM7WU vdVm/yDYV7g78XwZ3yytLFkZanHgoEgS9koGZqB3kluZlztG/VLVov/MPHw0CKXFNw3Q +W7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UMzh7wm2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w184-20020a6382c1000000b00573f7ef60aesi1585865pgd.154.2023.10.03.07.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 07:49:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UMzh7wm2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2C4BC810451D; Tue, 3 Oct 2023 07:49:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240164AbjJCOtO (ORCPT + 99 others); Tue, 3 Oct 2023 10:49:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjJCOtL (ORCPT ); Tue, 3 Oct 2023 10:49:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 566D8AB; Tue, 3 Oct 2023 07:49:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3FFFC433C9; Tue, 3 Oct 2023 14:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696344548; bh=+Ho8OQ8KZ6j0Fkyejtlca4SZ/HaEVS5nu63V95Lo0rI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UMzh7wm26I2LcyNKyLn7E8AH/ScySYJlF/+3NbK5vxyPNFU95Rc2ft3ztJx4TfCi3 JTITHfZlsgaWWp+E7ofLc22kb5lqz46HY/zVgcHQJhXgAc5A3UQn6FkIGX7k45fStM 0CeIj8c6YGqSd+nGTc+a6RnRjVJyzXBviZaLj/sHWKx90qbK5mijPPXj3DMIxE1jTP fkJQ6FBOqDuyrahb5K42N+1nbSEn801FFA2ZeyfJrXv6Z+801QVpo5VIk2HbmBLQrc DCLV+QfJO9SiGC1weVHeeQWfQ3N12ofo2sxJgJjZOE2GxWuwcl+pdY7h5TvYfYmKY9 SrYxhPhTjjphw== Date: Tue, 3 Oct 2023 10:49:06 -0400 From: Sasha Levin To: Richard Fitzgerald Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com Subject: Re: [PATCH 6.5] ASoC: cs35l56: Call pm_runtime_dont_use_autosuspend() Message-ID: References: <20231002125059.4091982-1-rf@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20231002125059.4091982-1-rf@opensource.cirrus.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 07:49:15 -0700 (PDT) On Mon, Oct 02, 2023 at 01:50:59PM +0100, Richard Fitzgerald wrote: >commit ec03804552e9a723569e14d2512f36a8e70dc640 upstream > >Driver remove() must call pm_runtime_dont_use_autosuspend(). > >Drivers that call pm_runtime_use_autosuspend() must disable >it in driver remove(). Unfortunately until recently this was >only mentioned in 1 line in a 900+ line document so most >people hadn't noticed this. It has only recently been added >to the kerneldoc of pm_runtime_use_autosuspend(). > >Backport note: This is the same change as the upstream >commit but the cs35l56->base.dev argument in the upstream >code is cs35l56->dev in older releases. Queued up, thanks! -- Thanks, Sasha