Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <356b5866-792c-4c93-a2ce-01f15de49c01@oracle.com>
Date:   Tue, 3 Oct 2023 09:54:25 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 16/29] jfs: move jfs_xattr_handlers to .rodata
Content-Language: en-US
To:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>,
        jfs-discussion@lists.sourceforge.net
References: <20230930050033.41174-1-wedsonaf@gmail.com>
 <20230930050033.41174-17-wedsonaf@gmail.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20230930050033.41174-17-wedsonaf@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnBRVHZlQnFVRUcwR09xQ3BnTS93VHdmcUxHdm1WM0JVWTNQT1d3L29yZHE2?=
 =?utf-8?B?LzVERmdVZnF0R2FxUWJRb1ArSkpmRzBrNkNRcGtjQVZQdWJ3YW41bDlFQUdS?=
 =?utf-8?B?OTAvd3lFYVR4ZCsvbGF1NkxZV00rWnhsWGl5TWVuZ3VJTnZlL3k5Rk9TNFlZ?=
 =?utf-8?B?ajdJZnA3MlFJeUxWQnpYTk8xVDZuUm83WE9HQnEvaXFFWDRPT2tuRkxIWGZJ?=
 =?utf-8?B?dmJZVWZaL0lSb29hUERidTI3M0VVYjhYZEI2aWlkbjdZTVN3TG93YWFhdit2?=
 =?utf-8?B?S1hkMnFybmdLNG5uS3J4RGNPZXpSQjhVVXFKRTVrd0c2eEk3bXRPM283RTB3?=
 =?utf-8?B?K3Q2MWpBTmdjZzRKM1NZLzZNZFJmL1hzckR0Z2ZaVEtpdWp2WmlndngwV29l?=
 =?utf-8?B?QUVWUXgzWTQxdVdBdjZvWmlybmcwMWtoeEErMCt5a2xaTURubCtCYmUyRGc5?=
 =?utf-8?B?OC8rakRuSklmelAyNEp4WmpmbWhVZHZvQVEvbko0NjJpMFhGS0dUejdvaHN5?=
 =?utf-8?B?YmNFNDk2azU2ckQ5Vzk0UnVJaWFheGp3YzYyRkNTSGVEZDdzKy82S25TL21y?=
 =?utf-8?B?TjRwWENMVk04UGhaYW4wUXpUUUMxa0JSQk9RT0hMbW5GWEpPWmJIY29kQkwz?=
 =?utf-8?B?SDBFVlpBcXJsNFFLYmFhQ0ZlZnJQMUROT3hiS1lLT2JaejdmWDd6Qjk2NXNY?=
 =?utf-8?B?d24ySkNRYUpodHF1VDE1UGV4Q3BMelhJK3JMWUNaQnhkUGNta2pCU3h1TThI?=
 =?utf-8?B?M0IrdXJ6Z3ZTSXFhVTVpVklJL0VYNy9WMURNcWwyR2M4eXlMa3hldWVhTldx?=
 =?utf-8?B?QVhuYUpjcGFQbHJGWDE5VjlpQUNla21VaWVCTS82OEoxVHU4MEtmbWdnVHR4?=
 =?utf-8?B?OTkrNGVuaG9VQW4xdW9qVEZYdVB4bml2M3ZZM3pTUm5aOHNQR0NlenZ3QVNh?=
 =?utf-8?B?SGlmM3ZjVUFvZU5jV1JWanZWL1E1US9XckxtNENBT2FieFNwNVNiRDdIMHk1?=
 =?utf-8?B?bkVFcG9obDBGZ3Nwd2ZiaTh0L2VOblpiRHdxVE9WT3ZHOXpmODFGdzFNM3Ey?=
 =?utf-8?B?ckVDelRNZnJyMDNTSXlldXBmR0RBYldtNDgyN3dUNmtxZ3ZJM05lNjFHOXg4?=
 =?utf-8?B?V1I3K1plbUdXQnc4T3Y0YkxIbjBvZVJYQldPZlhTR3hXc1l1OHgwdUZoaVF5?=
 =?utf-8?B?ZC8rK0dLZDAwck9rZFhUMTdjYWY3bkQ3TDFQVS9mZ1VhdmhqN2xYRkhLVUlm?=
 =?utf-8?B?eFk3eVpBZzZyczhyZXZDTm9PTXhibGlOSEdxUFRwaW95bjhWWWxyc3k3cFNC?=
 =?utf-8?B?c3BGQkl2QUdyR3pRVkZpQjVydUt3SVRpRGF2ckdmRzlSai9wNUlpMFlrUWUr?=
 =?utf-8?B?OTRnMVIyZWZrNTVzN3N6bVZJMnR0elRzNnEwcHg3RXZqSVc2aWZ0bG9nWXIr?=
 =?utf-8?B?NmVzQ3VtdVROekErV09TSGhrNUFuU1V3Y1NQaDIrYVBPWnNTeXhVUGVva2tl?=
 =?utf-8?B?R0h6MTRET2lSM3ZEamZ0b0JvWVNLMGpDUGlxYXJzVFc0Uml0N1doRllCdFNG?=
 =?utf-8?B?SURHWldDVS96VnRldmpJaUxYNWJGaFZjamVteFkzb0FwWlBIV0JjQ3lpSkd1?=
 =?utf-8?B?bitPNTdPakt6MnUwa2MyQ2JpNVZKR0ZWSUdRaG5LcU5pQmRLc0ZQeUg2eXNT?=
 =?utf-8?B?bGY5cGZxZDAvRWNaMTAwenl5TmNRVGxVaWRGVUM0U05RTFJGczY3M3lIQkFq?=
 =?utf-8?B?Wk5ZYnlTeTJHZmo2QW1EK2lrMnh3bUU0WDF3ZElPUG43aHhLbEI4OUFyN01z?=
 =?utf-8?B?Y0p1d1ZpQXVWcW9RaDErODdvSk51VzJNdTNDM3ZIZENOMlFhS1JHSkp0WENS?=
 =?utf-8?B?RHJ3S09HQnQ4THlvbG9BdGo4VjBlZktzdTFzSWZFSDBneVVILzdrcEk2RDl1?=
 =?utf-8?B?Y2N2ZDU0WFJwZ0JhczZQSEFIcm4vQXNsTVpXWGJpY04vTGVPeXZmYjJPZmxr?=
 =?utf-8?B?YTk0cFFYMEdXWXlqa3NJZE5WcWpscXhPV1RmQjRPTkJDcVZCN3JtWFZCL3Bs?=
 =?utf-8?B?aWZkRHJvSlJYTEhoMzFYcGFIWkdRcmJGT1lxUG83WkZVK1haam1ZQmVaTTlR?=
 =?utf-8?B?R2YzWk9EN3hTK1p2bS96ZitwQlpER3dUV29HZlByUEJNb2RTQUIya3poVWUw?=
 =?utf-8?B?TUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?a0JyTTE3bWwvazVIdmRNbWZRQjFCamNZUlNhZzVwVTBUdkxnbGFtRXlNZGVm?=
 =?utf-8?B?Tk0zZlVmSFNTOUUrVmZ5R202UGJyRkRvdHo4QVZYUkNsZjI5by9qZHg4SGZ0?=
 =?utf-8?B?bFFMN2U0S3N4czM2WjNaK1lLemdvck5mWFZKbWtwV1I0S1NLT052YmEvbzYv?=
 =?utf-8?B?Um9vSm13ZnQ3K2pjRlIxOFMxa01oMTJHSjNsQ1Ztbk5GL0JSRXB3RFZHck9v?=
 =?utf-8?B?VGFRa2xlTzJieVpQbzZFUVB1cTUvOEpLQnBwUktCZEE4YXhrZ21EVGc4TExu?=
 =?utf-8?B?ZWlveCt0eXM4eVlhQkpqMmVxTnFCdXlTRlhLRFRDYktrcXphOTFzcHA5WHJr?=
 =?utf-8?B?dTJtMk0veWJJaUNONEJqMVJpbktZdHJ0bDdWbFdaRTF4U0M2MTIxcEEzdFMz?=
 =?utf-8?B?KzJOc3ZXTDk3VlN2NlZuY2ZoWnlHYTdZRkFRd2xSUmE0bFh6ZmhpaEhsY1h5?=
 =?utf-8?B?ZXpKdHRDbnhlOXI3M0s5bkJPMjNjaHhJdDdpeHlJdW4xUXRDYjQrTldRL2FQ?=
 =?utf-8?B?WVRiVG9zRTMxV1JKUjRVZkxJbGNRVTVFUmQyRHRhdlo0b29tQnBFVURCMmVR?=
 =?utf-8?B?QTF1alNNLzBsdUIvaU5LUVpraE1KVDdjdXF5UkJXUmdnWGRuV0wzelpPbUNG?=
 =?utf-8?B?dVErZXdSd01JbjBmcllIMjdEL2xXN3pCSTMybGRlWFJ0Q25mUk1PSnM1ZnpR?=
 =?utf-8?B?MzlJUE4ySXoyNFVvL1BJQjBmNGhLeXdRckJtYlVJcUtWNHpHdlg5YjZnQVBC?=
 =?utf-8?B?d1U5S1VWclY3WHlmaytiY1ZPT1lUQmNxL3MwWlIxTFFYZHlwS0ZSQUk4UE1K?=
 =?utf-8?B?SzRqeWJRVmxWNlZ0UXk5K2dJczJWSzUxQUxoeHBRT3AzOHhrOW9ueEpBMXl0?=
 =?utf-8?B?Z3YrL00zN2hJZFRWTE9hcmllYVVyY1d2U0UxU2hBVkRYLzRDczhlUWdmVXEr?=
 =?utf-8?B?T29OdEUxWHI5Z2k1MklVMkZUZDJwQVU2d2RHbGlucU5xd1FmaCt1QVU4US9s?=
 =?utf-8?B?VU9OVFpiVjRmUkFWZ2hhcUprZTJJM29LazFwMERaVXBtMzFFRWpLQkREbVRQ?=
 =?utf-8?B?Yjd6YjNTWEZKVDhQOHVhb2tXeXBqb3R3b3EyTGc5MHpUOE85NVpxamhDRHV6?=
 =?utf-8?B?TnR5Z3p6bVB6YkROblI1YWNqMDVzUC9VdWZuM0thTHpkWU1HT2M2TjAvS2RQ?=
 =?utf-8?B?MDNieFhWMUVFWUJ3dWRIL21sZmlZYVRDUmhoRng1cjkrZ3orNUJsUnJPb2xt?=
 =?utf-8?B?R0M5NjR3WVFtT2JOSjJtck5DSGFocm9IR3pab2lyaHczaUVXdz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b093759e-c414-4b00-a7a3-08dbc420a46a
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 14:54:28.1823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QbDKgMVlIKAb5A/acM+hv+FJu2uk0Hftsx2fCjafPg19jvt9nyMR4sEOdBCdOZnd4den9m0tCtKyNEg2FoETj8EOEm082ux5ZXJpvoGV+MA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6485
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_12,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030110
X-Proofpoint-ORIG-GUID: weG1XBmgjV6e-VBOJP8WmkZCLe1ntAMS
X-Proofpoint-GUID: weG1XBmgjV6e-VBOJP8WmkZCLe1ntAMS
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 07:55:55 -0700 (PDT)

On 9/30/23 12:00AM, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
> 
> This makes it harder for accidental or malicious changes to
> jfs_xattr_handlers at runtime.
> 
> Cc: Dave Kleikamp <shaggy@kernel.org>
> Cc: jfs-discussion@lists.sourceforge.net
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

Reviewed-by: Dave Kleikamp <dave.kleikamp@oracle.com>

> ---
>   fs/jfs/jfs_xattr.h | 2 +-
>   fs/jfs/xattr.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_xattr.h b/fs/jfs/jfs_xattr.h
> index 0d33816d251d..ec67d8554d2c 100644
> --- a/fs/jfs/jfs_xattr.h
> +++ b/fs/jfs/jfs_xattr.h
> @@ -46,7 +46,7 @@ extern int __jfs_setxattr(tid_t, struct inode *, const char *, const void *,
>   extern ssize_t __jfs_getxattr(struct inode *, const char *, void *, size_t);
>   extern ssize_t jfs_listxattr(struct dentry *, char *, size_t);
>   
> -extern const struct xattr_handler *jfs_xattr_handlers[];
> +extern const struct xattr_handler * const jfs_xattr_handlers[];
>   
>   #ifdef CONFIG_JFS_SECURITY
>   extern int jfs_init_security(tid_t, struct inode *, struct inode *,
> diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
> index 931e50018f88..001c900a2b4d 100644
> --- a/fs/jfs/xattr.c
> +++ b/fs/jfs/xattr.c
> @@ -985,7 +985,7 @@ static const struct xattr_handler jfs_trusted_xattr_handler = {
>   	.set = jfs_xattr_set,
>   };
>   
> -const struct xattr_handler *jfs_xattr_handlers[] = {
> +const struct xattr_handler * const jfs_xattr_handlers[] = {
>   	&jfs_os2_xattr_handler,
>   	&jfs_user_xattr_handler,
>   	&jfs_security_xattr_handler,