Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <93aa2ee6-3ee4-0129-7160-d3684ba67f56@linux.dev>
Date:   Tue, 3 Oct 2023 22:55:50 +0800
MIME-Version: 1.0
Subject: Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it
 child
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org,
        kernel test robot <oliver.sang@intel.com>
References: <20230803050317.2240948-1-yajun.deng@linux.dev>
 <ZRvkM1lxsTrHb2Ox@gmail.com>
From:   Yajun Deng <yajun.deng@linux.dev>
In-Reply-To: <ZRvkM1lxsTrHb2Ox@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/10/3 17:51, Ingo Molnar wrote:
> * Yajun Deng <yajun.deng@linux.dev> wrote:
>
>> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
>> it should not place out of RT_GROUP_SCHED, move back to RT_GROUP_SCHED
>> and rename it child.
>>
>> Init child when parent isn't NULL in init_tg_rt_entry().
>>
>> Introduce for_each_sched_rt_entity_reverse() to iterate rt_se from
>> top to down.
>>
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>> Closes: https://lore.kernel.org/oe-lkp/202308031034.4369b15b-oliver.sang@intel.com
> Yeah, so I agree with these changes, but could you please split up this
> patch into 3 separate patches:
>
>     sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
>     sched/rt: Rename sched_rt_entity::back to sched_rt_entity::child
>     sched/rt: Introduce for_each_sched_rt_entity_reverse() & use it

Okay, This patch makes sense, it saves a few bytes. But Peter seems to 
have a different opinion.

@Peter, I think I split up this patch into 2 separate patches:

          sched/rt: Introduce for_each_sched_rt_entity_back() & use it

         sched/rt: Move sched_rt_entity::back to under the 
CONFIG_RT_GROUP_SCHED block

Comments, please...

>
> Thanks,
>
> 	Ingo