Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20230929181616.2769345-1-adrian.larumbe@collabora.com> <20230929181616.2769345-5-adrian.larumbe@collabora.com>
In-Reply-To: <20230929181616.2769345-5-adrian.larumbe@collabora.com>
From:   Rob Clark <robdclark@gmail.com>
Date:   Tue, 3 Oct 2023 08:41:49 -0700
Message-ID: <CAF6AEGuQEi8piaw60ySOqfQpjr-cvR0cw8U78=kG3UyMv-NQYg@mail.gmail.com>
Subject: Re: [PATCH v8 4/5] drm/drm_file: Add DRM obj's RSS reporting function
 for fdinfo
To:     =?UTF-8?Q?Adri=C3=A1n_Larumbe?= <adrian.larumbe@collabora.com>
Cc:     maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
        quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org,
        sean@poorly.run, marijn.suijten@somainline.org, robh@kernel.org,
        steven.price@arm.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        freedreno@lists.freedesktop.org, healych@amazon.com,
        kernel@collabora.com, tvrtko.ursulin@linux.intel.com,
        boris.brezillon@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 29, 2023 at 11:16=E2=80=AFAM Adri=C3=A1n Larumbe
<adrian.larumbe@collabora.com> wrote:
>
> Some BO's might be mapped onto physical memory chunkwise and on demand,
> like Panfrost's tiler heap. In this case, even though the
> drm_gem_shmem_object page array might already be allocated, only a very
> small fraction of the BO is currently backed by system memory, but
> drm_show_memory_stats will then proceed to add its entire virtual size to
> the file's total resident size regardless.
>
> This led to very unrealistic RSS sizes being reckoned for Panfrost, where
> said tiler heap buffer is initially allocated with a virtual size of 128
> MiB, but only a small part of it will eventually be backed by system memo=
ry
> after successive GPU page faults.
>
> Provide a new DRM object generic function that would allow drivers to
> return a more accurate RSS and purgeable sizes for their BOs.
>
> Signed-off-by: Adri=C3=A1n Larumbe <adrian.larumbe@collabora.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Steven Price <steven.price@arm.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/drm_file.c | 8 +++++---
>  include/drm/drm_gem.h      | 9 +++++++++
>  2 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 883d83bc0e3d..9a1bd8d0d785 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -930,6 +930,8 @@ void drm_show_memory_stats(struct drm_printer *p, str=
uct drm_file *file)
>         spin_lock(&file->table_lock);
>         idr_for_each_entry (&file->object_idr, obj, id) {
>                 enum drm_gem_object_status s =3D 0;
> +               size_t add_size =3D (obj->funcs && obj->funcs->rss) ?
> +                       obj->funcs->rss(obj) : obj->size;
>
>                 if (obj->funcs && obj->funcs->status) {
>                         s =3D obj->funcs->status(obj);
> @@ -944,7 +946,7 @@ void drm_show_memory_stats(struct drm_printer *p, str=
uct drm_file *file)
>                 }
>
>                 if (s & DRM_GEM_OBJECT_RESIDENT) {
> -                       status.resident +=3D obj->size;
> +                       status.resident +=3D add_size;
>                 } else {
>                         /* If already purged or not yet backed by pages, =
don't
>                          * count it as purgeable:
> @@ -953,14 +955,14 @@ void drm_show_memory_stats(struct drm_printer *p, s=
truct drm_file *file)
>                 }
>
>                 if (!dma_resv_test_signaled(obj->resv, dma_resv_usage_rw(=
true))) {
> -                       status.active +=3D obj->size;
> +                       status.active +=3D add_size;
>
>                         /* If still active, don't count as purgeable: */
>                         s &=3D ~DRM_GEM_OBJECT_PURGEABLE;
>                 }
>
>                 if (s & DRM_GEM_OBJECT_PURGEABLE)
> -                       status.purgeable +=3D obj->size;
> +                       status.purgeable +=3D add_size;
>         }
>         spin_unlock(&file->table_lock);
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index bc9f6aa2f3fe..16364487fde9 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -208,6 +208,15 @@ struct drm_gem_object_funcs {
>          */
>         enum drm_gem_object_status (*status)(struct drm_gem_object *obj);
>
> +       /**
> +        * @rss:
> +        *
> +        * Return resident size of the object in physical memory.
> +        *
> +        * Called by drm_show_memory_stats().
> +        */
> +       size_t (*rss)(struct drm_gem_object *obj);
> +
>         /**
>          * @vm_ops:
>          *
> --
> 2.42.0
>