Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <dee25d93-28a0-40ee-9ab8-f86c89428dbd@linaro.org>
Date:   Tue, 3 Oct 2023 16:57:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/5] mfd: qcom-spmi-pmic: fix revid implementation
Content-Language: en-US
To:     Johan Hovold <johan+linaro@kernel.org>, Lee Jones <lee@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231003152927.15000-1-johan+linaro@kernel.org>
From:   Caleb Connolly <caleb.connolly@linaro.org>
In-Reply-To: <20231003152927.15000-1-johan+linaro@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/10/2023 16:29, Johan Hovold wrote:
> The Qualcomm SPMI PMIC revid implementation is broken in multiple ways
> that can lead to resource leaks and crashes. This series reworks the
> implementation so that can be used safely.
> 
> Included is also a rename of the SPMI device lookup helper which can
> hopefully help prevent similar leaks from being reintroduced.
> 
> Johan

This is.. definitely a major improvement. Thanks for cleaning up my mess

fwiw
Acked-by: Caleb Connolly <caleb.connolly@linaro.org>
> 
> 
> Johan Hovold (5):
>   mfd: qcom-spmi-pmic: fix reference leaks in revid helper
>   mfd: qcom-spmi-pmic: fix revid implementation
>   mfd: qcom-spmi-pmic: switch to EXPORT_SYMBOL_GPL()
>   spmi: document spmi_device_from_of() refcounting
>   spmi: rename spmi device lookup helper
> 
>  drivers/mfd/qcom-spmi-pmic.c | 103 +++++++++++++++++++++++++----------
>  drivers/spmi/spmi.c          |   9 ++-
>  include/linux/spmi.h         |   2 +-
>  3 files changed, 80 insertions(+), 34 deletions(-)
> 

-- 
// Caleb (they/them)