Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <6291393a-b830-4a37-ad2a-1e23b6ec778e@amd.com>
Date:   Tue, 3 Oct 2023 11:30:54 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] PCI: Make d3cold_allowed sysfs attribute read only
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     bhelgaas@google.com, lukas@wunner.de, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
References: <20231002181025.82746-1-mario.limonciello@amd.com>
 <20231003094407.GG3208943@black.fi.intel.com>
Content-Language: en-US
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231003094407.GG3208943@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzdqeWl6Z09xelY4TUExRlpxa0Q0b2dpTnhIdUZmMXVqQUlOVk1KZWVsS1Nm?=
 =?utf-8?B?SllvRXFJL3VhVldlNHBjbzFxMzRBNis3Z3h5WElFZURpbWRiRHNyV2tHbWN0?=
 =?utf-8?B?UVpQcStTUi9HS08vYTdPMnJzS2JjcHdXUTBua2ZtZHdLWncycmpLdngvRkNL?=
 =?utf-8?B?QWlPMmVERXBkTSs5RzJwbTlSVnMwcTBRbDVVNmorTXVDZTU3NTM4b0FKTzIr?=
 =?utf-8?B?YzdJTzNqQzNFZ0IzMEJwazFBRHNJZ1RJZ2I4K0RmRDZQVW11dmJIaTBXeHNK?=
 =?utf-8?B?eGNEak83bEZzZytNOHlPakNoUVBFc0xmeDJpRkVxdUU0R2lpb0ljRTJLL2J3?=
 =?utf-8?B?Tk1GSFJkOGhHQnFJTjlHUjRzb0dkdUZwT1ZoRmhiRDRSaXNrRjh2QW9Zbkow?=
 =?utf-8?B?S2JqZ1ltNzV3ckVvNVo4RDk4T3NCQ1Yvd2NPcEpLdjNkUXhuWWNRWWhwZ3Y5?=
 =?utf-8?B?aDBmQnlwT1pySG9zWkU5c1R5cWtaTmlvbmZMRGF6c3ZralJUYm1WeUF4NjNy?=
 =?utf-8?B?L1NBQW5VNFZ6NU8yYnhRYVJtT2lpRkY3bkFoZkkxekVxSVRpV3E0MDMvOUpH?=
 =?utf-8?B?YWU4K0p5K1lsMWIxVlBRTmxBQTV6ZnF6YWVlTG9VQUFVdkIvcFA5bWVjRmM1?=
 =?utf-8?B?MFRuT01DcER6ejVtM2dyTWpmbk9KT0M2djhRNzQ2WW5HT3RDNVMyeXR4TmpG?=
 =?utf-8?B?WndvcEY3Um1za0MwcUN3SkhGSU00QTkwTHUvaGE5bEFVL01oMnNlVHpab3Yw?=
 =?utf-8?B?Z1pQelYvM3BhSm1iTHhjeERKME1GMHlNWkNEbm9KU1JrN0ZVTWhZYkpRSTRM?=
 =?utf-8?B?OUtQbzVWNzlTRWZ1M1c3U2RWemdTcUNMMmFaVjJOWGNnT0gzVGdCTHNtUjFr?=
 =?utf-8?B?NkVaNCt3ekY4SU9EWGdwUWZxeFFUaUZKaDR1ME4zSDV4U2crZXV2Wk0xYTdN?=
 =?utf-8?B?aFpOaFFuZjhjeC9sd1hrZ21lMGdGbkhNTmZsSXZxZEFKaElPSFhQUzkrdVVo?=
 =?utf-8?B?N25DUkpUQm5FRFhvN2tVbDI4Y0xqVWRyWFIzam5zeEFpNVd1OEFUNU9sYWZU?=
 =?utf-8?B?ZDc0bHlVdDVUSEN2VERHbHRJZjBGRE5CZ1V6SmlYaXdTTS9KTlZBL1NKdURH?=
 =?utf-8?B?eHhVeEI1Z21OUGZKWm9zeFpEcmV2N1J3QktUaWYvTzErQ3RmRjY5dTVjRVdT?=
 =?utf-8?B?dEN0Q2Q5WElIWnU5SnNlTDZBcEowMUJHK3ltV3d4RTdRK0ZvM2l3M0owRGhm?=
 =?utf-8?B?OS9uNnNseGZOZExxR1VFc3U4aGJmTmZTNmV6Y2ZIeldjTkZPemw4UmlrMEdj?=
 =?utf-8?B?MTlPcURIV2hjVnI4MHozQmQxMzRGcHp6MVVGbm1OZFRYRWdOUTFwTzFIWWl5?=
 =?utf-8?B?dWttajMwbDBvampmSTVMRk1WUkZlZDBsTnJrRWRGdWpRNHZpK1E3a2IvOUtt?=
 =?utf-8?B?NVVqcXlyNlZNRThVM2pLQUE4ZHNyMWxGS3paN0RWWkI5Z05tWHgxZFFEbXlR?=
 =?utf-8?B?RVB3ZDRCelVTTnFjSGgzdWhUN3RncTdrZ2hJTE5ld1JPeTROUWI3Wktyb0Ru?=
 =?utf-8?B?N0NMbWxmWDNDb2pobDN0eEJuQnhkWGFHZHlPRHdKVVdGb2QzWmR5WXlyejNs?=
 =?utf-8?B?eGhSMnlmSUl5ekliS1JzakJCdmVUN3FMM3B5ek1PUXowUVBCaU1wL3VnR0lO?=
 =?utf-8?B?aHBhdHVHYkFUNnFKYjAyYXNESkxJOXhxVy9SdHYxNlRLa004WUgzYkZNbGF3?=
 =?utf-8?B?bHhSbXIydXZOYktFb011UXRzSS9lQm1RZ0FDK09ES1dqMXlPZGM4bVA4a3Ir?=
 =?utf-8?B?TGcyajlwczFpWUpsZ1RDY3JyNlR0K0VYK3g2M2c3THhjdERzSTlWNitsaGd1?=
 =?utf-8?B?VktWM1NqejMxbW92RjR5eUZRYW5UT3Z6Ymd5Yzl6VGtnSUhTL3dkckM1QkdI?=
 =?utf-8?B?Vy93TGJrVEZraHBMc3NxRzdBYmttREgwU0JWWXJJTlYra243c2h2L3VxZVJC?=
 =?utf-8?B?TStJSkVsL2ZCMGtVZkt2dEZWR1JkT3ZhTVB5M0dSUE9LYTdaWWVDYUJLVVdE?=
 =?utf-8?B?ZjJCQ1ZhREx3SmgzNFhadW4zZ3EwU0NRMlBZdU5jNmMxTkZPYnVxK3BFcmVG?=
 =?utf-8?Q?oS15y+vhe1vrlBrpGDVJfy5Zb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adf33bfb-c77e-47d8-1cc4-08dbc42e1e9c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 16:30:56.5748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G2FFvN0Kk/wpVRtDZQpNUmj5Qbk+klDpBMr8+sITz+qYqIWMy2Nozc94vENIWHfvn3ajEv2oxwXfpVinvd24QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5669
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 09:31:05 -0700 (PDT)

On 10/3/2023 04:44, Mika Westerberg wrote:
> On Mon, Oct 02, 2023 at 01:10:25PM -0500, Mario Limonciello wrote:
>> Before d3cold was stable userspace was allowed to influence the kernel's
>> decision of whether to enable d3cold for a device by a sysfs file
>> `d3cold_allowed`.  This potentially allows userspace to break the suspend
>> for the system.
>>
>> For debugging purposes `pci_port_pm=` can be used to control whether
>> a PCI port will go into D3cold and runtime PM can be turned off by
>> sysfs on PCI end points.
>>
>> Change the sysfs attribute to read-only and simplify the internal kernel
>> logic to avoid needing to store the userspace request.
> 
> I wonder if this ends up breaking some userspace apps? Not objecting
> though, just wanted to mention ;-)
> 
> One thing we could do is to taint the kernel or log a warning if
> userspace touches this but allow it to do so.

If we collectively decide it needs to stay RW for userspace compatbility 
then I'll respin it to keep the store call but ignore whatever is 
written, return -EINVAL and emit a pr_warn_once() that it's a no-op.