Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2079530rdb; Tue, 3 Oct 2023 09:32:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJea6Cbame5YTuBmewakzPZAm+TVQ4RS1SlmHWMg8e0mJgbj8vrm29Y6FmLuHBFCjaYp5g X-Received: by 2002:a17:902:d482:b0:1b6:a37a:65b7 with SMTP id c2-20020a170902d48200b001b6a37a65b7mr5129331plg.23.1696350775856; Tue, 03 Oct 2023 09:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696350775; cv=none; d=google.com; s=arc-20160816; b=N1FWgqMnLJTSSo1IncqBJLEIjimMwep/LcevdraQ/WTUcr+o8Rn2YOjgw4YslsEXql qnAR7402ubxBmR9ai170WWgyFsB1zI6ehkVDOPXGt+QykaslW9nOEgTYwDpa55lqKC4q r9EkN7rRYUeasntRX0nZfslmi9jhg/Jv8K4YtaHwhcIP87UgEQnc8kAQFv45EYpXsokU Hjbr2oahzm2w5e7bqS+uag/mR0Ac6UR4Fxr6ARgJ6DeKz8tTUR4IT/sStmhpx6hjWDsM V4+qEH1FM/+NWQdpeiCSVm41fHU449/hLeGwhynTgGHpbepkf05XTYjYeoooLysEvvcC GcOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4fW/bzKPL5Jt7cK4cP4XmMu57Km5yiCvbpPDO6ClLH0=; fh=WxcXzAXi1awalX5nBNdKiu2pCszhVA/a0vtqlN5we7w=; b=0QL+KXW2tO8iZvC2eS15/dySgIfrefEjlzKs1OTsnP3ytxOj0Lcd+02DH4daqeUDC1 uB5DqjeAL8e1efe7k/eDlbMvdEaVaU6DDKCOGSnV77Kf+yOAf+I1pxuWRfqYC/Sxibks PZQ7Xx+cA8JwkXFhsn06yaw/rdOyjght+HihWTe2yPgFDvR1RnkpKwWADb2nurfkqA3I nB07FZqForvtrjKuWXtJPCrSWdhc3Hl8ZiUymbjEkNPhrfDZHjr0zjzFB2q9sU61T/pH oezSTgvT2qPV0XDQfEuNjm4YQYy97uPJHi+S/q/JsCvoavGiVwxfXwtt6RWi87IWkz8s ofCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aVbvvf6N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id az1-20020a056a02004100b0056fa1bc208esi1822354pgb.722.2023.10.03.09.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 09:32:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aVbvvf6N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DB6C781A43FE; Tue, 3 Oct 2023 09:32:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240601AbjJCQcv (ORCPT + 99 others); Tue, 3 Oct 2023 12:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240572AbjJCQcm (ORCPT ); Tue, 3 Oct 2023 12:32:42 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5D24C6; Tue, 3 Oct 2023 09:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696350759; x=1727886759; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=naeM4Hr3CRD+DTUV5/XFL2W5c7Jq+1AMKWCZV/jYYy8=; b=aVbvvf6N/U1jlCgIuWZFIls13psdXA2G6Mxs5MARakSRGnvLdA9jUqDN Vp6/pAxRA6faBlwXkUe4fHSxr0Mnh7IcAndln+NMFZHW/MpAZ2IS+DhSx ACxeVlUjRh75zDvK/AA+DRGHjvqW0X1N1fBxLNKwxE4zpJdFttWQfpktZ 0BlESStDbI5HHUJOAt4nrs1RgIuc3OpCBEoB3PyddXBiVJLnOBgj0Z8tI 6iBt8U2XE1Txcse7D2CcLQjgmrN6TdN/Kz3z08lr+XHXAF8BeUw72eDYD UexDHrqD+sUdp8q8zlbQ7stK7uj0J5FJnfFWcc1jk1HCYmp3j8pFrB9eE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="381799131" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="381799131" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 09:32:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="1082069924" X-IronPort-AV: E=Sophos;i="6.03,197,1694761200"; d="scan'208";a="1082069924" Received: from spandruv-desk.jf.intel.com ([10.54.75.14]) by fmsmga005.fm.intel.com with ESMTP; 03 Oct 2023 09:32:38 -0700 From: Srinivas Pandruvada To: hdegoede@redhat.com, markgross@kernel.org, ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH v2 4/4] platform/x86: intel_speed_select_if: Use devm_ioremap_resource Date: Tue, 3 Oct 2023 09:32:34 -0700 Message-Id: <20231003163234.1856669-5-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231003163234.1856669-1-srinivas.pandruvada@linux.intel.com> References: <20231003163234.1856669-1-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 09:32:55 -0700 (PDT) Replace devm_ioremap() with devm_ioremap_resource() by defining a resource. Signed-off-by: Srinivas Pandruvada Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko --- v2 New patch in the series. Moved from indepedent patch to the SST series. Updated commit log and added Reviewed-by. .../platform/x86/intel/speed_select_if/isst_if_mmio.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c b/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c index 13e068c77d50..3f4343147dad 100644 --- a/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_mmio.c @@ -94,6 +94,7 @@ static int isst_if_probe(struct pci_dev *pdev, const struct pci_device_id *ent) struct isst_if_device *punit_dev; struct isst_if_cmd_cb cb; u32 mmio_base, pcu_base; + struct resource r; u64 base_addr; int ret; @@ -118,10 +119,10 @@ static int isst_if_probe(struct pci_dev *pdev, const struct pci_device_id *ent) punit_dev->mmio_range = (struct isst_mmio_range *) ent->driver_data; - punit_dev->punit_mmio = devm_ioremap(&pdev->dev, base_addr, - punit_dev->mmio_range[1].size); - if (!punit_dev->punit_mmio) - return -ENOMEM; + r = DEFINE_RES_MEM(base_addr, punit_dev->mmio_range[1].size); + punit_dev->punit_mmio = devm_ioremap_resource(&pdev->dev, &r); + if (IS_ERR(punit_dev->punit_mmio)) + return PTR_ERR(punit_dev->punit_mmio); mutex_init(&punit_dev->mutex); pci_set_drvdata(pdev, punit_dev); -- 2.41.0