Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763097AbXKNGJy (ORCPT ); Wed, 14 Nov 2007 01:09:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757489AbXKNGJp (ORCPT ); Wed, 14 Nov 2007 01:09:45 -0500 Received: from mgw1.diku.dk ([130.225.96.91]:33305 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbXKNGJo (ORCPT ); Wed, 14 Nov 2007 01:09:44 -0500 Date: Wed, 14 Nov 2007 07:09:40 +0100 (CET) From: Julia Lawall To: "Robert P. J. Day" Cc: khali@linux-fr.org, i2c@lm-sensors.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 22 >> From: Julia Lawall >> >> Drop #include in files that also include #include >> . module.h includes moduleparam.h already. > > i'm not convinced that's a good idea. while module.h does currently > (and unfortunately) include moduleparam.h, there may come a day when > those header files are refactored to actually make sense, at which > point all those missing moduleparam.h inclusions will cause all sorts > of bad things to happen. They were removed from the drivers/media files in August: 9c12224a607a4b22ab86784e3394b52810b9507c Perhaps they should be put back there then? julia - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/