Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <8987d773-27cd-4065-9f9d-8bd8aef78100@oracle.com>
Date:   Tue, 3 Oct 2023 11:33:31 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [Jfs-discussion] [PATCH 47/87] fs/jfs: convert to new inode {a,
 m}time accessors
Content-Language: en-US
To:     Jeff Layton <jlayton@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     jfs-discussion@lists.sourceforge.net
References: <20230928110300.32891-1-jlayton@kernel.org>
 <20230928110413.33032-1-jlayton@kernel.org>
 <20230928110413.33032-46-jlayton@kernel.org>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20230928110413.33032-46-jlayton@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZStlaXMyclBMaGNRVlJvYll0bjk2enVsVzlLV05Oc3Fzd21rNURLVlROYi9V?=
 =?utf-8?B?L3NkckRsUldId2JXK2s2T1lLbnQzcVF0SEs3RGVkMGFaaGtITkZxQk1tMkJN?=
 =?utf-8?B?b0lqZ3Z6bEw5dVFzZ1dNRkd6cDJHbnNZRzVXcnBqVlJsb1Qxc0hwdGhkbklq?=
 =?utf-8?B?TW8vbjViQjZWdkh0cFJ0TGx5QTRWeTBQWkpkemZkcVJkNEZJK3FBMGtiZlZE?=
 =?utf-8?B?TENWd0RsMVVBUzByK1U4UFhRcVlUMHpGY1BRRTUvdWV1eW5aYmt3QUV3bnBN?=
 =?utf-8?B?TGxhQ3BJbnA4d2RoRHByVGVGWmE1UXMzcExGM01mZ1ZoVXFUTmJZRVgyK1JE?=
 =?utf-8?B?MXVpOHdzcW14MC80ZHZ0K1RYa1R4S2RjNkNZUm05bTJLaEZpc3NVZUFUajBy?=
 =?utf-8?B?cC9UZ3JuOFFvZmwzcHQyc0wyZVhtZEJ0SVJ4eVI0UndHUm5CREprL2s1ZkJm?=
 =?utf-8?B?SVNVMW9rekRTUGVvampZUnYrbVRlWHN4TERRT3VNcHJpdXdsSGRId2hZREpx?=
 =?utf-8?B?OHVlMXFrcEVRSGIxRURmOTlDb3hLbklsd0RwL0J2UjJhb21KWlErNHVkaFFi?=
 =?utf-8?B?eThmekVJUHAwYy9XOWhKaGR5U3JNeXJRT3FNS29Gc215djR0LzUxZTNWaERW?=
 =?utf-8?B?V1BGUG02M3NESUFhYkM5V1dmeUhxbjZvTVRwM1F3WFE5SXM1dFF5TXYxaWhj?=
 =?utf-8?B?cElyR2h5aHA3MzJDRkkvMWJDbGVVNHBmcC9SN1NJNXczc21rSW5oY0VTcEVq?=
 =?utf-8?B?TWZERXpsak43MXVieE9yNDI3d3RGZjFtK0hKZ2UyWnVqTjVna3g5S2tBU2sy?=
 =?utf-8?B?VExpeE5lRUlOUjNqWkNoR2drTFVqOFdBZTNJLytuMmFpNWlYZmFOOHU3NXd5?=
 =?utf-8?B?RG1WUlRyVlh4NGpMVy9zNEFLMVN2cmszem8vQUhMNUdvenM2RHpPaEZGbDI5?=
 =?utf-8?B?VkNhVUcwdXB5SmhJcnRTZzVuREhGcHJFdnU3Qm9FQzN0dk1HV0tTaW9Zc1Jv?=
 =?utf-8?B?UVgrb0kyVWFiOXk4SHA0RXpoT3hxTFpnZTd5Nms5MmNvTTZCU1htdUk2Wjdi?=
 =?utf-8?B?RU1TS2JiaithbnhYdlVZckpBZmtnVzBJOWJldUV6NUtrelQwV0JKWnY0eTRv?=
 =?utf-8?B?dm9ldWw1L1RRNFBDWXBDazZTRDlUZjNBbzE1RFRLK0RmYlF5MDd5ZTdXK2U1?=
 =?utf-8?B?WGdSVEJMSXdqeEZiQXNEb1E3TjNwbGhkaDEyMEx1a0VsNWhJWlFwQTBseDhC?=
 =?utf-8?B?a1psRkxhOEgzL1A5MTk4VlJkUVZwOE5hNXBXejF5NTFYMzlWd0Y5Qi9MUDY0?=
 =?utf-8?B?UnBJL2tBd2U1WUk1bm8ycTVvTW14bC9jM0VZY0xsTmJWbjc3c1MzR0xKbklh?=
 =?utf-8?B?Ni9UN0JJM2FYRER5YVQxUlV0Q2g3dVU4cEFsRjFzZ3BQMndiaDROdWxIYjB0?=
 =?utf-8?B?NUd2clFZQmxaR25qSm9LMmZKa1VGeDU1VE1RRi9RSzZ4a25udHVxSHNPY3pH?=
 =?utf-8?B?Vnl4a3hzUW1FcTVNL0pmYzUvRG9PaWw2SHZPTXF0U3VRVnRrWUZBQ3M5OUNY?=
 =?utf-8?B?WGRYVTdYUGNQVHc0SXlxd1BNaktNWXE5UzAwdC9kRTYyQTB5MERiSTRnYnlK?=
 =?utf-8?B?TElDUmN4QzFMQ3hVTEtGcTFuRVNMaUNKK1NTY1RiYUk5dWlQYzVpSWNvTENa?=
 =?utf-8?B?ZmxLZW5xWjNGbDFXM0JyT1l2ME9LLzQ2NnF2eGVjSWF4d24wZ2s4ZC9IWUd5?=
 =?utf-8?B?dkxqQ3FsMUdzTGUwdmx0SVBTdmxLMjNUOUlPcklyRHVReFNpUEJzdjZCMHNl?=
 =?utf-8?B?aWhPYlM2TXRyU3FQMEg0K0w1bzNtdEV2M3dFUWZMVHBtY0JZWlFoR3NZamF6?=
 =?utf-8?B?eEhIdUJ3LzJhUW5pckw0QVd2dXNQcEdUdWlwWFVkNzhiQ1JKSkcyVVdHU2F5?=
 =?utf-8?B?V0RkUHYxdDRROTFPQ29jYXRBQW52MkI2Z292ck5XcWxPRmE0a3M3WFpteXJV?=
 =?utf-8?B?eUJQZEFFMGl5YUxtWDM1MGZaclQxemtyVC9pK1I2RjIvUVlUOW1WcHNtUFc4?=
 =?utf-8?B?YTQ5WWlPeDJTbC9sS0ozVFBqb1k1RWZLUUxFdWQxakcyRDZUdHJCWlhLTlpU?=
 =?utf-8?B?cFlWTlo2VmlwWjkxZW5Qa2JhbzhJSkJ6NzNsWlZSbERtY2hZWDM0Q2pucHFJ?=
 =?utf-8?B?K1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: n3yK3yViaRsOd8hqYqKdunKrheKG5WhdZnpAaBKXr18aK3FvbjszeBJ54hPE2Es7pIZctOHAyuPBSinempseOwtAb5pd9PHQH1XeNijBehYDEy3aueHUhwg46IzVAffLqFrUDNoMlT6Kng8k6LSLeqY/NqsF84U5WEKY1Qg9iyNqB6cMQmm1TxBJrr/bcblGx8Aho+XR4W7dmB5rP/VYgKsly72EnqnR5yX9EYveyKrd4FlyFYfILPFaoqcBWT7uv0gIvGhe5r/lFcN8V2/vAF/mqLOW81C06oYqbSdOC0+eh9feYgLjy9M0UKQKG2a8mjDK9JCHdY0YR/KamPb2DZwqLas1pSpz3KcrMxq66vauWGWR/GZze01xx6WXLHa15H3xmb4LkWG6DCClGDywVQvaiiknf7NK77QHQB/4WoDXI8XAhCkC9xGoxa56X/+97lMGDrUJw6uPtqB+B4+jrURFjlb1vSjm3YOoRMnbKJr+megwbhjTc2D29zu01JKKB3UlKflVcJWhIRNNyRKmvlJTFIJjZljTrBrzNgsKR0hEEb4heXsygLldQS+o3OPp5YTD6de6pjTmJ7yXru5JHhzW7smhvbuH/ZlgTDq8N23SUHEFwwuq3s9lhlT95QLeme4obpRvdSd4KuiIpL195bG+ze40JYk6UU16pWbntHwn7M3a1Qi9DrnhTKy+PbavPMQMYt5CJm7biqq8YattqJR73Z7eIrEavUiBgyOQFSd8lrGOxcsxVtR0slUjbNL7OfCseDr7AnBMYjQdxOdVLQxVcaxu7/4ugJw7HWoFVt7B7zhiizNv3GpWEaA1XLnP52BV5iHsuv376oPk98q4ew1Y+6VudhJNsNQHVlprO1x0h2Ei7FrFePBX7N5ZI8yiSqH/2d8nqc7o68C/B5jExw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d43437e-ea90-41ad-0f28-08dbc42e7c5f
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 16:33:34.1004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4lDflHh2445DZqoqf5oZ/mJMZKWHPDcCZhIAJU4MS769bBxORXWPuPdEnqXrxA9OCbrWFnTkIAgt4Mjp5IAXxaxUktCo7Tm8MM+8fuT4JIs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4353
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_13,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030125
X-Proofpoint-GUID: 800qxGLq_0M9QRvGLkwhFLhhEm501LCG
X-Proofpoint-ORIG-GUID: 800qxGLq_0M9QRvGLkwhFLhhEm501LCG
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 03 Oct 2023 09:34:26 -0700 (PDT)

On 9/28/23 6:02AM, Jeff Layton via Jfs-discussion wrote:
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> ---
>   fs/jfs/inode.c     |  2 +-
>   fs/jfs/jfs_imap.c  | 16 ++++++++--------
>   fs/jfs/jfs_inode.c |  2 +-
>   fs/jfs/namei.c     | 20 +++++++++++---------
>   fs/jfs/super.c     |  2 +-
>   5 files changed, 22 insertions(+), 20 deletions(-)
> 
> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
> index 920d58a1566b..1a6b5921d17a 100644
> --- a/fs/jfs/inode.c
> +++ b/fs/jfs/inode.c
> @@ -393,7 +393,7 @@ void jfs_truncate_nolock(struct inode *ip, loff_t length)
>   			break;
>   		}
>   
> -		ip->i_mtime = inode_set_ctime_current(ip);
> +		inode_set_mtime_to_ts(ip, inode_set_ctime_current(ip));
>   		mark_inode_dirty(ip);
>   
>   		txCommit(tid, 1, &ip, 0);
> diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c
> index 923a58422c46..57852a515660 100644
> --- a/fs/jfs/jfs_imap.c
> +++ b/fs/jfs/jfs_imap.c
> @@ -3061,10 +3061,10 @@ static int copy_from_dinode(struct dinode * dip, struct inode *ip)
>   	}
>   
>   	ip->i_size = le64_to_cpu(dip->di_size);
> -	ip->i_atime.tv_sec = le32_to_cpu(dip->di_atime.tv_sec);
> -	ip->i_atime.tv_nsec = le32_to_cpu(dip->di_atime.tv_nsec);
> -	ip->i_mtime.tv_sec = le32_to_cpu(dip->di_mtime.tv_sec);
> -	ip->i_mtime.tv_nsec = le32_to_cpu(dip->di_mtime.tv_nsec);
> +	inode_set_atime(ip, le32_to_cpu(dip->di_atime.tv_sec),
> +			le32_to_cpu(dip->di_atime.tv_nsec));
> +	inode_set_mtime(ip, le32_to_cpu(dip->di_mtime.tv_sec),
> +			le32_to_cpu(dip->di_mtime.tv_nsec));
>   	inode_set_ctime(ip, le32_to_cpu(dip->di_ctime.tv_sec),
>   			le32_to_cpu(dip->di_ctime.tv_nsec));
>   	ip->i_blocks = LBLK2PBLK(ip->i_sb, le64_to_cpu(dip->di_nblocks));
> @@ -3138,12 +3138,12 @@ static void copy_to_dinode(struct dinode * dip, struct inode *ip)
>   	else /* Leave the original permissions alone */
>   		dip->di_mode = cpu_to_le32(jfs_ip->mode2);
>   
> -	dip->di_atime.tv_sec = cpu_to_le32(ip->i_atime.tv_sec);
> -	dip->di_atime.tv_nsec = cpu_to_le32(ip->i_atime.tv_nsec);
> +	dip->di_atime.tv_sec = cpu_to_le32(inode_get_atime(ip).tv_sec);
> +	dip->di_atime.tv_nsec = cpu_to_le32(inode_get_atime(ip).tv_nsec);
>   	dip->di_ctime.tv_sec = cpu_to_le32(inode_get_ctime(ip).tv_sec);
>   	dip->di_ctime.tv_nsec = cpu_to_le32(inode_get_ctime(ip).tv_nsec);
> -	dip->di_mtime.tv_sec = cpu_to_le32(ip->i_mtime.tv_sec);
> -	dip->di_mtime.tv_nsec = cpu_to_le32(ip->i_mtime.tv_nsec);
> +	dip->di_mtime.tv_sec = cpu_to_le32(inode_get_mtime(ip).tv_sec);
> +	dip->di_mtime.tv_nsec = cpu_to_le32(inode_get_mtime(ip).tv_nsec);
>   	dip->di_ixpxd = jfs_ip->ixpxd;	/* in-memory pxd's are little-endian */
>   	dip->di_acl = jfs_ip->acl;	/* as are dxd's */
>   	dip->di_ea = jfs_ip->ea;
> diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c
> index 87594efa7f7c..9137e5d96db8 100644
> --- a/fs/jfs/jfs_inode.c
> +++ b/fs/jfs/jfs_inode.c
> @@ -97,7 +97,7 @@ struct inode *ialloc(struct inode *parent, umode_t mode)
>   	jfs_inode->mode2 |= inode->i_mode;
>   
>   	inode->i_blocks = 0;
> -	inode->i_mtime = inode->i_atime = inode_set_ctime_current(inode);
> +	simple_inode_init_ts(inode);
>   	jfs_inode->otime = inode_get_ctime(inode).tv_sec;
>   	inode->i_generation = JFS_SBI(sb)->gengen++;
>   
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> index 57d7a4300210..d68a4e6ac345 100644
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -149,7 +149,7 @@ static int jfs_create(struct mnt_idmap *idmap, struct inode *dip,
>   
>   	mark_inode_dirty(ip);
>   
> -	dip->i_mtime = inode_set_ctime_current(dip);
> +	inode_set_mtime_to_ts(dip, inode_set_ctime_current(dip));
>   
>   	mark_inode_dirty(dip);
>   
> @@ -284,7 +284,7 @@ static int jfs_mkdir(struct mnt_idmap *idmap, struct inode *dip,
>   
>   	/* update parent directory inode */
>   	inc_nlink(dip);		/* for '..' from child directory */
> -	dip->i_mtime = inode_set_ctime_current(dip);
> +	inode_set_mtime_to_ts(dip, inode_set_ctime_current(dip));
>   	mark_inode_dirty(dip);
>   
>   	rc = txCommit(tid, 2, &iplist[0], 0);
> @@ -390,7 +390,7 @@ static int jfs_rmdir(struct inode *dip, struct dentry *dentry)
>   	/* update parent directory's link count corresponding
>   	 * to ".." entry of the target directory deleted
>   	 */
> -	dip->i_mtime = inode_set_ctime_current(dip);
> +	inode_set_mtime_to_ts(dip, inode_set_ctime_current(dip));
>   	inode_dec_link_count(dip);
>   
>   	/*
> @@ -512,7 +512,8 @@ static int jfs_unlink(struct inode *dip, struct dentry *dentry)
>   
>   	ASSERT(ip->i_nlink);
>   
> -	dip->i_mtime = inode_set_ctime_to_ts(dip, inode_set_ctime_current(ip));
> +	inode_set_mtime_to_ts(dip,
> +			      inode_set_ctime_to_ts(dip, inode_set_ctime_current(ip)));
>   	mark_inode_dirty(dip);
>   
>   	/* update target's inode */
> @@ -828,7 +829,7 @@ static int jfs_link(struct dentry *old_dentry,
>   	/* update object inode */
>   	inc_nlink(ip);		/* for new link */
>   	inode_set_ctime_current(ip);
> -	dir->i_mtime = inode_set_ctime_current(dir);
> +	inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir));
>   	mark_inode_dirty(dir);
>   	ihold(ip);
>   
> @@ -1028,7 +1029,7 @@ static int jfs_symlink(struct mnt_idmap *idmap, struct inode *dip,
>   
>   	mark_inode_dirty(ip);
>   
> -	dip->i_mtime = inode_set_ctime_current(dip);
> +	inode_set_mtime_to_ts(dip, inode_set_ctime_current(dip));
>   	mark_inode_dirty(dip);
>   	/*
>   	 * commit update of parent directory and link object
> @@ -1271,7 +1272,7 @@ static int jfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
>   	inode_set_ctime_current(old_ip);
>   	mark_inode_dirty(old_ip);
>   
> -	new_dir->i_mtime = inode_set_ctime_current(new_dir);
> +	inode_set_mtime_to_ts(new_dir, inode_set_ctime_current(new_dir));
>   	mark_inode_dirty(new_dir);
>   
>   	/* Build list of inodes modified by this transaction */
> @@ -1283,7 +1284,8 @@ static int jfs_rename(struct mnt_idmap *idmap, struct inode *old_dir,
>   
>   	if (old_dir != new_dir) {
>   		iplist[ipcount++] = new_dir;
> -		old_dir->i_mtime = inode_set_ctime_current(old_dir);
> +		inode_set_mtime_to_ts(old_dir,
> +				      inode_set_ctime_current(old_dir));
>   		mark_inode_dirty(old_dir);
>   	}
>   
> @@ -1416,7 +1418,7 @@ static int jfs_mknod(struct mnt_idmap *idmap, struct inode *dir,
>   
>   	mark_inode_dirty(ip);
>   
> -	dir->i_mtime = inode_set_ctime_current(dir);
> +	inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir));
>   
>   	mark_inode_dirty(dir);
>   
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 2e2f7f6d36a0..966826c394ee 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -818,7 +818,7 @@ static ssize_t jfs_quota_write(struct super_block *sb, int type,
>   	}
>   	if (inode->i_size < off+len-towrite)
>   		i_size_write(inode, off+len-towrite);
> -	inode->i_mtime = inode_set_ctime_current(inode);
> +	inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
>   	mark_inode_dirty(inode);
>   	inode_unlock(inode);
>   	return len - towrite;