Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 3 Oct 2023 18:37:19 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     Ingo Molnar <mingo@kernel.org>, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org,
        kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it
 child
Message-ID: <20231003163719.GG1539@noisy.programming.kicks-ass.net>
References: <20230803050317.2240948-1-yajun.deng@linux.dev>
 <ZRvkM1lxsTrHb2Ox@gmail.com>
 <93aa2ee6-3ee4-0129-7160-d3684ba67f56@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <93aa2ee6-3ee4-0129-7160-d3684ba67f56@linux.dev>
Precedence: bulk

On Tue, Oct 03, 2023 at 10:55:50PM +0800, Yajun Deng wrote:

> @Peter, I think I split up this patch into 2 separate patches:
> 
> ???? ??? sched/rt: Introduce for_each_sched_rt_entity_back() & use it

Why ?? Having that macro makes no sense what so ever. You can't use it,
unless you set up the back pointers first. It is not a self contained
piece of functionality.

> ??? ??? sched/rt: Move sched_rt_entity::back to under the
> CONFIG_RT_GROUP_SCHED block

This one sure.