Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230930050033.41174-1-wedsonaf@gmail.com> <20230930050033.41174-28-wedsonaf@gmail.com>
In-Reply-To: <20230930050033.41174-28-wedsonaf@gmail.com>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Tue, 3 Oct 2023 19:41:17 +0300
Message-ID: <CAOQ4uxiTZNLD5cbYWqdWe0djTSEmq+32XsU5i39Y=WAZ791oxQ@mail.gmail.com>
Subject: Re: [PATCH 27/29] overlayfs: move xattr tables to .rodata
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>,
        Miklos Szeredi <miklos@szeredi.hu>,
        linux-unionfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Sep 30, 2023 at 8:02=E2=80=AFAM Wedson Almeida Filho <wedsonaf@gmai=
l.com> wrote:
>
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>
> This makes it harder for accidental or malicious changes to
> ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime.
>
> Cc: Miklos Szeredi <miklos@szeredi.hu>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: linux-unionfs@vger.kernel.org
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>

Acked-by: Amir Goldstein <amir73il@gmail.com>

> ---
>  fs/overlayfs/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index cc8977498c48..fe7af47be621 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -477,13 +477,13 @@ static const struct xattr_handler ovl_other_xattr_h=
andler =3D {
>         .set =3D ovl_other_xattr_set,
>  };
>
> -static const struct xattr_handler *ovl_trusted_xattr_handlers[] =3D {
> +static const struct xattr_handler * const ovl_trusted_xattr_handlers[] =
=3D {
>         &ovl_own_trusted_xattr_handler,
>         &ovl_other_xattr_handler,
>         NULL
>  };
>
> -static const struct xattr_handler *ovl_user_xattr_handlers[] =3D {
> +static const struct xattr_handler * const ovl_user_xattr_handlers[] =3D =
{
>         &ovl_own_user_xattr_handler,
>         &ovl_other_xattr_handler,
>         NULL
> --
> 2.34.1
>