Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2084341rdb; Tue, 3 Oct 2023 09:41:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHMfNnsykJNCRh25TejfsJtxih7w1VYDsu/BhHoV/9VctrtkCGKc6ST9JrkCuGvqNawMRR X-Received: by 2002:a05:6e02:ee7:b0:34f:1e9c:45d5 with SMTP id j7-20020a056e020ee700b0034f1e9c45d5mr14023030ilk.32.1696351304602; Tue, 03 Oct 2023 09:41:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696351304; cv=none; d=google.com; s=arc-20160816; b=RNsLrkJEMRlJeKmwXxv8nO0SCPIGBXyIUz9tIj7uzlnskgITZgxpNoWHKJHn70VNe5 3nNky/II20LpPZ3BQ11aG+59JNrYGv2iAredTlBjY+sMYxT1Wc4jgnb0pGL+tddYgu7U beMcdZkLN15vxDf+sh4DpsO2NgrH/MCYBemjdXcnVs/k0jgnV8tpSDHvSAMFDTnoOdph pz208dYKpO726Bi+GE5/mEq1twHk5uTo357MvIsETXHTiDq2Wi30CGIDuXN3lNwHnjhI hwOmU9hAiHbaFBjmboBp/7s8icc+z6n0uIPdPBvVkkUlADjeNhOpr0tLtiTjNvhr6OWa Qb6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=GzpsBd0hl8g05el1vI3tJ2EKjd4P5v9MJSsEQR5HPI0=; fh=gout7nJwI5+QUhwAYJnCETVuV8iULN5YcWYAQIQiM8Y=; b=iVNYjee7fRMY891bk0pxwhw1xtwRTV7S2Uw0E+lW0Towxf6twFAcLN4GLNZHTrkbJc YL8qfeDldpd7/KPWaLvfXx2sAHPrPgLMbN6CFnIdEkwQhgIHtZGApYOK1vFoT77x8+rO rgXVvC//mcDfDFHCHT4no2Y824xKcQzQYheWzZ3ExKBOBCu1MPNoNEXJoGZpgBcI0HXw PlQn00QILzxwvnx+68GGawVPyEg09kJR59KPQr3r4+iSVc6PkHvWeFXm0XUtxYhXH5sT wv84+010XqOCf1Zz68C0i0ZJ+iJJ18VR6ja6+OKLp628/D1lZRfpp4O00mDwCwrwmiTS lrXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZPTDfGfI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id s132-20020a63778a000000b005859b2d8d7asi1793137pgc.4.2023.10.03.09.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 09:41:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZPTDfGfI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5DCE280BD5FA; Tue, 3 Oct 2023 09:41:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240642AbjJCQld (ORCPT + 99 others); Tue, 3 Oct 2023 12:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240678AbjJCQlc (ORCPT ); Tue, 3 Oct 2023 12:41:32 -0400 Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BB59A1; Tue, 3 Oct 2023 09:41:29 -0700 (PDT) Received: by mail-vs1-xe2f.google.com with SMTP id ada2fe7eead31-4526a936dcaso623407137.2; Tue, 03 Oct 2023 09:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696351288; x=1696956088; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GzpsBd0hl8g05el1vI3tJ2EKjd4P5v9MJSsEQR5HPI0=; b=ZPTDfGfI6wp8YH/kDLeyRQ+9AmgpfBqWXwPLm7paKNl+LHRVhyZH04iXubqFmCL1Ng 3Vs9oJdggg3r1zp5Dt4/OeA8uwcGdd8kpN4lET5nhRR1sHBhaodEXO0U1rv4SiGwlTLz 6/T/dfMuUyXb81WVVSxHzKPfmARTotoCm2BYaQCUVGD+rcbWl9Oi6yhhLULKC+gopg0c iuFdSEcKMbzoH7eEzB8SrFpYRBOJR1hW6u2ZLwGdaXbopK8uXg4HRvkuKfCQYr7I/A5l TZVwR72IXXaJrdACbekGaKSZCTpvV2K4ImsQ1pqrZWhClsC05ulImdv1xp+XLA45M+Dl CSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696351288; x=1696956088; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GzpsBd0hl8g05el1vI3tJ2EKjd4P5v9MJSsEQR5HPI0=; b=TQ4thC7Ssq7eyDhFj2h+/gZadAyU48ayDpV7GrbXTLCtn4Ptyxcvop1wXOaHfxhdfA /fm5pQWEZ5t3UXVFx09T6e/xh/MwU1N6CqK8ySwdKCeQrG3LFCIqkSymw5vwApkTDnNJ RqCC83nTPGEnyeFioeQ+pXB7/t3zpPgxPqU/JPl1gMY6fIBGQnaXdeN568xW51pCOA9+ PKp+HM7uZ0qWvZa8SQ/1BLCpRjF2BGR6I0DrXPan8VCfS6m7BHv3/QBbhIWYACoZ7fWD C4EQxZklOuWJvCUaBd3GUk3kW2dCWbLUqQXsY8rcEuuoff2H0KnYsvngHBxph/XNdGDH iwzg== X-Gm-Message-State: AOJu0Ywa7CwF4o0+rx8j8SKPKU0ttD38519O2F/t9eDGwGbejitkK995 r6JxPpMJNJQLhijnUFKsIJDs0Aa03JmYgC3AY3E= X-Received: by 2002:a05:6102:7a4:b0:452:9988:5cbd with SMTP id x4-20020a05610207a400b0045299885cbdmr13007992vsg.5.1696351288603; Tue, 03 Oct 2023 09:41:28 -0700 (PDT) MIME-Version: 1.0 References: <20230930050033.41174-1-wedsonaf@gmail.com> <20230930050033.41174-28-wedsonaf@gmail.com> In-Reply-To: <20230930050033.41174-28-wedsonaf@gmail.com> From: Amir Goldstein Date: Tue, 3 Oct 2023 19:41:17 +0300 Message-ID: Subject: Re: [PATCH 27/29] overlayfs: move xattr tables to .rodata To: Wedson Almeida Filho Cc: Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Wedson Almeida Filho , Miklos Szeredi , linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 09:41:42 -0700 (PDT) On Sat, Sep 30, 2023 at 8:02=E2=80=AFAM Wedson Almeida Filho wrote: > > From: Wedson Almeida Filho > > This makes it harder for accidental or malicious changes to > ovl_trusted_xattr_handlers or ovl_user_xattr_handlers at runtime. > > Cc: Miklos Szeredi > Cc: Amir Goldstein > Cc: linux-unionfs@vger.kernel.org > Signed-off-by: Wedson Almeida Filho Acked-by: Amir Goldstein > --- > fs/overlayfs/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c > index cc8977498c48..fe7af47be621 100644 > --- a/fs/overlayfs/super.c > +++ b/fs/overlayfs/super.c > @@ -477,13 +477,13 @@ static const struct xattr_handler ovl_other_xattr_h= andler =3D { > .set =3D ovl_other_xattr_set, > }; > > -static const struct xattr_handler *ovl_trusted_xattr_handlers[] =3D { > +static const struct xattr_handler * const ovl_trusted_xattr_handlers[] = =3D { > &ovl_own_trusted_xattr_handler, > &ovl_other_xattr_handler, > NULL > }; > > -static const struct xattr_handler *ovl_user_xattr_handlers[] =3D { > +static const struct xattr_handler * const ovl_user_xattr_handlers[] =3D = { > &ovl_own_user_xattr_handler, > &ovl_other_xattr_handler, > NULL > -- > 2.34.1 >