Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <a5e933fe-4566-9ae6-9a5d-b3a4c186fe0b@intel.com>
Date:   Tue, 3 Oct 2023 10:14:05 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH net-next] iavf: Avoid a memory allocation in
 iavf_print_link_message()
Content-Language: en-US
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
References: <966968bda15a7128a381b589329184dfea3e0548.1695471387.git.christophe.jaillet@wanadoo.fr>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <966968bda15a7128a381b589329184dfea3e0548.1695471387.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGl0NkM2MlNrOEVBQnMyZEFMOWxSUUY0RitFTWg4ZUE1ZXBmeVJDMmdlSVpq?=
 =?utf-8?B?eldJb3ZyMElCMW03UnlIUVBpT0U2ckFxQXBuVzY2cGd3UVltZkdOZTJFR25t?=
 =?utf-8?B?M0ZYZlphWUQ0UE9CV2dYWHh2UlN6Vm8yMVdXT2ZnZEkrN1pHQlNRZllvZk5Z?=
 =?utf-8?B?bThOOVhkcFlMOW9TUjNLZ2JTNHloRzlkZTBhTnV2a0RJbUVvTDU0bHcrOSts?=
 =?utf-8?B?TkVGeldOdjB4cE55U2VaY29VVGMyZHVIbkpxWUdZRUd3ZFFGbTNhc2x3cTk0?=
 =?utf-8?B?V2lKa1dLZjQ5Uk9mL2tSVGN1dzRQRnVsQzN3Q2pTUStGYU9OcVNiTFBRVkpm?=
 =?utf-8?B?eEdrUXBycGdYZGlkajE4KzRYbjM2UjFRMzVZbkVJWmtaVXluZHJUdTd5d2c2?=
 =?utf-8?B?dTJ4MHBMZS8wUFI2Skk1aXBzRldOZmh6OEZSdkdOK3ZNSk8zNXlxbXFmSVFR?=
 =?utf-8?B?ZHRyVzdINkVXdU5LdlZnQkM0MlZmb1ZkU3k4T28yQkhEOUI4TThQSUQ4VnVx?=
 =?utf-8?B?SzBZT3J0a0lhU1ZXVFEva0FZRm4zaFE5b01VdG11M3FjQitGakhKdjlLVGgz?=
 =?utf-8?B?eUNFZHRHRGJ6eEFEN0doUDBVa21PZXIvV25TKzBBUjhFYWpEWklidUh5bzVa?=
 =?utf-8?B?bVN6QnNUMDU3b25uZ3BzQ2FtRWwzTVRNeXJqV0x4OWR0ZklNVi8zYi9lTnky?=
 =?utf-8?B?clNLS1pOQzJrTytvdFFvTFVQSEJ0YnhHeVNRYXk3Q0VmcW1aZTR2UE9zSXN0?=
 =?utf-8?B?b1JNQXBvMGd4MUxXdWVrVDR3L2ltSWgxUWJ2NXhtNitpVmtZeVJMMU0wTjJm?=
 =?utf-8?B?UlQ4SG9qOUk2NnZ5TStzRmFKRmNMUGJYWFZHQkQ4aUFPUzJ0SmhWV0FPZ2cr?=
 =?utf-8?B?QlpkWEZPM2FsSVVjc0lvYVF6dXFNdk9qalR5RjA1eWdJYVQwZjNGMFNVcmht?=
 =?utf-8?B?NUp2QXhVN25vUHA5VkgxaVJvWkI2clpSSVlYYVA0YU50UjdJYWMyTDZDam1S?=
 =?utf-8?B?QXBaVkM2MXVGUDh5UlltT3FWV0JVTzRjRW9iWnhDSFdwZnVWTnZ0MmVlRXpv?=
 =?utf-8?B?MFdTU3o5V3pPTlJmemlxZHZtbUJQeHBtUlViMVM4WlBHY3lyMUU1cm1WSkFw?=
 =?utf-8?B?V3pDektFanY5dnFxVysrNnp0bWVlRGhyamlEOHlaR3QwRnhZQ3gydlBWZUVa?=
 =?utf-8?B?bERRRCtZaDRPdStWWlh1VHVCQ1ZQczJHbjZJd1dlVGF5NWFWV2U4OGVqcFRw?=
 =?utf-8?B?VU1Cd1hQcWJXTm0vVW5zbVFYL01QMXYvblM0MEpXalFSdjNxRElJc09Ec0FV?=
 =?utf-8?B?NjZxeE00YllsUGVWbVQ3a2hCekVUeVJJWWx6bE5Vd1BRTlVRMHVLZVEybEVT?=
 =?utf-8?B?T1UvRElxdXRkWnF0VHo0d0wvZlUreE51bHE0QjZCMmhiZjNHL2c2VFdsM01X?=
 =?utf-8?B?RlpaejRnbnJTVlRhMTFqSEJBTTdIWS9kU1lqQXVXWDg5TXpWOHF1aWphT2xo?=
 =?utf-8?B?MSthY0NzRk9NNWZqSDFCYURMZzFEaHI2cFNCK3BEaTBNSHBxaWk3aWhkbSs5?=
 =?utf-8?B?aklKNUtCQ1I5TlkxbVFNbk52WVpicHNCOUJmUmNTY0MvSVdYZEUvMFF6S0Z0?=
 =?utf-8?B?VFdja1NsR29GRFU1YkphZXpOTVhzNXhmQ0hLOVZVR1pMOVF3ZGc1NnFGK1g2?=
 =?utf-8?B?MW9QV1VldzR5c2ZKSFAxS1JBNm9wQy9XNkx0cjJxamp6d0NMRlExWEtIbWlq?=
 =?utf-8?B?QUNmTWZkeHFoTFFOcDFFQnduOFdvQXUrcGwrK2p3NGRKMDVTY3N5eVQ3UzNZ?=
 =?utf-8?B?d2Vsam1GRmFiZ3RuYit1c3R6a3BDb0F6K21TUS9uVEJmVWJVS0hyQUgyNDJp?=
 =?utf-8?B?ZGFsN1Uva3VBRE9ZdHorTWI3QWUvOVNYMW44dDZEMVc3dXZrQktIb255bzRT?=
 =?utf-8?B?RkJXSjNZU0dYME9aSFNNbHRNdmx5dmNWUHhoSGRkWlg1bkJUVkxKT3JnRDJn?=
 =?utf-8?B?dVM1UmpVTlliRWg4RHlmZ2xzK2tYTHFmYnExaXZkVmNzcWtxMUQ3WHZFVWEv?=
 =?utf-8?B?amU3THJVSi84dktLc2c3akZ6WDhBdVdTSWdUTGNaSFpVaGJPdmtFU3NZSTlt?=
 =?utf-8?B?YlNOQVEwbStxSjVUL2lhZjF4eTFiYzVrZUU1REtWcU1pT09IeWs5ZC9FMmVW?=
 =?utf-8?B?WHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13810e88-554a-42a4-f99c-08dbc434271f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 17:14:07.8669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3z+bYrcJGdaAl7gNv6dxY2sv4ttJvwnAocekxcBq7TFx/K2PeVewoZaAzoDuJk75q7+ko3gxmZ9Vc/bVwckDkvW2I/SElQn1zs5HyCLW/hg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6412
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 10:14:30 -0700 (PDT)

On 9/23/2023 5:17 AM, Christophe JAILLET wrote:
> IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within
> iavf_print_link_message().
> 
> 'speed' is only used with some snprintf() and netdev_info() calls.
> 
> So there is no real use to kzalloc()/free() it. Use the stack instead.
> This saves a memory allocation.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 8ce6389b5815..980dc69d7fbe 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -1389,18 +1389,14 @@ void iavf_disable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid)
>  static void iavf_print_link_message(struct iavf_adapter *adapter)
>  {
>  	struct net_device *netdev = adapter->netdev;
> +	char speed[IAVF_MAX_SPEED_STRLEN];
>  	int link_speed_mbps;
> -	char *speed;
>  
>  	if (!adapter->link_up) {
>  		netdev_info(netdev, "NIC Link is Down\n");
>  		return;
>  	}
>  
> -	speed = kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL);
> -	if (!speed)
> -		return;
> -
>  	if (ADV_LINK_SUPPORT(adapter)) {
>  		link_speed_mbps = adapter->link_speed_mbps;
>  		goto print_link_msg;
> @@ -1452,7 +1448,6 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)
>  	}
>  
>  	netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed);
> -	kfree(speed);
>  }
>  
>  /**

Hi Christophe!

I had a slightly different proposal that gets rid of all the -Wformat=2
warnings in this code by using kasprintf to handle the varying string
lengths.

any thoughts about this instead and drop yours? I'm less worried about
the "extra allocation" here in this function since it's slow path, and
the same comment applies to your patch as well.

your patch still shows these errors
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c: In function ‘iavf_virtchnl_completion’:
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1446:60: warning: ‘%s’ directive output may be truncated writing 4 bytes into a region of size between 1 and 11 [-Wformat-truncation=]
>  1446 |                 snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
>       |                                                            ^~
>  1447 |                          link_speed_mbps, "Mbps");
>       |                                           ~~~~~~
> In function ‘iavf_print_link_message’,
>     inlined from ‘iavf_virtchnl_completion’ at drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1965:4:
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c:1446:17: note: ‘snprintf’ output between 7 and 17 bytes into a destination of size 13
>  1446 |                 snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1447 |                          link_speed_mbps, "Mbps");
>       |                          ~~~~~~~~~~~~~~~~~~~~~~~~


<my iavf patch pasted as a quote so my mail client won't wrap the lines...>


> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 8ce6389b5815..82b84a93bcc8 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -1378,8 +1378,6 @@ void iavf_disable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid)
>                                   VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2);
>  }
> 
> -#define IAVF_MAX_SPEED_STRLEN  13
> -
>  /**
>   * iavf_print_link_message - print link up or down
>   * @adapter: adapter structure
> @@ -1397,10 +1395,6 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)
>                 return;
>         }
> 
> -       speed = kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL);
> -       if (!speed)
> -               return;
> -
>         if (ADV_LINK_SUPPORT(adapter)) {
>                 link_speed_mbps = adapter->link_speed_mbps;
>                 goto print_link_msg;
> @@ -1438,17 +1432,17 @@ static void iavf_print_link_message(struct iavf_adapter *adapter)
> 
>  print_link_msg:
>         if (link_speed_mbps > SPEED_1000) {
> -               if (link_speed_mbps == SPEED_2500)
> -                       snprintf(speed, IAVF_MAX_SPEED_STRLEN, "2.5 Gbps");
> -               else
> +               if (link_speed_mbps == SPEED_2500) {
> +                       speed = kasprintf(GFP_KERNEL, "%s", "2.5 Gbps");
> +               } else {
>                         /* convert to Gbps inline */
> -                       snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
> -                                link_speed_mbps / 1000, "Gbps");
> +                       speed = kasprintf(GFP_KERNEL, "%d Gbps",
> +                                         link_speed_mbps / 1000);
> +               }
>         } else if (link_speed_mbps == SPEED_UNKNOWN) {
> -               snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%s", "Unknown Mbps");
> +               speed = kasprintf(GFP_KERNEL, "%s", "Unknown Mbps");
>         } else {
> -               snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
> -                        link_speed_mbps, "Mbps");
> +               speed = kasprintf(GFP_KERNEL, "%d Mbps", link_speed_mbps);
>         }
> 
>         netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed);