Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <622b95d8-f8ad-5bd4-0145-d6aed2e3c07d@intel.com>
Date:   Tue, 3 Oct 2023 10:18:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2] arch: Reserve map_shadow_stack() syscall number for
 all architectures
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>, <linux-api@vger.kernel.org>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Ingo Molnar" <mingo@redhat.com>
CC:     Richard Henderson <richard.henderson@linaro.org>,
        Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
        Matt Turner <mattst88@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "Will Deacon" <will@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        "Michal Simek" <monstr@monstr.eu>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
        "Helge Deller" <deller@gmx.de>,
        Michael Ellerman <mpe@ellerman.id.au>,
        "Nicholas Piggin" <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        "Yoshinori Sato" <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>,
        "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
        "David S . Miller" <davem@davemloft.net>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        "Adrian Hunter" <adrian.hunter@intel.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Sergei Trofimovich <slyich@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Rohan McLure <rmclure@linux.ibm.com>,
        "Andreas Schwab" <schwab@linux-m68k.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Brian Gerst <brgerst@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Rick Edgecombe" <rick.p.edgecombe@intel.com>,
        Mark Brown <broonie@kernel.org>,
        Deepak Gupta <debug@rivosinc.com>,
        <linux-alpha@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-ia64@vger.kernel.org>, <linux-m68k@lists.linux-m68k.org>,
        <linux-mips@vger.kernel.org>, <linux-parisc@vger.kernel.org>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-s390@vger.kernel.org>,
        <linux-sh@vger.kernel.org>, <sparclinux@vger.kernel.org>,
        <linux-perf-users@vger.kernel.org>
References: <20230914185804.2000497-1-sohil.mehta@intel.com>
 <487836fc-7c9f-2662-66a4-fa5e3829cf6b@intel.com>
 <231994b0-ca11-4347-8d93-ce66fdbe3d25@app.fastmail.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <231994b0-ca11-4347-8d93-ce66fdbe3d25@app.fastmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU5ZVTZ2NFIzcXloaHRLcXhqL0FOaW5Ea0tKTWtXdDZrWE1ZcXdrMWdzRmJZ?=
 =?utf-8?B?WWtsSDdZSUE0a2FFVlVGYkY4WkZZdW5aRnY0dUxzNW1GTGFtYTUxUHRmYW83?=
 =?utf-8?B?ckVNK1FvM3h2TUxhYitQUnpNaWhhSmdCUlNmYStoWXN3TlRmQm5kUzZZekdh?=
 =?utf-8?B?Z1RTeDlmdEFjZWRQVjBjZ1ZQcGtUV3B4aGpocUhQMmpwUkg5amhkaEhSUm5Q?=
 =?utf-8?B?anFuRzFSZHlNTnFLdVpwcS9SeG01QnErbmE0blBQVjZDNVBWV2lFVnU0L3pk?=
 =?utf-8?B?YXE2bnQ3T0MrMEpUa1RacGs1bC9TSHlkdllyaWxodnVZc0twbmZaTHpxUGk2?=
 =?utf-8?B?eTZMZGRraTFpMGpZZTNzaEdUZ1V2WlRQQXlkVlo0UEI1MEVQZ0VIazFSclNZ?=
 =?utf-8?B?dEErNHdQd2NjNnkvdDV1THhWeFAwdXhUaWZhNElJNDg5ZzBmWFRmdEhsOHFZ?=
 =?utf-8?B?SFN2bTUwUUg1QW15VVJrbFNCekQ4NjVLS2t1bkVVNmw5T3R6aGxRUWFSWTR4?=
 =?utf-8?B?eXljZERmbEVjNkxxdFd6Y0Fka2xxVFpaR1QxRzFIRUFCNS92Q3FrckRFYTJD?=
 =?utf-8?B?ZXV5eGZ6SXlvQWZyNHJ5NWp4KzJnU3hERUJBSlJOQW93K3RmTFAzNEQwWURP?=
 =?utf-8?B?V3BwaWxOcjJiN1FhSlRUUjlyL284aDVQc3M0K3VIUnZqRi9aTzJNVXdkbjBt?=
 =?utf-8?B?am4wMlVsRGF0MVRJVEtVS1dqWWp1TnRXL1REMkduV1pORHh6ZXQ2NTBKZWk2?=
 =?utf-8?B?WmxCYitDWEVIc1BsWFpiai9BRHY4elMyMEIyWjVCQlJhYzRuZkZoOUlNZHlE?=
 =?utf-8?B?ZVhMSEtWU0x4ZXNsTDJJMGViL0FsVEViSzFIMTNyVXI5WDFIaWFKemhtQ0Yv?=
 =?utf-8?B?NXNnR01qWnZFNTljOG5PbzIxdVVuQXdVV0VSK0ZBeXRIZW5RVWZodE9ONERQ?=
 =?utf-8?B?OUhBYVQ1MytYZnNlN05zZXlxL0pCbzVYSlZvcCtpU29zVXBsOFozV01qbFp5?=
 =?utf-8?B?MjRiR3poVWxuWVVzeHZDRC8rN29zYW16M2VwOUZMSm9uVlFOK2d2WUw0UDFa?=
 =?utf-8?B?T0lMaEo2N05FMS8xRzlwTVNOM1lDYmc4M1JwaTBlVzR1ZVVkRnpRZkIzYlVs?=
 =?utf-8?B?VU5FQ2dLVWt0UUNHTlBmbVYyZDY3anJ4K2lrU0s0TEIvMTNzcmt6ekxIUEds?=
 =?utf-8?B?aXVaR01UNDY3Y1h6Mk5PdVk4L2hxN0VpSzhibHg2V2p6Ymc4WGUrNmxJNWkz?=
 =?utf-8?B?OWpoQlNEMmxiOG9EaWtTR0NVdDFKc0U4RGhucTRwV0k4aVVYbnUwSVRxdDBD?=
 =?utf-8?B?eTdKSUpiRysvM05GREJpVGo4dldGMCtVcUs5Y3YrUVE2TzU5NUVrWENTSXFu?=
 =?utf-8?B?WnJIZTlib2Q1NGdrbDZTZS9ibWgwYTVyTmovQ1g3R1Nid2kvazZJL2VDV09n?=
 =?utf-8?B?ZHcwclhNSnFnMjJ0QlJtMjdiNVVHMFhzdWthZVZaUy9IaFpPVXpMUWhyeG5r?=
 =?utf-8?B?NVFtckhEN2phWW5UM1ZZa0doZHUxQnJLWG4yNm9HWFAraWgxNytzalNnTy9Z?=
 =?utf-8?B?Mk1vN2pkenU1MGRZLzN4aTI2ZEd5L29xOFM0WU1Cby9yc3lVWHZva2NmQmps?=
 =?utf-8?B?eXdHeE5kV3pyMkdIZ0loK1ZNK0FHQ0VPdDJpbndvNXlNOE5hN1NEVmdCZ0lv?=
 =?utf-8?B?eHY2Uk52MEVpc2JJbTJHOVMvZVJzTk9PYXFVd2N6M3lFWENBZ0xkczd2OE5y?=
 =?utf-8?B?U3lkUEp5Uk1DbWJCSmFQRk0raHhHTGdORE9pN3NlK2pmWWJ6U0x4Q0xra083?=
 =?utf-8?B?bXBHZXg1TUZkS0o2Tnk4Qkd1Z1pwdDgwbzBONE9lTUc2TjV6aUNxRXBmMUFa?=
 =?utf-8?B?TXpuQmF5V3Y3QW92dy9Nb042TEtZS0tWT3R0aWY3V09zdWVucFBUUTZTTEN5?=
 =?utf-8?B?dEVsMlMvL2w1bE9ELzBqR1N2Yk4xNHRHK0J2ZHVyNEZTODNOTml3eE5YSld0?=
 =?utf-8?B?MTRFTk9VMFVRekh0NlI4TkVpTGwwTDhmckw4TVFuVElzbEtVK01jSEQ2dThq?=
 =?utf-8?B?YXpnaGk2dkdkdXBYcWltRVJBOVAvc2RUdzc5NzkrUnBrbzVtaE9URVJpUXpz?=
 =?utf-8?Q?95/79KBaE/pDDA5SEH/27W8TH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 529268fb-ca70-459e-dbff-08dbc434c5bd
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3313.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 17:18:36.2175
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: taVq7aiy+E/+aSodbq/4rI0f0H8z1si2jTWBMWpeD6JKJdE6PJfVFA6izhh0kD6JBh7dXsZbt8Hzz3yuFcYl+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5881
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 10:18:49 -0700 (PDT)

On 10/3/2023 9:54 AM, Arnd Bergmann wrote:
> On Tue, Oct 3, 2023, at 18:35, Sohil Mehta wrote:
>>
>> Gentle ping...
>>
>> Are there any additional comments? It applies cleanly on 6.6-rc4.
>>
>> Or does it seem ready to be merged? It has the following
>> acknowledgements until now:
>>
>> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
>>
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 

Thanks Arnd.

> If you like, I can pick this up for 6.7 through the asm-generic
> tree. If you think this should be part of 6.6, I would suggest
> to merge it through the tree that originally contained the
> syscall code.
> 

Dave, Ingo, would you prefer to take this patch through 6.6 or defer it
until 6.7?

It's not necessarily a fix but it does help finish up the shstk syscall
added with 6.6. Also, it might help reduce some merge conflicts later if
newer syscalls are being added during the 6.7 window.

Sohil