Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 3 Oct 2023 14:46:25 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     corbet@lwn.net, akpm@linux-foundation.org, willy@infradead.org,
        brauner@kernel.org, surenb@google.com, michael.christie@oracle.com,
        mjguzik@gmail.com, mathieu.desnoyers@efficios.com,
        npiggin@gmail.com, peterz@infradead.org, oliver.sang@intel.com,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 5/9] maple_tree: Update the documentation of maple tree
Message-ID: <20231003184625.lqnfmgc35o7pgeff@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, corbet@lwn.net,
        akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org,
        surenb@google.com, michael.christie@oracle.com, mjguzik@gmail.com,
        mathieu.desnoyers@efficios.com, npiggin@gmail.com,
        peterz@infradead.org, oliver.sang@intel.com,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20230925035617.84767-1-zhangpeng.00@bytedance.com>
 <20230925035617.84767-6-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230925035617.84767-6-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ma8rQCG3USQhtfKKYCNJIRAo4kvJRXqGl2A4PqM1m+/BYQiqYUKT8oM2zoC+?=
 =?us-ascii?Q?mWVmrhcSURgRx+ANceXPqAezI/YOwZt42vmGOjRzAFM9kF7MvLsVh7+ilXHG?=
 =?us-ascii?Q?Gw6Thd9ONXbRxHL5hBm8CZxZItqqTTI589sP6NV6hQ8By/uE2TX96QW34sR3?=
 =?us-ascii?Q?agxCs3g7cDQoVBnsYvY44a/0pbzrLreIhmx7I1+u5FlK6LULCMttjDe96RCQ?=
 =?us-ascii?Q?T6FADqqXYFhBfwAmzJtO23n6FkAXvxFXUNXdI8abIlgfkw8t7aJe+0jHgRlt?=
 =?us-ascii?Q?vWhika61gTYDesj2ixK9xaD/vUwKkjQxPz5uxum3HvXnC91GeNdmmZs3uGGm?=
 =?us-ascii?Q?ub40ToLa9R/bK/t8td+t1VPGTMy0UFRoLG3OqgUHuToHs/ZzpLbKs7Ke4psz?=
 =?us-ascii?Q?McPxEoHIDuAfb6uNKQVm/f2Lr5dRVyboi9oCShfkjITFx/AXrV4oLNK+AiKo?=
 =?us-ascii?Q?DDiC0OVF7xtOoeCz7MYDesG0w+Q5xzLfK6Imfgxu/E73zKVkFjolY/FYb/bi?=
 =?us-ascii?Q?CsGNVxKPXnEq5qDdZB9/c/D4SYaLpvAsDAPHHBQgq1qglG4PpG9nvuBPZDIb?=
 =?us-ascii?Q?NQliZIFCFFbT/2P8MGoyBr9O6aM+6OfMf/oo1vCZFr1hO/RKZ3gHXzixosWL?=
 =?us-ascii?Q?ZnmgrcVYWbFvf7grqwPNcwGGbj2hiPimu068xQyrCtShQDU84iCNCFa3VSBo?=
 =?us-ascii?Q?IDsFPtGq45BeqfoNVoTq+CgM6wLFSYWlLFLYai3et2d6MtgLiGDg78MYpVt3?=
 =?us-ascii?Q?2f3qEweoloStRMtPnGgUFFLb2xqgy7jNnURw/HOwJo/E7EKNh39mwPSEFd1L?=
 =?us-ascii?Q?XZVUCe7M0LFu7Vczg1guiXVxXxU7pJ8amiv8gz6GE1uTKWSN2LezTKz8nPQi?=
 =?us-ascii?Q?8s3huYPTBXbLFEuJ9EbADdCUt822LHFrhp3+Nh1EElXSOp7uHLw/zFP3X/b4?=
 =?us-ascii?Q?jcyMupAgmVKnqUsZ8k2U0kHaJ1nM/E8uPtgyhOj0mpshrMaxdSsKyewY7R9c?=
 =?us-ascii?Q?CN/2HOdN9vG4nRtPaiotR500bPl2uZRBq3B//AKRGwfKz68a0AosZnc5jjFF?=
 =?us-ascii?Q?HVs9/vZDlIhHQRkREqr382qkzJTi/Dq+8LdJMJeMr0ofUkRwl6lmgLlcbbox?=
 =?us-ascii?Q?nefxwVEk9XVKx4yUQy9PJJAZzG2IHja4Srw8R59lvpG3GqdO0nVmFclvKwM0?=
 =?us-ascii?Q?54Q4SLP886pH7REF3ZtLdYjVEy4NAN71RlfvAOaJbWPwKyjreYyNNklOdr96?=
 =?us-ascii?Q?arLN+vWmpSy3x300ykZwk+zJzc4VJqg4JuqrCInKk+J7T8+Q2yi0FjRszakg?=
 =?us-ascii?Q?PTplkctl4Xh/0oN/e2uFS6q5aOxoRC4KnO3D6VSpRVGUsjgzgy/5PfJYUsH7?=
 =?us-ascii?Q?KgMs3HoNRB7RPGsoLcTnoLPwpo8D4vb6efFnpjtMt49XhYw197MB1cgYzqBc?=
 =?us-ascii?Q?mZbRBDyxLu1y9DjCdW/HNCnX1up0wck1YLJEZXSx6/zA3EdHmZrnn0wt2XyB?=
 =?us-ascii?Q?NTGNoiILxXkZL9aE2Tu5gwFTuLnauvB8fJoqe6YXTp5YwLoWsHCNFdkL4TI2?=
 =?us-ascii?Q?14ENgQw+nK98vPwVE8W7MIb/UE70shxG/CKbDeJ7kkN5zzZXsQGUMPJA4wHL?=
 =?us-ascii?Q?PA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?sGpCIkvN3/+SEde+3rdaoBiHCqvom0dfJEqu4Ixw149JwkmSiDr4TyS1vHF9?=
 =?us-ascii?Q?Zx0vmsjCo48yCcYTatl+J08j81S0uE7/zxu1LnJcOYg7sEAvwcZ6n8DOaf/g?=
 =?us-ascii?Q?CNYM6TPfo+apIeF4XihGt8W3TtIRVG4BmlnGBR7/VhOF4QIs8UHxgYF2MKFz?=
 =?us-ascii?Q?TSpZAEUlmokjIaiAQEHsgnguUG3WaK14s8NBJOpDagK2At53u8d6WfUyivgY?=
 =?us-ascii?Q?REaUYu4dqp+PWCfDmFh6EpGiIT/LYtPCcVvyRWkocEh3OttMUYRhFkSHJIY0?=
 =?us-ascii?Q?KgyUn7NSbgwXOWChoiQpbhn4QsXhNBJ1iP1wNxEt61IYKPsRJ/K1DBsM1Pql?=
 =?us-ascii?Q?oWjDA2ushLXaLITbUsNdtF9a86PhS99ZfnhxGLahoWUy5d68XVSJpUkfSUX0?=
 =?us-ascii?Q?Lo4+AzRxxV7M6uIQkMlfEUjlpVhaHmhle1pvdULU12ulAA0HXzhUonSoN2bN?=
 =?us-ascii?Q?mp1JsOKdXO8bQYKs8MMnWX981c/PwC86+5xmx4DletTrRaGq3akuSKsBhrFP?=
 =?us-ascii?Q?C6xsSgNjzWSe9KX/XI7AF4TBTpLzdEqs5uWNpNAV1Q+SIoSwXRcFEzK9jVzJ?=
 =?us-ascii?Q?uSBfVV7SHhlPpkXpqeS725SGB4aI6N1iY5fAQHIlW4hvoQWKzivXv4ao83el?=
 =?us-ascii?Q?9nnlXxJwmPdMzOXnynqXqeZKMv7Y3x2owzlTW5MxLTSu//toI4oZJal+AbId?=
 =?us-ascii?Q?KGWr6GhBXvXXrEjFeNkhiwZOAqHev2//EjAYImPRnuP9q/IZS9j8n04gIo8B?=
 =?us-ascii?Q?F/YiKR7fWTvM80XCgsql+8nRmYx7w3JMOQbuxCoc4QDZn12VBcgbmhDRcuMv?=
 =?us-ascii?Q?jdVNAbtKSNA+FgcBB9yP9LegQhvrgCX8jg5kCM+o34tBwzPSUcRMfpzXJlK1?=
 =?us-ascii?Q?SwD6aeG/OCf3n+dzwHNCUdThqYQWOwleQJyKHyZ+YHH2wPFjZkaP28vNwDzA?=
 =?us-ascii?Q?s+xKDy5AaAaJdV/1w88ya4RIT6fyqVLxoJXCPO0cQY3VbDXOi9p82GnCn6lF?=
 =?us-ascii?Q?l+6FnB12/1BkhyK3JrgchzjyJJi6V1U/kgTXF0Xinl5d80j0Vs+TtEMiPb5l?=
 =?us-ascii?Q?Dc7MVPexcKDJUysGDu6mIBOgFU8nQK7KO1gdYizQslyUIyJ2CnUC94GzLJ9N?=
 =?us-ascii?Q?/K46IiHAtUnd?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa66120-177a-435d-3e17-08dbc4410db6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 18:46:28.7050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IhB+WM1+4PcVobMTbcGTGVl4V68MV9wCURSCvnIaRYAZ+YqN5AaA3/bOlst4U07ibIBK7Uw14T4bWEjCIuW/4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7855
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_15,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=804 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030140
X-Proofpoint-GUID: 2n-nSG2vw5WkQXGvbLzv8eRxMQirqdNT
X-Proofpoint-ORIG-GUID: 2n-nSG2vw5WkQXGvbLzv8eRxMQirqdNT
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 11:47:22 -0700 (PDT)

* Peng Zhang <zhangpeng.00@bytedance.com> [230924 23:58]:
> Introduce the new interface mtree_dup() in the documentation.
> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  Documentation/core-api/maple_tree.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/core-api/maple_tree.rst b/Documentation/core-api/maple_tree.rst
> index 45defcf15da7..3d8a1edf6d04 100644
> --- a/Documentation/core-api/maple_tree.rst
> +++ b/Documentation/core-api/maple_tree.rst
> @@ -81,6 +81,9 @@ section.
>  Sometimes it is necessary to ensure the next call to store to a maple tree does
>  not allocate memory, please see :ref:`maple-tree-advanced-api` for this use case.
>  
> +You can use mtree_dup() to duplicate an identical tree. It is a more efficient

"You can use mtree_dup() to create an identical tree."  duplicate an
identical tree seems redundant.

> +way than inserting all elements one by one into a new tree.
> +
>  Finally, you can remove all entries from a maple tree by calling
>  mtree_destroy().  If the maple tree entries are pointers, you may wish to free
>  the entries first.
> @@ -112,6 +115,7 @@ Takes ma_lock internally:
>   * mtree_insert()
>   * mtree_insert_range()
>   * mtree_erase()
> + * mtree_dup()
>   * mtree_destroy()
>   * mt_set_in_rcu()
>   * mt_clear_in_rcu()
> -- 
> 2.20.1
>