Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <320f6e2e-c0ae-3cbd-bc43-d2eabcd70cc4@redhat.com>
Date:   Tue, 3 Oct 2023 14:58:58 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH v3] sched/core: Use empty mask to reset cpumasks in
 sched_setaffinity()
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org, Phil Auld <pauld@redhat.com>,
        Brent Rowsell <browsell@redhat.com>,
        Peter Hunt <pehunt@redhat.com>
References: <20230804023218.75544-1-longman@redhat.com>
 <20231003100602.GF27267@noisy.programming.kicks-ass.net>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20231003100602.GF27267@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/3/23 06:06, Peter Zijlstra wrote:
> On Thu, Aug 03, 2023 at 10:32:18PM -0400, Waiman Long wrote:
>> Since commit 8f9ea86fdf99 ("sched: Always preserve the user requested
>> cpumask"), user provided CPU affinity via sched_setaffinity(2) is
>> perserved even if the task is being moved to a different cpuset. However,
>> that affinity is also being inherited by any subsequently created child
>> processes which may not want or be aware of that affinity.
>>
>> One way to solve this problem is to provide a way to back off from
>> that user provided CPU affinity.  This patch implements such a scheme
>> by using an empty cpumask to signal a reset of the cpumasks to the
>> default as allowed by the current cpuset.
> So I still don't like this much, the normal state is all bits set:
>
>    $ grep allowed /proc/self/status
>    Cpus_allowed:   ff,ffffffff
>
> The all clear bitmask just feels weird for this.

The main reason for using an empty bitmask is the presence of the 
CPU_ZERO() macro that can produce this empty cpumask. It is certainly 
possible to use an all set bitmask for reset purpose. The only problem 
is it is more complicated to generate such a bitmask as there is no 
existing CPU* macros that can be used.

Another possible alternative is to use a cpusetsize of 0 to indicate a 
reset as long as it doesn't cause problem with existing code. Will that 
be acceptable?

Cheers,
Longman