Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2180037rdb; Tue, 3 Oct 2023 12:45:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxAW4lCHUOfKi+T++wVKDpXq2DujZeis5n/KjEICSSLwNpa1m1tGJK6EVIoGsOWXdgSlOO X-Received: by 2002:a05:6a00:1c9c:b0:690:38b6:b2da with SMTP id y28-20020a056a001c9c00b0069038b6b2damr502745pfw.2.1696362344973; Tue, 03 Oct 2023 12:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696362344; cv=none; d=google.com; s=arc-20160816; b=Muycautc5TbeEgqbKPwl9O3e0b7QmujYY3fPG2++6TNE7IsbWvnB6vXF7NGDtKRu41 QX1gTyQuAFU8RZL/y/3txPq1vOerFgiUESWsmxxJqdefGN0kMKuN5F5Gl80RKJda8Wob OA1fHQgw/Ny4tYr/X/9vMK1y4SrdtihEqX8JVQI7JzA91tfF7E06nnyh70s+62envI6o goyMpMd/6U/jtgWl0dkQSF7noCOFsDEbDiLLxRxtXnInUIbyiSSObD9ljoM4fRCeAe/j N0XFJdaYzpyJen5HuLX4eFA8K1nqee39GuyaXQGgBEBHVhFEgSDF9L1I0/bCW8idDxVN FLIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=ZrVY0RSew/D83i1yOz8bJIQB2Mzcr2nrNMcXSv8WFJk=; fh=cnNcGImSCyHZg61Oq1lVwS9n8ovlUW+xOV8QcY0Hamw=; b=1IDqVjH4eCjXEz2//ZpMcPE4VGON97awoVpQIeoHYHyl81SSoqExLwSoFxQcyZbgE3 +pJXIv+8vrJ0IynThKWOOjA/8pxxTs5Q7WPjpXSzxVAsjbZae2odvoGS0VJrcwE7kIPp 0cWTRO6s1/brI3V6zUEOBN2wvE2Yx/LKs/Vvix4gdrOedGkX//9XT5VzjjZiKNcrOW8B AFFs2OYRlcYlX7sEx+PJeZfsNAL2EZ+tUsxvfD2QsBi5MHxJVovjoJnql4qkpify/H1/ ly14qcCk094Z4qyv3v8B971OqjJDvjjUJ1X+S03UOHiMroziUCzJQMyFxHv3DC8DAmEn dJXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id i13-20020aa78d8d000000b00690fec2f3bbsi2019374pfr.85.2023.10.03.12.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 12:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 911D0811C14C; Tue, 3 Oct 2023 12:45:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240955AbjJCTpf convert rfc822-to-8bit (ORCPT + 99 others); Tue, 3 Oct 2023 15:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjJCTpe (ORCPT ); Tue, 3 Oct 2023 15:45:34 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C37E9E; Tue, 3 Oct 2023 12:45:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 4C38C6340DF3; Tue, 3 Oct 2023 21:45:28 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3ulYD1wGVKZI; Tue, 3 Oct 2023 21:45:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id EA3E26340E0F; Tue, 3 Oct 2023 21:45:27 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mJfZ--EnOnn8; Tue, 3 Oct 2023 21:45:27 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id C40526340DF3; Tue, 3 Oct 2023 21:45:27 +0200 (CEST) Date: Tue, 3 Oct 2023 21:45:27 +0200 (CEST) From: Richard Weinberger To: Daniel Golle Cc: Randy Dunlap , Miquel Raynal , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd , devicetree , linux-kernel Message-ID: <226381209.31782.1696362327615.JavaMail.zimbra@nod.at> In-Reply-To: References: Subject: Re: [PATCH v4 5/8] mtd: ubi: attach MTD partition from device-tree MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: attach MTD partition from device-tree Thread-Index: kqr0xqm+jR+lBv0FwDpbk9UYfLM3MQ== X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 12:45:41 -0700 (PDT) ----- Ursprüngliche Mail ----- > diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c > index e0618bbde3613..99b5f502c9dbc 100644 > --- a/drivers/mtd/ubi/block.c > +++ b/drivers/mtd/ubi/block.c > @@ -470,7 +470,7 @@ int ubiblock_remove(struct ubi_volume_info *vi, bool force) > } > > /* Found a device, let's lock it so we can check if it's busy */ > - mutex_lock(&dev->dev_mutex); > + mutex_lock_nested(&dev->dev_mutex, SINGLE_DEPTH_NESTING); The usage of mutex_lock_nested() in this patch looks fishy. Can you please elaborate a bit more why all these mutexes can be taken twice? (Any why not more often). Thanks, //richard