Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 3 Oct 2023 15:58:10 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     jim.cromie@gmail.com
Cc:     =?UTF-8?B?xYF1a2Fzeg==?= Bartosik <lb@semihalf.com>,
        Jason Baron <jbaron@akamai.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Guenter Roeck <groeck@google.com>,
        Yaniv Tzoreff <yanivt@google.com>,
        Benson Leung <bleung@google.com>, linux-kernel@vger.kernel.org,
        upstream@semihalf.com,
        Vincent Whitchurch <vincent.whitchurch@axis.com>
Subject: Re: [PATCH v1] dynamic_debug: add support for logs destination
Message-ID: <20231003155810.6df9de16@gandalf.local.home>
In-Reply-To: <CAJfuBxxmL-GtBgt=033F9UNeLCreFbJh3HrQQN2nYKwR_0uTbg@mail.gmail.com>
References: <20230915154856.1896062-1-lb@semihalf.com>
        <CAJfuBxyFYyGCtr5i=P7N=1oX3J=jmdp1VLGLt+z1fAnuvGK2aA@mail.gmail.com>
        <CAK8ByeJBrPEQSgUc91LQO9Krzjh2pauhMTjEC82M8ozayE76Yg@mail.gmail.com>
        <CAJfuBxxmL-GtBgt=033F9UNeLCreFbJh3HrQQN2nYKwR_0uTbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2 Oct 2023 14:49:20 -0600
jim.cromie@gmail.com wrote:

> hi Lukasz,
> 
> sorry my kernel-time has been in my own trees.
> 
> What I dont understand is why +T is insufficient.
> 
> IIUC, tracefs is intended for production use.
> thats why each event can be enabled / disabled
> - to select and minimize whats traced, and not impact the system
> 
> and +T  can forward all pr_debugs to trace,
> (by 1-few trace events defined similarly to others)
> or very few, giving yet another selection mechanism
> to choose or eliminate specific pr-debugs and reduce traffic to
> interesting stuff.
> 
> Once your debug is in the trace-buf,
> shouldnt user-space be deciding what to do with it ?
> a smart daemon could leverage tracefs to good effect.
> 
> IMO the main value of +T is that it allows feeding existing pr_debugs
> into the place where other trace-data is already integrated and managed.
> 
> At this point, I dont see any extra destination handling as prudent.
> 


I'm fine with either approach. I kind of like the creation of the instance,
as that allows the user to keep this debug separate from other tracing
going on. We are starting to have multiple applications using the tracing
buffer (although most are using instances, which is why I'm trying to make
them lighter weight with the eventfs code).

-- Steve