Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <c69f894f-9809-8ca0-b596-311e889cbcc1@intel.com>
Date:   Tue, 3 Oct 2023 14:07:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 03/24] x86/resctrl: Create helper for RMID allocation
 and mondata dir creation
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-4-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-4-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmxJOFo1ODhRQ1dML2JYd0hKWm1IUlZWRkRVU3BWR1N1bnhkNm9QRWlxQW1R?=
 =?utf-8?B?VlUyWTgzV3hYVVJFTktMWFAyRzg0RXdYaFRXVFQyV24rUVpZL1VuK3RTRTRu?=
 =?utf-8?B?T0FjdXlhUStEcUdjQnpiUlFwQ0lEL1lUcS9aNlcvYit1bzVtNjdWOFFYTWxW?=
 =?utf-8?B?eHduZmo1S1liMUloMWR1MmV1dEU3YmE5RTB1MmFJV1ZJM3NPdnlFRGNtQmth?=
 =?utf-8?B?WEJkZlFBVm5vTTVSQlAwLzF3aWpSRDlLZlloN2VHWTJJdjJGamFwM3pCR2ps?=
 =?utf-8?B?RVdGaGEyVjgrU2tQdWNETDZFSXl4alFHTThZTU9PaW5HUHhKa3daeGUwUmto?=
 =?utf-8?B?eEpQanJEUzA2SEdqcEZWY1B0cXdPU2JESlBVbStiM254cWEvWTM4clVxcEhB?=
 =?utf-8?B?VUZXNndxWktsNzNxZDUxcGdDVERnem40MjZtQkk5S1RrYU1YM2p1NW9lUGZK?=
 =?utf-8?B?WmhvakZJVVEyMGZ1WUg1UWJFR1MzZm9jMzEyZWxrMHZsRU13RTh5MWcyK1NT?=
 =?utf-8?B?RkNjaU5xY3pHazR1bjdDVWpHZ3ZFcUpBNFVCTUIrYVBjMS9UbXJnMC9qR09Q?=
 =?utf-8?B?Tnl5RXVla2V1ZHA4VGtZUW1KUkZFbkJwQlJnbFNxOFkxckthNXdwR0FTcElp?=
 =?utf-8?B?M3RKaWlqb2xKV1VqdGRWaGRsaDdxbHJSaFlHNXJRU1hsbmxPUStOZWZKSkJW?=
 =?utf-8?B?c2pML05oWkpoeDVpcXZCZWV6RFFwNjdyN2J3eWRLaThySUExdW9kRFMrSllx?=
 =?utf-8?B?Y21ub21rdTFQeEgreFRHNGFMY0xseWQ4c3BlMy9HM0JIYjloMmxDYjhSc0pJ?=
 =?utf-8?B?anpia2dxT05QZzkxK1JjYWxBaXQ1NmNtQS9WYTRwSlJSMFZFNUkraDNjZGw4?=
 =?utf-8?B?K052bVo0OU9rRFFBeU4zV2tTTUFBMnIxdjlIVmI2Y1ErZjUzYjF1cUM3QXEz?=
 =?utf-8?B?VWxiQXRLbVV6Q3dzU1UrMkl3WFlCeXhBQU10UGxYWkMyQWpSR0hxSTV6amhV?=
 =?utf-8?B?amN1a1FSU2VjWGlkVCs1TVRXeXFhS3hyRDJyVzhFdXFzOFlkd2ZDL1JKLzV6?=
 =?utf-8?B?ZjZ3cW1iTEJIVVZiaUNielN3V2F3cEtaV1hDSzQrSisrb21aUDhJb3VyVWw3?=
 =?utf-8?B?b0czOHVDQmdzRHJ3K1VBTkkvbWFjNkgxV2J4U2NkdGpxVWFNSCs0SjY4VUNu?=
 =?utf-8?B?QU10R1JjOTUxUkV6eHlKS3dQZHlSWUN1NTVMUGl2cnpncUE5NGtoVS94cU5l?=
 =?utf-8?B?Uy80cGFtZ0txQVphTDhZTklEWDFnRTZJWlgyL3VrZHE5aVVEMW5EZytneG1i?=
 =?utf-8?B?VEFOand0RDlab3lNUnZEQ0VDckVFRGN1cnY1Q1ZwcDZUWTV0Vlh3UUFJZ0Z0?=
 =?utf-8?B?OVRvZzZiZFhoNGQyYjFtZzBEVFBBY3JuQnB3T2ZmZXMvcmRoc0JNMHBibEFS?=
 =?utf-8?B?a0lWZWdyU291Vkw1cWttMUlaRnFBcU1UTXJaaDh6eEhCZCtTTU1IcVZ2SDVp?=
 =?utf-8?B?Ky9WMnRPNm54U1lObHRjOVdGT1B5VE1mODBhUDVhejc1ZFNlVkRWTEs4NXlp?=
 =?utf-8?B?UkpwcW5GYlIyYmdsV2pVMkpHOWJRZFlQd3RIZGQwT05tdXVPZjU5bmFSSVhu?=
 =?utf-8?B?Z1FoV09WSW9VZi9lOUY4T3lNWWdHS0MraVRVMjJUNmxmNkdhMmpDVTJZNlly?=
 =?utf-8?B?QXo4bGNHRDFvUEMrSitpc2dILy80cjgvbmVRTEZRVWhxM0VXUVFwQllkRFRX?=
 =?utf-8?B?cWp3TFdYSFY5cUxkU2Jxb2N5VDFRSXVHTTJ0L2dCbDBKY2RMRVd0dEluTkNx?=
 =?utf-8?B?SUt4SmZHNXJmY0hWVytwZEd5Nk5vWTUvZnB3K3FVTXBBa1AxL2hka1NnYlIw?=
 =?utf-8?B?b1ZKZC94anJjd1NrUm16ai9jMFo5N1lvL0NiMWFGQ3dhalFnYXByMVBaeklT?=
 =?utf-8?B?cWJ5SzJQZTJGbzN1eHZrQVFyQVpJd0x5R3R0VDVscFVoM2M3QVJSQ2srVk91?=
 =?utf-8?B?eGpYRWtsNHM3Z01GSWxHUUpTRlhzeldYbnVhQU4rV0JHTGZxWDNoSG5wT2hw?=
 =?utf-8?B?TDhkdTE0ZGhjNjFrRzNYWWtvYmJrMmkrQW1JZXRZVkVrZit0ZDc5ZFdoU0V3?=
 =?utf-8?B?QVVQdkIrTXJwMFUyM216empjb0s4NXUxWkNYUkdFaTNxYXlCVG9oYnU4ak1q?=
 =?utf-8?B?OHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: da4ecb1f-eaed-4c63-c607-08dbc454c3d3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:07:34.6526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: txFKHXEBBW2AU8wrKWCHFX7MIpOVu01qGn4d72F4razqfe+vgxiNkbG4DNrfYavYRh8n849/dyl2oriUMDOHsMB2hC7av2kLJ6jz/ck5pMo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6908
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:07:50 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> When monitoring is supported, each monitor and control group is allocated
> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
> allocate the CLOSID.
> 
> MPAM's equivalent of RMID are not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
> 
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
> 
> Move the RMID allocation and mondata dir creation to a helper, this
> makes a subsequent change easier to read.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Please follow the x86 custom for ordering of tags. You can
find this documented in section "Ordering of commit tags"
in Documentation/process/maintainer-tip.rst. Please do
so for all the x86 patches in this series. I believe this
also applies to the tick.h patch.

For this and following patches please consider when a review tag
is provided it is done with expectation that the commit tag ordering
is fixed. This is the only scenario I am doing it for.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette