Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <c3d6086e-a564-66a9-6e0b-0e109f30f6c0@intel.com>
Date:   Tue, 3 Oct 2023 14:07:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 04/24] x86/resctrl: Move rmid allocation out of
 mkdir_rdt_prepare()
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-5-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-5-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enpvWGlpRUhRY2ZabWNYeEhRS1l2MjBJakVFanNVZ2tCTEhsVWw4Ni9EbEoy?=
 =?utf-8?B?b2E1WWFTTTlMdjdVZHJ5QlBUYy9WN1hyOXRxeEVUTnNsTmdQdHd5Uk9NcjVi?=
 =?utf-8?B?MDJoSU8wR2Y2ZjdkRVcxZVUyNE1JUmVFa1p2S0FqcC9BN2JLZEpJWlh1azZt?=
 =?utf-8?B?QWN6T3lUZjczNy9RR1RkenI1bEFKYWNvRXd3YWJpTkV2dnVTaDYzaWsxbnNR?=
 =?utf-8?B?M3VDc2laQ0Z6ZXBtZlNHSkJjbjJqaUtTZURvZ3NjaXZxVVIwWGlvOHVoZkgw?=
 =?utf-8?B?WlBMY0xjMkRUcXpMa1lIUU5zMmtVUTNvMC9aOUthSXRtbG1aZTR3UjY2L0Vp?=
 =?utf-8?B?ZGpxR0pCc1o0dE5YSzRNWnNwWHN3bkVkZXhBK2FDU1NDWHpTcktLQ3E2ZGd6?=
 =?utf-8?B?Qjg0WkRRTnNOaDRqVk5peXRWbVc5R09lejRNS3ZTd095RlZ6RDhpTXZuSWpn?=
 =?utf-8?B?blVCcFozWmI2Z3h0a2pOUGs2UlA4VzEzaWQ2TlJINkNUQ0x5TEtFRUFnUEtO?=
 =?utf-8?B?bG1jQXlkWGNoU01YdCtiRFBrV1NEeDJZVWF1aEFTeEMwenpSRFVvYVFLZk51?=
 =?utf-8?B?QmZGeCtlR0hHbE5Kb1FXQTVDcUtQd2RQYW9UcEtWODhKVDltWWZhdWlhZzdo?=
 =?utf-8?B?aTduUjR2b011SEdXdVd0R1RVSUIrNUQyalJpMi9LVmprSFNFcVZrUTBTWlNK?=
 =?utf-8?B?Mlp4S2Y1SGxoSlR3NDRvc1VHaVpVNkZDZzRHQk1ha3MxalJxSGZuZUV5cXpv?=
 =?utf-8?B?eFppVEdnbHA4YU1nMysyaGplSTR2a0FKWW93QTBFYXdqZVhDTXMrTDV4V3h5?=
 =?utf-8?B?aUNNWW0rWVlKZTJDeUZNWDRuenNiSm04WXJjTDZxVVFVQTRiaS9OQzBvWWxl?=
 =?utf-8?B?WDBJTDE4WGNDNTZGRHVpbjlpbHdUVVlTWG9CT1RPczZicXZ5NzdOaENGQkl2?=
 =?utf-8?B?WU1jdjNzL29VVzVVZ3huS1czUk5vYVZnUHFJZDVYWnNvd1hXTTFuVHZMa3da?=
 =?utf-8?B?VWQvUEc3eVJxUWN2T3FvNmhZY0RVVTdtNXRFaXoxdlRkZ2k1ZXJheVVzYkVY?=
 =?utf-8?B?Q25QS1FTUVBiY0pacWhPTmE5YVhsN1lSTTdmaFZyOFphaHQ3ZzJqSFJNMUNZ?=
 =?utf-8?B?MmJQSlRuY2hrYWxRNllBOHFqMkF0YzdSeEhGWWJyNEZCWDlDeWhyS2xaSjFD?=
 =?utf-8?B?WGthUTVPNVZmY2RpcXJJYXcrNmE3MEZiMkx2WFJlWTJqRmlGaElUYktOelBk?=
 =?utf-8?B?M2N5d1ZQWXlsZ0xKdE1zaDZMVTRZMkxkWU1tc2lRYURPcEU4aS9vc0NQMCtZ?=
 =?utf-8?B?Q3FGaHByVjFIZ2dXRm9GelVlZzcrNFBzcnhPS3pUMms3UUxIV1FJSG15ZFQx?=
 =?utf-8?B?Zm93cEozQ3grQTN2QWFiaFFaUHZVNW1YbGZiQUp4SThlMmxRMlJtaklzdmJ1?=
 =?utf-8?B?aUtZZ3FoNU1wV0FNS3FmNlJOZUFRcEcxRU5QbUJTckx4NHd4dFJGb1BReDlr?=
 =?utf-8?B?L1JmS1UvcU9xSlpEOU5TVFV1aHBLSzdpT1J0Q1lJY09xL1VjcWI1Uk1NNWZR?=
 =?utf-8?B?TjZwTlAxNWtSRXRPYTBWeEgvMUFmY21kQ3hLM2U0T2N0eXdCS3pkc0o1dXJv?=
 =?utf-8?B?d0hXcC9qWjUxTEIyaWF4TjVBeEJTb2U3dkxrOTJLSXorQzFMcXBCNnAvNHd1?=
 =?utf-8?B?VGRhckxnZWMwOFpCR3VZYmI5VDVSWXgvdFpPRjl5N0V3cDI4Q2J3NTdBRUdB?=
 =?utf-8?B?Q3pXeFVFb3U1TXY3TnArNXRNWGhJN2RZL2dqT2hWcGtRYnN0K1cwZ3dKTzFI?=
 =?utf-8?B?TXBHTnBZeC90QXpieW1sM0RGSFFzMC83eCtLWnBVQitHWWYwbm11SE9uVUI2?=
 =?utf-8?B?bmFMbEZiSy9oSkwyb0R2M0tsbCswMU5vTFcxZFJwTmVxaFEyaTRacktTYVF2?=
 =?utf-8?B?ZlRFL1doZ2RJRHVqeHprWWw4cWFCNDFWTXFQclV3R29qZW13eE8yZ2liY0Zt?=
 =?utf-8?B?K2c4ZlgzWjJESVkxT25MY0QxNVFWQS9sbm0rU3hyOUk2aXRuRU1VT1VXajNh?=
 =?utf-8?B?UWFBWmcyNlk2Y09seTMxNUN0OHlidFc5WFVOb3BIL2hqK2xURlJteWl5YXJp?=
 =?utf-8?B?Um5GcHp0ZzZySjB4aHdJa1d5U2llNEQyVEM4VTAxalo5L0ZWMmdkY1A2ZTVr?=
 =?utf-8?B?WkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8171fd0a-e809-43dd-c8d8-08dbc454cbb6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:07:47.8405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: En6bSNKkFYVbnktp+Vl3okvjbLLvbOqRtC0sO5A8YwrUYeBuGYkAEO+SksUq7EL+9KA3dC+GNYEB7MBa5cHxz8VW774Y+M4ZwiN4eo7xeEU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6908
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:09:11 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> RMID are allocated for each monitor or control group directory, because
> each of these needs its own RMID. For control groups,
> rdtgroup_mkdir_ctrl_mon() later goes on to allocate the CLOSID.
> 
> MPAM's equivalent of RMID is not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
> 
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
> 
> Move the RMID allocation out of mkdir_rdt_prepare() to occur in its caller,
> after the mkdir_rdt_prepare() call. This allows the RMID allocator to
> know the CLOSID.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette