Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <fd8301e6-b0fe-8e8c-f0bc-13646da3ec41@intel.com>
Date:   Tue, 3 Oct 2023 14:05:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 01/24] tick/nohz: Move tick_nohz_full_mask declaration
 outside the #ifdef
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-2-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-2-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmtyUG4vQWRQaDIzaHF3SHh6RUl5SHNOOEJveE0rWVQ4SklyQ2dldkpZb2Y3?=
 =?utf-8?B?aEFnVW1DTDlsRzNKei9McXhyNGo1T2xsY01IbVc1c3NCQjhiRkRKYU9Mbzc1?=
 =?utf-8?B?RUdJSnlyNkQ5VDdNTzFlQWpxY1Q0RGU3OTNMc3pxRkhQREE5MHNVYlNreVVC?=
 =?utf-8?B?c3VXbmZvdzZmTUlhV1U4aHhNcXFJeXpBY0R6QVRpUW1lQTdRU2JYT080Z0JT?=
 =?utf-8?B?RzVnTGFRcjdha1JOQlpsQjVZV0s3Y01nYXRDdnZXV3orM0dOb1pTNXJjNzRQ?=
 =?utf-8?B?ajFJQnNhdTNIYSsvRytuTG9aRmlxcTNrY0RKajFycjdSdVovaWlqR1hRUGU4?=
 =?utf-8?B?VEx6VU84ak5YVHUzYk13eUJHUHJWRGtBY1dLR1kzaFVwS3A5bm5WODdjSDY4?=
 =?utf-8?B?eGFGSDBxQkFHVlppS0kzbXd6UDMxR090NmwranFUeWxxbkYwWUtHL2xSQjZX?=
 =?utf-8?B?V0g1Nml0b2NzQzRRTUVra3c3c2h6eGdaQmxaSS9xNVRXanRqWlRDRVg4ZE53?=
 =?utf-8?B?enh2L3hFQXQ3UlhDSDZ4NkdpNHBHdHFKbTJZODlLalBXQ2xrbzVwRkF0VHFU?=
 =?utf-8?B?WmhVaE83YVROTVoyZmJTdFZJM3k4M0hSVHI1Y3FJMnJMUThvNjZWT2gzMTlx?=
 =?utf-8?B?bldUbWJEYlpZTXV5dTN4cUhUa09WQlF3eS9pK3hGTWJVVitpakFiVXl0enla?=
 =?utf-8?B?T1BzSkNCQURlWFQyb3p0U3NkZUFFdkc4aGxIZVduVXNYQUxwVi9FaVNNUU9U?=
 =?utf-8?B?cHFqSi9ZR2xCK0JqZGZDYWlFWWxxZVpjTzdWWDFUVHdKSHBCbHppd2RvL2hR?=
 =?utf-8?B?ZmJIbFNCN0xWaEVibm1mTmZISFkvaERFTVJJbXYrcXpaUUFqeVJ4ZTJPdzdF?=
 =?utf-8?B?d0JGY3M4NXRxcjVTT0g4SlQzaXpvbG1GMVhhUmlOSUdxc1Z0UjRYbXhsL3FM?=
 =?utf-8?B?OUNGeGRFZXRCU0haRGxSNTJQajdob05Dc3piY3U3QnNwRVhRdUN0emVUR3VK?=
 =?utf-8?B?a2ZQeTJQTE4veXVpU3pIN3BSMGR6elVHSzYrMXAyWHQ0QWNLTWtGV1JvbnBs?=
 =?utf-8?B?c1ppMnp6SWFLN2lwUEVvT2tHTzN1R0MxazF2cDFKZlpMajVjdko4UTNSL1RP?=
 =?utf-8?B?ODhrb0YvU2o3a0xwZ2d0RFdsUHhHUXIxTHRmNGJUeU1rZDBYc1haREpnOC9K?=
 =?utf-8?B?SVdNanp4cUh6VVJmZEhwMXVOUElTdlVPNEp0b01Sa1A5MndBcXFKRS9PSHpp?=
 =?utf-8?B?MjFMd3ZkUjFwYktLdHpuRTRlVjFOcHoySVljTExva1BjenJ2MVM4R2tZYm1j?=
 =?utf-8?B?WjBjMWYycnlxNk4rSHVwUU1naUIrWFAxNTQvZ0tkVHpXUWdTWklrL1BEQXVi?=
 =?utf-8?B?Zy9JSE15aFBYNDZkWTBSbWs4ZGl6QXVxR0FROFVNeWVOZTNHeDBCWWRxYW5T?=
 =?utf-8?B?SXFoZXBCSEpycXpISlg4eTl2Ympja2laK0U0b3lzdnNQVFVhY3NNajlRclJW?=
 =?utf-8?B?T25ScWV2VEJRV1EvWEkxY09qcGU0WmZxTkdhMGxDQW5RckZ3a1FzdXBUaWpD?=
 =?utf-8?B?QXNScTVJem5aaWFpYjM5YXVVU3NEWjBwQ3pMeGVlMEtRbDNXaHMvY2pTN1BJ?=
 =?utf-8?B?dzAybGJySGVYejd1YXl2b2Zsa0hxNlpMZWtlRk9ZWG9VWlMxN05ybUhQb05i?=
 =?utf-8?B?K1RXOG5RVmhRRUxmaTdmWFdEbGRRdkpOUnpEbGw5V3RJRE9TaVlhOGJEbnUw?=
 =?utf-8?B?MXlML1RDYTNCd3p5RXFYS29ZZ0Y5RmlQZDMxZU8wVjYzWVQxbVV2dFlaRU5E?=
 =?utf-8?B?QTRZSmhadEt0MjZtdVVmelhocVNaYTh6WDZpd01SVmJ0Q2J4L2hMTDNiQ0hq?=
 =?utf-8?B?OEhCclcyTXJpTnRsTk5mcUplS1Fra0hlN1hYVjMveWZVelR1dWgveFBNRnhq?=
 =?utf-8?B?cFVaWi9IcytzUmhRQWhkN3VObjdQeWpUbHdXRk1kT01pZTRvMnlTOEZ1a1Jq?=
 =?utf-8?B?TnkvOUtyTE42dFU3b0NsOGFXMnV1R2lVWWIwK2VaMElEa0VkWkluMEwvVHlN?=
 =?utf-8?B?NTQ3RW0vOUtVcUFMdHI2NDZQbytybThxWVMzdE1ETTkyRnVzcE5oNnNRRCtD?=
 =?utf-8?B?USt2UzRNU2RESzYyV3hiSXo5azdIVTRFTHdBcHlwb0JPbUdxTEs5UGtqNzdI?=
 =?utf-8?B?aVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c230f542-d193-4a00-c65c-08dbc454895e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:05:56.6286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lpZSMovCkga7MuHRWlVHl4d8GSwSUL2U3pkknQtiQjMLWuEqddI++ylyh+RSCTToDcsgjwrKRjKrCrK1Hk6mSz+Gxn5+7hzdIyPNSs26dHA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6908
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:11:38 -0700 (PDT)

On 9/14/2023 10:21 AM, James Morse wrote:
> tick_nohz_full_mask lists the CPUs that are nohz_full. This is only
> needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows
> a specific CPU to be tested against the mask, and evaluates to false
> when CONFIG_NO_HZ_FULL is not defined.
> 
> The resctrl code needs to pick a CPU to run some work on, a new helper
> prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding
> the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to
> be behind an ifdef too.
> 
> Move the tick_nohz_full_mask declaration, this lets callers drop the
> ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or
> something like tick_nohz_full_cpu().
> 
> The definition does not need to be moved as any callers should be
> removed at compile time unless CONFIG_NO_HZ_FULL is defined.
> 
> CC: Frederic Weisbecker <frederic@kernel.org>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>

Acked-by: Reinette Chatre <reinette.chatre@intel.com> # for resctrl dependency

Reinette