Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <603835ae-b96a-6b42-b6bb-ea19699e38bc@intel.com>
Date:   Tue, 3 Oct 2023 14:12:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 06/24] x86/resctrl: Access per-rmid structures by index
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-7-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-7-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZpd1h4SERuMEVpK3hXZnZFZUwrc1ZINFlGUHJSZlZVdjh0NDAyU0tNNXNI?=
 =?utf-8?B?U05xRzBReTgzaTZscm5YZlFHSitrMkVMRVJsQzg3SHFBQU8rTG5yVkNFakdv?=
 =?utf-8?B?Q1VKUmJjTUZVYVAwUU1wbGZ6Vll3QkNWWXFCbFFTM05GajlOSDRRUEU5TFZo?=
 =?utf-8?B?ckxIYm9Fc3JXY1hsK1hTMmErODdwL1dwQis2bnFkTTI4RUZ2NnhaTnlKZWJw?=
 =?utf-8?B?dGl0QzNjaTdQTWFqa2ovOVl2NHJVTHY5MEFmNjBFMjdyYi9DK0tKRTZqZ05W?=
 =?utf-8?B?OTNsV2ZOZFZoR0ZoNEx2NzJLSXdKQ0RaTkpEM0daR3l6TVdlaVZqKzBYcEVt?=
 =?utf-8?B?VzBJd1g1enQ1ZVRWb1lIcWlLQ2ZmQlJpakhsLzY5MkVvNHByS0U5aVhZNFBU?=
 =?utf-8?B?SzFBdFFHd3JpbTJSaG53VnhKVEZ5RjYzRzB2NllvUTVta0VJbHIyOWRYZjd5?=
 =?utf-8?B?MWM1T1Zzb0Zoekw2UzRURUxCM2ZSM3ZIRDlZeXN0UHQ2QkwzYXpISlF4Qjda?=
 =?utf-8?B?a3F2cHY0ajNIRE82d3djYjkrbnhHbG5GbVlGcG9JMDRuejNwZGs3c24wbWVy?=
 =?utf-8?B?Y1FieHBudVU4anBjNk9mbzFaQVVyV3VLdndoTmEwb0tTNWdhYmkwYnlvaUVC?=
 =?utf-8?B?UXQ4MkduSllYUHlyT3pmbkVLQWNEM2JtQjVlKzdobzNra1kvQnlxcjRzQTFX?=
 =?utf-8?B?VzU2c0RVTURQa0tEMFhaRWdkOXNvRjFSYUd1a0FlVWgxRHJMUTh3dGJGQVJr?=
 =?utf-8?B?V0xpU0djZjZuQzRWYkN1Q3Exek0yUnhoendGbmNqYmVDc3VYV3ZyWHZOODA4?=
 =?utf-8?B?bEF0Tk1wTXgyd0RCSDI0S2M4MVJuckpwYnByYVJ4bzJBbW00OEsvMFZFTkgv?=
 =?utf-8?B?ZzNHYWhvL0NwUjMwM3ZKa0NxcFREeVFxdTJZMmFRZit0amFHSmZsbk9XZVhV?=
 =?utf-8?B?a1c5YXRWaTlxWmlRT0ViSy93VVRvYmNJcjdaaXh1bUZWM0FXVUJaamhWdTRY?=
 =?utf-8?B?bFpxYmsrenFhU2loODYyRjhPdDlQeTEyUDYxTFBkUHQ1RjQ1TXJWVnVaUXB1?=
 =?utf-8?B?cmFMUG5QalZjakx1dHVITzZoaUlyVkVtMHF4dlowK1dXMElCbFFEV013VzJZ?=
 =?utf-8?B?RkpHVVdJbE9KWkRiUUI4VDRkekcxUlY5WkUrMk9XY2ZHYzRJZmgzcXd1R25z?=
 =?utf-8?B?L1B1bk9SY3RIeGZvT1lKbkwwTTVaTzVXWU1FeG5sakkzWXQzR3dsczMrYlh2?=
 =?utf-8?B?ZENJWmh0RWZUY0ZQbkEzamhJSktTbzBQM3hUM05ocHordldkb1I5K2pBWVBn?=
 =?utf-8?B?emNwMTAvS3krMGtBUUhQdzF3bU9YYUR2RklERnp4MW1oOU1WdzZwSG0rQzhx?=
 =?utf-8?B?T2cxMURSNExqbm1oOVpiZ2tQY3JXL2dEbWRHVDFHU2RuZnNqNnYzcEZEeG9Z?=
 =?utf-8?B?VXNSVmVZaWQ2MnFiK1pTemdsNnEyNkdEZCswUG8xa3BkcHFsREg4Q3Yrbno2?=
 =?utf-8?B?L01uZlMvWHBDT1oralBsa0Y3V3ExcTRlZWwrRVdLcUVkTVhxcjZyU0lpQ0hu?=
 =?utf-8?B?Sm5TODhKcVhPc3I3TDltOHBlYy9hRC9vRVNHMmM0QkxOdklGM3p2MzNDU1Rt?=
 =?utf-8?B?ZGh4UkxyUnl5UERUTDEvQ2pGUDA0OFVnYTNrdktPbWx0WEx5bmZTaEVkcGNN?=
 =?utf-8?B?eXVqc05nMHNDU0FyRm5XRWZNeTJhWGdLU0xzTFM4Sys4MnRWUS8zYTRHTEVX?=
 =?utf-8?B?UlF5TlgzakdQUVBRWUMyS090emUzYzJxZDJYTXMvK0RoMjZLWjdxT3dOV1pP?=
 =?utf-8?B?TWsydE9rYjJJd2VJVEgvNWlBRThXYXIvZGQrMFVmcXN1cVB1dktRRHk1QW16?=
 =?utf-8?B?WGpIUENNSDQ3MFFQT3crdjY5cEgwNTlLQlJhdXlrU0JTTU5vaWRUQWlsL1N1?=
 =?utf-8?B?aitUWGhrQTRjQ2EySkJRWGNTMlNEaG12ZWVUSWtNL1hvbG9lbFI1aWJkWTJu?=
 =?utf-8?B?cjN4V0VyZGt3d0RDOUZKSmRaRUZXL3c2WnRIOGppUXlMRWNEai9xeFYra3Jh?=
 =?utf-8?B?THJDNmJxVW9ycDVSKy9LMjM4M2tJRlhQbHdGWWxUemtMWExaUmh5YVoyQU1o?=
 =?utf-8?B?U1VwakhpeFlLWmFJSlFhSzVqWXhOQ1JWUTA0Tkdxbm8zN1FBcm50b1EwRWdy?=
 =?utf-8?B?eEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a743b5b2-00fe-4d3d-55dd-08dbc4556d47
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:12:18.9181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S5GB6Zb2NHeBItxTP+r+Bna23CO7OgKJEK+nRlxkJZipgiEzDDXXRx9Odk5LVRxrAe5Nj1OFtrCoBJ/IOoLegjQ5nbabfuWZseYWGDhZGqQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7577
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:12:32 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 91a6ea783200..ab96af8d9953 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -7,6 +7,7 @@
>  #include <linux/kernfs.h>
>  #include <linux/fs_context.h>
>  #include <linux/jump_label.h>
> +#include <asm/resctrl.h>
>  

Please use empty line between the different groups of headers.

The rest of the patch looks good to me.

Reinette