Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <3f448b5e-de75-35fa-02ab-7cbd37389227@intel.com>
Date:   Tue, 3 Oct 2023 14:13:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 08/24] x86/resctrl: Track the number of dirty RMID a
 CLOSID has
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-9-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-9-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFdoMUtiN2JyRm4zS0hwTU8wdzlpdkNUUzJLeHkyRjRjMkM4Q0VnVFJubU50?=
 =?utf-8?B?ZEM5NXoxSUExcUFQdENjZWdBMHNjMy80VHZhOGJVbTJXeVY2M1pnYmRBU0ln?=
 =?utf-8?B?Z2lxYUdrdWdaR1VwTHoxQy82ejhncnVZMVhaNERNY3lXSHZZc1h3YVRsR1J1?=
 =?utf-8?B?cGRTK1Y1emsrRTJhU1gvdDZNSE9vWnhoRFRWdVljOUdYT3gxWnNLQkdzZnRY?=
 =?utf-8?B?V1VldTZ3WWNwUFMwT1RrcEwxU1RMVDRWd2cvYldDY0R2dlFpbmJWd0UxQ3l3?=
 =?utf-8?B?N2R5ZWhJNGxoa0FPRUttNE00aWt0eFRJM0dGbmwxclY5Wlhad2Q5OXkwMjhK?=
 =?utf-8?B?eDJCZHpNWjBWMVRpemk1SGVkSkE5b2dXY2pFbFdqZkNBcWRhWEtRK3pyK0Ja?=
 =?utf-8?B?UWMwdDZ4VldTcWZIOGsvVFNyUE9VU2U1V0trZ0tORHdtSURIRjZuSE90QUE4?=
 =?utf-8?B?dmRnRmQxQjVKVUtubC8rVFVtZnlrUWJkVXNqUldSUHhvMkVlZWFvdFBvOFI2?=
 =?utf-8?B?YVZheFY1NEVacitBVUdnRmxTb3FUUUtVdVY3Q0pwa2c1LzV0T0lja0tNc0ln?=
 =?utf-8?B?SlhhT3dPNUs2NUkvOHhBeXU0Qk5JN25qTkxmWThha0pCa0Fac1FzR0gxTlFR?=
 =?utf-8?B?TWVTWVlETGg0OXVvd2xNM2lTWVJKTC9RZk1TaDFrVFZXa1VXVVo4MFA3Z3ZV?=
 =?utf-8?B?U2JZRERSWjV4cSsxK0g3Y2JhTk8xUTk5S2c0MXVMVVdNUUhldm5CU3BqS01Z?=
 =?utf-8?B?WGt1QmFOeDlRQ3V2dWlJMzA0WlR0QlIzZVB6SzlpVmdTN2hSNzczay9mYnNQ?=
 =?utf-8?B?VlhYMWVva0ZqNjBCM2N2VmRlcDI0NHE4RnRTaGRYMDNLR0ZEbks3NDNOQVA2?=
 =?utf-8?B?NUx2YkVnMkt6c21naElmUkZKeVhVODBLVWRHZTJ3OFh5WDliQ3ZaaktIVUdG?=
 =?utf-8?B?ZTc5Y2dBUlFLS2pEYVVoSEVXeDJtYzRsdU5jK3dORk5POGo0bWw1SFRXTDBx?=
 =?utf-8?B?MGpvVlplRU1ncjFJak9ScmtITkFZdlRldWNPN2wyOUNvL2JtVWNWR0k1QUpk?=
 =?utf-8?B?NVI0TmVKTUxNWUxlZVNmNGs3SlJrREZUa1FXWldKa2NlZEExNzJDZCtFRC9o?=
 =?utf-8?B?N0xpYUpud1NtNFVBcS83VDVqdGRtQlYvNVhxTjVKc29JekhIaWtNR3VqSnNZ?=
 =?utf-8?B?SnNPdlV5WXNsbWU1ZlFsZmRvS05qQ0ovSUhiUjJ3NUdadEFLbENBUU1FbTJ0?=
 =?utf-8?B?Sm5yeHRnbklwSVBsU0tDcmMzN2pMbkE5OVlvbnAyVWFQRHdwZFE5eGhjdmxj?=
 =?utf-8?B?cU90RmVtUEIxSmVUbFYxS01ER1duRUpWRGVmOERYYmdIcEhUNnF1ZHB4cDBP?=
 =?utf-8?B?RmowTmNSL2UxY054TlNueXJlYkJQazM1a1dKamxhL2ptZ1lLN0hlZWNLOHFq?=
 =?utf-8?B?ZVFDanZnMVgrdkZIdTV0Qzc0Q3N3MTNHMFdyTktncGtNWWVtOTMwaGxndkpk?=
 =?utf-8?B?VGg1aGlrUnd0b2c5anVVdDN5ckRkTHhNWnpUWXdQV0cxeGpNbm5TalZBakxQ?=
 =?utf-8?B?SWIwWWFLVGZ4dGk5bDBHTTlLYmdDNENsNGY2QVdUTXhESGI4S0FjdUszbUtW?=
 =?utf-8?B?dENsWGEwME1hbU1tYVl2eFY3bmIxclJ2WHVQYytzd2Vyb0t3MzdUenJCV2lh?=
 =?utf-8?B?VVFIellNZXg3UUdFc1Rkbkhub2pRazdweDZYNXI2ZlZ5NHZGODlrR05kWUQ4?=
 =?utf-8?B?eS9MSHF5bUExK0FvMHZUa1NUQkNwK2lZbDJmMjQ5bDhDaUtPbFRzRnM2djVG?=
 =?utf-8?B?bDdYWFNGN0V4RXlUK05rZzN5L3hYcWczSjRjSWREQUF5NFdEb3NvZnNBdTAw?=
 =?utf-8?B?SDRNMXIvMEgvSkFDWHRqSExQTzl3RTdrTzhheUtiWFRRQVZWa1IwMGJmUk1P?=
 =?utf-8?B?NWdBOWhOY2JLTlZxRTFyYUppZFRTM0VWLzI0YXZINGJtQVVJbWphTmpJbkdE?=
 =?utf-8?B?SlRKRHFmMEpHUkNxaExxY2U2bWxyL3VjS3ZGVTFxZ1FzZ2dyTTB6Q0hNYUl5?=
 =?utf-8?B?Y0hGLyt4QkpHUmlOMk16QXhTczk1RVFVb1licmMxY2RJemdQTXRYanpNRzVC?=
 =?utf-8?B?dWlPQ0VaQzltcUdPcG5TUE53N0xpbkNiM0ZmQUhuUVR6UFVzc0Z0NnJIUUVU?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c6aedd7b-a6e3-4bd3-27dd-08dbc4559d26
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:13:39.2670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IF+7D4yzVPhPF7sSLyHlZO2O3eDrvlP4lW6Vqh3XbmcPaGk4W4xIz8S7dzM0U32xtA5S75vfhwlmPt8i0lHC4CzXUOaCG7zpi5XlXCjK19M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7577
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:13:57 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:

...

> @@ -796,13 +817,30 @@ void mbm_setup_overflow_handler(struct rdt_domain *dom, unsigned long delay_ms)
>  static int dom_data_init(struct rdt_resource *r)
>  {
>  	u32 idx_limit = resctrl_arch_system_num_rmid_idx();
> +	u32 num_closid = resctrl_arch_get_num_closid(r);
>  	struct rmid_entry *entry = NULL;
> +	int err = 0, i;
>  	u32 idx;
> -	int i;
> +
> +	mutex_lock(&rdtgroup_mutex);
> +	if (IS_ENABLED(CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID)) {
> +		int *tmp;
> +
> +		tmp = kcalloc(num_closid, sizeof(int), GFP_KERNEL);

Shouldn't this rather be sizeof(unsigned int) to match the type it will store?

> +		if (!tmp) {
> +			err = -ENOMEM;
> +			goto out_unlock;
> +		}
> +
> +		closid_num_dirty_rmid = tmp;
> +	}
>  
>  	rmid_ptrs = kcalloc(idx_limit, sizeof(struct rmid_entry), GFP_KERNEL);
> -	if (!rmid_ptrs)
> -		return -ENOMEM;
> +	if (!rmid_ptrs) {
> +		kfree(closid_num_dirty_rmid);
> +		err = -ENOMEM;
> +		goto out_unlock;
> +	}
>  
>  	for (i = 0; i < idx_limit; i++) {
>  		entry = &rmid_ptrs[i];
> @@ -822,13 +860,21 @@ static int dom_data_init(struct rdt_resource *r)
>  	entry = __rmid_entry(idx);
>  	list_del(&entry->list);
>  
> -	return 0;
> +out_unlock:
> +	mutex_unlock(&rdtgroup_mutex);
> +
> +	return err;
>  }
>  
>  void resctrl_exit_mon_l3_config(struct rdt_resource *r)
>  {
>  	mutex_lock(&rdtgroup_mutex);
>  
> +	if (IS_ENABLED(CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID)) {
> +		kfree(closid_num_dirty_rmid);
> +		closid_num_dirty_rmid = NULL;
> +	}
> +
>  	kfree(rmid_ptrs);
>  	rmid_ptrs = NULL;
>  

Awaiting response on patch #2 related to above hunk.

Reinette