Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <efcd11ac-f037-949c-6563-984684f9bc57@intel.com>
Date:   Tue, 3 Oct 2023 14:14:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 09/24] x86/resctrl: Use set_bit()/clear_bit() instead
 of open coding
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-10-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-10-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejRqclBlYjNmcTMzK0dCTENPSDdydWRjdnVQSlZxMU1VcVptdHZjVzhvRkRs?=
 =?utf-8?B?Sy9vbTROd0hYb0hTdTJoQ1NCcjJlcUQzT2tZUGMvdC91UHdMZ0trU01kdFB2?=
 =?utf-8?B?UE8zL3VWYzJIYmtNcXNsb0k5LzNudm9mTlA5azFuY21zbmZpZlpGc3RYcEVz?=
 =?utf-8?B?YVl2ZjJqNVZEbWFHMTZKUGRZRTBSNi8zVDY0Yk41RmhCK0x6dGZKZk5aMXFp?=
 =?utf-8?B?YkZGYzM5QmdMMWpTT1pUdU1mRk9qQXZQNnp2NVB5NXBTY0hZcTFMV3MxdytB?=
 =?utf-8?B?eHoxdHZlbllrT1JUcmJuYzl1akd2dzFPWXVBZUJsNDBRWGhJOGYvV1hlRVN5?=
 =?utf-8?B?dkpLSFRkb0REOE9sdEthYmxOQWJ3cTB6MlRRcVV4eG1mbFdzV3ZGSUVIUEU4?=
 =?utf-8?B?bGkxemgxa21zUmpwTW1nT3J0TXdlTDJQaENYb2FHMjV3bmd0QjB6VTBXKzhG?=
 =?utf-8?B?UXFrVWdPZ0dNWGlvNElMN01ncmxjOTd3SFh0ai9GcEZLekVwNjRMZlF0NkRv?=
 =?utf-8?B?UXBHN3FGNndPSFQxak5BNm1qQ1VtbXVraVZCMUhQWHZ2dnVwWWlLcXYvUTBr?=
 =?utf-8?B?REJ0bTNkTWFILzEweHNJTHNEc2FaNXJCRmV1RW1oc056UHhVUkdLNGM2OVU2?=
 =?utf-8?B?RWlyVzc3YitJeHNjYTVEcnhycXl3UGRDRHNYUVQ1Q0JROVZzVmFNVzJNZ1pQ?=
 =?utf-8?B?ZTMvSzlnRENrVUc5aHVBY3U5ODl6OHNRVERzTGpEck1Tb0JKOENEL3FLS3hB?=
 =?utf-8?B?UGNCVEF5bXI5N3JoekVRaVlEb3FBcUpLam9Ma2dtOEFXbk5yYldqTkV6TXF3?=
 =?utf-8?B?Ly9TRVFpdnVqNk9lbmVwVmVQR3MyVmFmQVIzTXZ4TTRFUmdRU0d5MXUyQVVJ?=
 =?utf-8?B?d1FWTWxPdlNzbEZFMTYvU1VlOHRBNlZrSEtDamF1MTlHVm84RDZyWCtiTjFa?=
 =?utf-8?B?a2J0MHFoOXVQNVVpb2txOVVJNEhrQldyVExVYTNST2YyN2ZPc3RWMlRrU3Rz?=
 =?utf-8?B?Y01MaDhKYjRXcHIyMkpJbXRuNk9EWUxWR3RYRno3MG4zYTJIMHlRMUR0Tm4y?=
 =?utf-8?B?T096bDJWMmo3TWp1VWlSSjhXbFB6ekhBbE9KQVFKZU41enFsR2daRWV1WGtX?=
 =?utf-8?B?d0VXbnY0by9oYkQzdkpYMEk1emFrdDc3ZDR5cSs2Nk5iVW5YMDd6alI4UVA5?=
 =?utf-8?B?NEN2Kzdrd1k0cjRGbGdHRCtnZ3BnYStMTS9PN2dMZmNGQ1RkMDdEOWlmS1BJ?=
 =?utf-8?B?Wnd2dHZpZUFveEJTeUNIZGlXcDFhVVBZNmJDV0FTd0EzZXl0WnVranQ3a0ZR?=
 =?utf-8?B?V1hsOWt3akpLYUp4aTNlNFdtV0dUNFV1Rk5udjlmTUZZZUJGN2kyZExISjh0?=
 =?utf-8?B?ZmdnRXJCdFV2TmcvalVVUmo1ay9VTGdnU2ZBbS9Cbmh1aEtMeXdZZ3hmR2xY?=
 =?utf-8?B?YWxaVW00c2pSRUttVUxjT3d5RnJ3U3ZYUWw4OUErbEd4cnE4dFlHeDJxVjlo?=
 =?utf-8?B?eldkT3JrRXljeVp5bEJkT2QwNllKYzVyYXIzSzkzUHdlVDB1Y0tCeE5xNUZa?=
 =?utf-8?B?bjQ4UG05NUNsTTE4TzBUaEdSRXFrMzduTjFOYStjQkh4cVduOFFscks1bmt0?=
 =?utf-8?B?KytnWEdVZnhYRFRSamUyVXMxQ1JMK2g5cUtCWlB4d2JmSHRhM2h6Tk9FVXdI?=
 =?utf-8?B?TytzWVlsNkF2UmxWOSsxakd1RFlhcWx0S29KWllyT1pSK3EvbjJYK085dWFt?=
 =?utf-8?B?cmhMTENBdm9RK1h3KzZsVk1FODZSR2RMcFpyTEYwejNFdnZjVUgwMHc1eDJR?=
 =?utf-8?B?SFVwMU82RGhoQi9SajlJdE1WMllVNVFBTlNiUzI1bGVuWUtYZ1gzS3Npa3p5?=
 =?utf-8?B?anBpTTE3WFBoTlNENXRlM0MrbEJ5UzRHajVjM1huYU1sY1FlM1lFZXB1b1dr?=
 =?utf-8?B?STZMTFd0WjRLbzVsQ1RxYVp0YzMvQXp6c0FCbzhVbEl2YldNTUQ3VXNZSUtp?=
 =?utf-8?B?K3pGdytFZzFSRWltQU01T3RXNUFsYlp2Sm9Ed2hpd1YzUHE4YzRHM3JzU2cy?=
 =?utf-8?B?bnhhWDNnK0J5SzNHOWRtbmY4aFpqRmFuZG56MWtDK21FSG9WVllibHRNbG0y?=
 =?utf-8?B?QWdOaDI2YU5saGdyRHlGMlM0cGtyUG5HY1dlZ1d4K1lJKytwdFlYSURWMVVx?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b3f2d17-b1fb-4323-ab74-08dbc455b923
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:14:26.2161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ACp9ZW0GPcLcOPaNGw4KZQ/8Wdk2ngb7zXZHe2JGcuy5hPQHuaihFexANUmQwLHd/jmr3EwgF5r6CX/f3EJktFKrq/pzrbb0AJ0+r6mODp8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7132
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:14:45 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> The resctrl CLOSID allocator uses a single 32bit word to track which
> CLOSID are free. The setting and clearing of bits is open coded.
> 
> A subsequent patch adds resctrl_closid_is_free(), which adds more open

resctrl_closid_is_free() is not added in this series.

> coded bitmaps operations. These will eventually need changing to use
> the bitops helpers so that a CLOSID bitmap of the correct size can be
> allocated dynamically.
> 
> Convert the existing open coded bit manipulations of closid_free_map
> to use set_bit() and friends.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index ac1a6437469f..fa449ee0d1a7 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -106,7 +106,7 @@ void rdt_staged_configs_clear(void)
>   * - Our choices on how to configure each resource become progressively more
>   *   limited as the number of resources grows.
>   */
> -static int closid_free_map;
> +static unsigned long closid_free_map;
>  static int closid_free_map_len;
>  
>  int closids_supported(void)
> @@ -126,7 +126,7 @@ static void closid_init(void)
>  	closid_free_map = BIT_MASK(rdt_min_closid) - 1;
>  
>  	/* CLOSID 0 is always reserved for the default group */
> -	closid_free_map &= ~1;
> +	clear_bit(0, &closid_free_map);
>  	closid_free_map_len = rdt_min_closid;
>  }
>  
> @@ -137,14 +137,14 @@ static int closid_alloc(void)
>  	if (closid == 0)
>  		return -ENOSPC;
>  	closid--;
> -	closid_free_map &= ~(1 << closid);
> +	clear_bit(closid, &closid_free_map);
>  
>  	return closid;
>  }
>  
>  void closid_free(int closid)
>  {
> -	closid_free_map |= 1 << closid;
> +	set_bit(closid, &closid_free_map);
>  }
>  
>  /**
> @@ -156,7 +156,7 @@ void closid_free(int closid)
>   */
>  static bool closid_allocated(unsigned int closid)
>  {
> -	return (closid_free_map & (1 << closid)) == 0;
> +	return !test_bit(closid, &closid_free_map);
>  }
>  
>  /**

The patch looks good to me.

Reinette