Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <015a4cac-f8d1-eeeb-a0f2-f423ab086e3b@intel.com>
Date:   Tue, 3 Oct 2023 14:14:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v6 10/24] x86/resctrl: Allocate the cleanest CLOSID by
 searching closid_num_dirty_rmid
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-11-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230914172138.11977-11-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TExuZ2RIZkRPZlU1TElzZjh5V2xRVHJXZVlOa2gxZElEZVBQc2p1bXBxSWZi?=
 =?utf-8?B?QzVzdmJmSVoxd2FNYllZblZGa3ZaUkI0SmVnWVV6dmhFaW5iMEVMZGI4cVAw?=
 =?utf-8?B?YkhveWY1MVJYcVpZbVBWZi9MK3NiYUtILzRPQ1FSNDdFNUV6WE9XV2d1RExz?=
 =?utf-8?B?clpaWVBNb1l3dlpabGhXOG4rVEd3ZmQrd2U3MEs5Wng5NjRSMEFKY3l6aTV5?=
 =?utf-8?B?ZXVJN1BtYmo5ZHZOQkx5SHZ3NTNxelNZT2hpcFFRbnRaSGxQYWlXYldMMTdu?=
 =?utf-8?B?L3dHOGdCT2NCbElPek1YUTYxOFVwWk5scTBLZmEvRlZYTHpzbWcxTi85eUFH?=
 =?utf-8?B?eDhhc3hjSmV5ZVkybmk0anJyU01Vblc2UkF3TDJQSDROSEJGeHBpcmJTcWlS?=
 =?utf-8?B?NHBiQUlvd1cxZ0JEakxDZnpxUDE5MlkrYVNBR2wwdWlMVi9QS0hENVZUK245?=
 =?utf-8?B?OHloR3FvOVlLUGtKa0kwZXhxV25kQnhmMGV5QVcrQ29zVTdycUIyc2tKdytH?=
 =?utf-8?B?OFJsYkFwN05BM3Q2eGtTcjBFVk1tc2lDeThKYkZVci9JL2NzaUtMM2o0YnM3?=
 =?utf-8?B?QkU3dTRXVDZmV3hEdGhZb3dseTJXdmFJWnR3dXpKbVkxdU5JdERJd0NUYjJY?=
 =?utf-8?B?QlY3ckkwVEpFMHVEc3RMUVI5dWJaNnJ5R2NlVUV1M2hzSUpzbUQ4SG12MWkw?=
 =?utf-8?B?RTZjRnJ4clY4L0Z2aGpyOC9zSjFRci9ha0wzWDllelc5UkU3WHlzRDZxZ1gz?=
 =?utf-8?B?WFA5c2R3ak8vT2dVenNXZDFHTG1kRHBQWHBsdWtQaVFpN212Zkg5Tmdwemxk?=
 =?utf-8?B?M2dYallSVWM1akRSS1k0U1JSR3h2V0ZyU004YUNXZ0J2enp4MEV0dFo3Vklm?=
 =?utf-8?B?WlJ4STUxSVlNOHFvYVFldjVnVTVLU1U1RDQxbVZ4RlNsd2RXLy8rblhqNFp1?=
 =?utf-8?B?TTJmald3NGdRQjdxNExMTmFvMXJ3WUZEM0k0cUxvTkdyMmZMMWFNMk5hZ1Iv?=
 =?utf-8?B?WTkzNzdXUDh0dUF5SS8wVU5LOGNSWkwxUE9qckgwRk1GZFBKcVZGblpaWWp0?=
 =?utf-8?B?Ky9wdC9PY3ZvV3FyVkhCaFNTS0wvUzFXT0FETmpFRlU4dXl1VmthVE1aTUV1?=
 =?utf-8?B?VWNIZ2tacmVmYitDZmlOU1RqK2pkbGNYTjhzRW5Mc1RQcUVlcE94bm9qRlhD?=
 =?utf-8?B?cGVGcHpwUjl0azBPSXAySXk2L2hDQysxMld4TnM3RFhndCtZMVlzMFhabllr?=
 =?utf-8?B?UTBPMVhvUEJsUWdJN0wwQXZGc2pLMCtCN3UxVjlhNy85K0pJQ05sMVUzaHFE?=
 =?utf-8?B?ZG9ZcmR0a3luN1ZpWnJQemwxdmJvUzJvMG1kcFNKRnRkWEwvNCtXdzNNbE5n?=
 =?utf-8?B?ZnVsNjdsWmVaQ0dVd2ZBcUNtc2M1bUZ2RUdVTjUrV3ZkNnQyanJQYmg0YmpD?=
 =?utf-8?B?NytqZ1RGam5wcGFKU0FlWVN4UjNmYjVSdzgzM3lUQkFIbHFEUHkrdFNJVVBt?=
 =?utf-8?B?UHNIZWFkNWtyQ0ZEK0pzZlRBZGR1QUNiOGQ2MWliWDY5Y3h1ajZZdnZTbEVx?=
 =?utf-8?B?cWhvdXNQcTkzOTczZzJia1JGcDZxVFdBMktVa3JwZnZhU0RtVUZGb3V0R2cv?=
 =?utf-8?B?b3g0MWZIelhIaFQ0Kzk4OHM5WVFBOGhtOCtYbjM2THBIZkZ3MGVrZXlwa1hK?=
 =?utf-8?B?eFd3ZlIySjNXT0UreDJkNHRmc3pGVzdxbmE0eUpodFYzUkdiNkZNSEVxRVV5?=
 =?utf-8?B?UHRmM2ZUREhiNzZEanFraXk3dTQrckV2WkN3OHUwMFUwaGhlZy9WOWZIN3VC?=
 =?utf-8?B?ZmdUa2N2cFlybFc3QVJRR0JKOU1SbG9WRmIyQ04xeE9ocFU1RERyTjZEeFBM?=
 =?utf-8?B?R1N1NFFCTkFzV2lKU0ptV2w4VzdFUUt1T1VWSnhTeTRQVld2aGJCQ0VxV3dP?=
 =?utf-8?B?ajBobUtra3VQT09QK29WZ0QzU1FEbXpSdjFRWHgxNFdFbkZPeE0rOGJOVXZH?=
 =?utf-8?B?RjQrNUhkZmJhMEw0WlhqanBESDFsZDFVM2FjNzZnemJpZmZLYmpwNjltMUpU?=
 =?utf-8?B?RDV4MlhqeWxDQWRCcXRieUE5OERmeFVERjM5WGlnaW9HNVp4WFluUnFtSXMv?=
 =?utf-8?B?ejRRakxLSXdGTUpJb3pjaTk3cFNuSFk2V1pmWHU0eU9vZlE0VjhSb2ZpY0Vm?=
 =?utf-8?B?VkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a662a03-1f41-4981-62c5-08dbc455c518
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 21:14:46.2297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/3skRPlInhsj+PPqve8wCo1FBKyE6s1ATX5+QlQa3vx/5+S/r4ktaAlNPtwx9FMLOghDRipf+6/genXSCjeDTVicKCGNybMkKDAPYDgHfQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6059
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 14:15:01 -0700 (PDT)

Hi James,

On 9/14/2023 10:21 AM, James Morse wrote:
> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be
> used for different control groups.
> 
> This means once a CLOSID is allocated, all its monitoring ids may still be
> dirty, and held in limbo.
> 
> Instead of allocating the first free CLOSID, on architectures where
> CONFIG_RESCTRL_RMID_DEPENDS_ON_COSID is enabled, search
> closid_num_dirty_rmid[] to find the cleanest CLOSID.
> 
> The CLOSID found is returned to closid_alloc() for the free list
> to be updated.
> 
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>
> Signed-off-by: James Morse <james.morse@arm.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette